zergtmn

Patch for rev. 10048: http://paste2.org/p/871233

Fixes:

- Haste affecting channeled spells

- Aura 316

- Mage т6 two piece bonus for Evocation also works

- Shadowform haste bonus & support for shapeshift boosts with cooldown http://paste2.org/p/871235

Thx Laise and Wojta

Sorry, I missed second part.. Should work ok

Now it's working like:

1. Teleport to instance

2. IsEncounterInProgress? - yes

3. Tele back

How it's working on offy

1. IsEncounterInProgress? - yes

2. areatrigger doesn't allow enter

thats the code that is working on 3.3.3a i added manually and works fine

Author is me.

http://ru-mangos.ru/showthread.php?t=1304

I lol'ed. "ppl" was translated as "Закон о госзакупках" that means "the law on state purchases".

Google translator is a crap.

It requires implementation of OutdoorPvP.

wrong topic

-        const float mid = 0.5 * 64.0 * 533.33333333;
+        const float mid = float(0.5 * 64.0 * 533.33333333);

Instead, you can just add f suffix like:

const float mid = 0.5f * 64 * 533.33333333f;

Great idea.

What is the reason to have Meets and MeetsCondition at same time? Also, replacing enum with int8 looks bad.

Not related to this bug, but when Drain Soul misses only debuff aura isn't applied, player buff is applied and animation starts anyway.

/me throws hands up in frustration.

So what needs to be done so it is acceptable for the core? Perhaps some sort of checklist of features that need to be reworked would give any volunteers a place to start.

From what I know:

1. First bug: enter 25-player WOTLK raid instance, restart server, enter game and you will get into 10-player version of that instance. Difficulty is not saved.

2. There are two exploits to bypass permanent instance binding. One can be fixed with patch from first post, but it's non-blizzlike hack.

3. Old exploit to bypass areatrigger requirements is still working.

4. Another bug (or not implemented feature): die in instance, logout, you will be teleported to graveyard. On offy you remain in instance.

Instance system needs some love.

srry but is this is complete why isnt at the review section?¿

Probably need implement shared queue between normal and random BGs first.

Hope to see this in the master.

It's hack that will never get into master.

Patch: http://paste2.org/p/844681

Better to remove this part entirely.

On Russian forum:

GO type 33: http://ru-mangos.ru/showthread.php?t=86

SotA: http://ru-mangos.ru/showthread.php?t=531

yea, you are right. =\\ So any ideas how to check and reapply bonuses if need?

1. Disable enchants that require skill before removing that skill

2. Enable enchants that require skill after skillup (and enchants that have minimal level after levelup) if their requirements become satisfied.

I'm too lazy to fix it, so I reapply all enchants

Update. Fix possible exploit.

Players will lose HP and mana on each skillup.

That spell works well...

Cast not in Dalaran Should crash on clean core.

Somehow the m_currMap doesn't contain a map (I think it's either empty or a null pointer), should be some way to backtrace where this originated, need to figure out why the m_currMap doesn't contain anything.

Try .cast 53360

VS2010 is RTM already.

Nice patch Going to test it.

Have you tried to use search?

For which repository revision was the patch created?

9855

This talent was removed from game in patch 3.1.

Patch:

http://github.com/zergtmn/mangos/commit/2cf87801b622aa626a3a493e83aa4c1185f8eda5

or

http://paste2.org/p/819958

For rev. 9851

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 98a55c2..ba72091 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -495,7 +495,7 @@ void Unit::DealDamageMods(Unit *pVictim, uint32 &damage, uint32* absorb)
    if (!pVictim->isAlive() || pVictim->isInFlight() || pVictim->GetTypeId() == TYPEID_UNIT && ((Creature*)pVictim)->IsInEvadeMode())
    {
        if(absorb)
-            absorb += damage;
+            *absorb += damage;
        damage = 0;
        return;
    }
@@ -508,7 +508,7 @@ void Unit::DealDamageMods(Unit *pVictim, uint32 &damage, uint32* absorb)
        if(area && area->flags & AREA_FLAG_SANCTUARY)       //sanctuary
        {
            if(absorb)
-                absorb += damage;
+                *absorb += damage;
            damage = 0;
        }
    }
@@ -523,7 +523,7 @@ void Unit::DealDamageMods(Unit *pVictim, uint32 &damage, uint32* absorb)
        ((Creature *)pVictim)->AI()->DamageTaken(this, damage);

    if(absorb && originalDamage > damage)
-        absorb += (originalDamage - damage);
+        *absorb += (originalDamage - damage);
}

uint32 Unit::DealDamage(Unit *pVictim, uint32 damage, CleanDamage const* cleanDamage, DamageEffectType damagetype, SpellSchoolMask damageSchoolMask, SpellEntry const *spellProto, bool durabilityLoss)

http://paste2.org/p/818174