Auntie Mangos

only because a patch works "as intended" does not mean that this patch is correct. if you have a call from function X to function Y where X gives a wrong parameter to Y you've to ways to 'fix' it: 1. modify the function X and give the correct parameter 2. modify the function Y and create a workaround 3. modify the function Y and simply drop any error checks -> no more errors 2 and 3 would never be accepted, and to be sure that this patch is like 1 it takes a moment to fix it. and it always depends on the size and on the impact from the patch, adding a patch means adding/modifying code in the core which the devs will have to maintain. i hope you understand now why it takes some times until a patch goes into the core. but yes, maybe it's slow, maybe some of the workflows might be changed... but for that there's this thread: http://getmangos.eu/community/viewtopic.php?id=4216 -- DasBlub

What bug does the patch fix? What features does the patch add? * Sanctified Retribution and Swift Retribution are triggered for auras other than Retribution Aura, and Improved Concentration Aura and Devotion Aura are triggered for all paladin auras * If you applied this patch (or through some other method, disabled/removed/made mangos ignore the cooldown on the triggered spells of Aspect of the Dragonhawk/Presences), Aspect of the Dragonhawk's dodge bonus, Frost Presence's health bonus, and Unholy Presence's movement speed boost are correctly cast * Also fixed incorrect/hackish (or replaced with another hack, depending on your perspective ) removal of the warrior's Blood Frenzy debuff. This is a more logical place to have the debuff removed, and now it checks if Rend is still active when Deep Wounds is removed, or vice versa, before removing Blood Frenzy. * and fixed some SpellSpecific checks that were needlessly complicated. For which repository revision was the patch created? 8198 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. Frost Presence - http://getmangos.eu/community/viewtopic.php?id=7751&highlight=frost+presence Aspect of the Dragonhawk - http://getmangos.eu/community/viewtopic.php?id=5918&highlight=aspect+of+the+dragonhawk didn't find any others Who has been writing this patch? Please include either forum user names or email addresses. Myself Patch I wrote a new method, Aura::HandleSpellSpecificBoosts, modeled after HandleShapeshiftBoosts, to add these hidden triggered auras because the effects are very similar. Personally, I think that "boosts" have more to do with SpellSpecific (for lack of a better term that unites Paladin Auras, Hunter Aspects, Warrior Stances, Druid Forms, and Death Knight Presences) than SPELL_AURA_MOD_SHAPESHIFT. So ideally, I think that HandleShapeshiftBoosts could be merged into HandleSpellSpecificBoosts. Or maybe a new definition should be created for these spells first.

http://getmangos.eu/community/viewtopic.php?id=7438&highlight=security+levels Thats your 1 free search, next time, you will be expected to figure out the forum search function for yourself

* What bug does the patch fix? What features does the patch add? . Make the random numbers interface thread safe. * For which SubVersion revision was the patch created? 6397 ported to 6415 * Is there a thread in the bug report section? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.p...st&p=200806 more info: http://getmangos.eu/community/viewtopic.p...st&p=200917 * Who has been writing this patch? Please include either forum user names or email addresses. me Note: the second patch is for ppl that use the ace netcode ,if they have svn conflicts.

Project support was dropped because of WoW Community Site development. Thanks to everybody who used Armory (and using now), who helped with bug reporting and bug fixing. I'll glad to see you in new project --------------- Some statistics: Shadez/wowarmory statistics: Total commits: 483 Total additions: 505448 Total deletions: 1812 Contributors to Shadez/wowarmory (since RC1 version): Shadez Total commits: 470 Additions: 505260 Deletions: 1771 roelv Total commits: 2 Additions: 39 Deletions: 3 duergar85 Total commits: 2 Additions: 22 Deletions: 4 Ashen Total commits: 2 Additions: 19 Deletions: 9 SignFinder Total commits: 2 Additions: 6 Deletions: 6 Filo Total commits: 1 Additions: 75 Deletions: 1 thundergod221 Total commits: 1 Additions: 17 Deletions: 7 Vasago Total commits: 1 Additions: 2 Deletions: 3 noyu Total commits: 1 Additions: 5 Deletions: 5 Drethek Total commits: 1 Additions: 3 Deletions: 3

[PATCH] "Custom Command" .modify mirror This can be done with the full help of Slurm thanks budy What this patch do? -You can select a creature and mirror the dislpayid of this creature on your character. This is good if your realms are full of little kids and want be all they see inside. [idea]: Taby (My bb of 5 years old) : Slurm [Patch Autor]: Yim [Revision Work]: [10199 and beyond] [%WORK?]: Tested - Work [url="http://getmangos.eu/community/viewtopic.php?id=14608"]Original Post[/url] [code] diff --git a/src/game/Chat.cpp b/src/game/Chat.cpp index 8dc9148..8ceaa09 100644 --- a/src/game/Chat.cpp +++ b/src/game/Chat.cpp @@ -350,6 +350,7 @@ ChatCommand * ChatHandler::getCommandTable() { "morph", SEC_GAMEMASTER, false, &ChatHandler::HandleModifyMorphCommand, "", NULL }, { "phase", SEC_ADMINISTRATOR, false, &ChatHandler::HandleModifyPhaseCommand, "", NULL }, { "gender", SEC_GAMEMASTER, false, &ChatHandler::HandleModifyGenderCommand, "", NULL }, + { "mirror", SEC_GAMEMASTER, false, &ChatHandler::HandleModifyMirrorCommand, "", NULL }, ///// yim mirror { NULL, 0, false, NULL, "", NULL } }; diff --git a/src/game/Chat.h b/src/game/Chat.h index b82899e..f6d9ef6 100644 --- a/src/game/Chat.h +++ b/src/game/Chat.h @@ -275,6 +275,7 @@ class ChatHandler bool HandleModifyArenaCommand(const char* args); bool HandleModifyPhaseCommand(const char* args); bool HandleModifyGenderCommand(const char* args); + bool HandleModifyMirrorCommand(const char* args); //-----------------------Npc Commands----------------------- bool HandleNpcAddCommand(const char* args); diff --git a/src/game/Level2.cpp b/src/game/Level2.cpp index 03a8c8a..dce483d 100644 --- a/src/game/Level2.cpp +++ b/src/game/Level2.cpp @@ -4694,3 +4694,22 @@ bool ChatHandler::HandleTitlesCurrentCommand(const char* args) return true; } + +//mirror +bool ChatHandler::HandleModifyMirrorCommand(const char* args) +{ + Creature *pCreature = getSelectedCreature(); + + if (!pCreature) + { + SendSysMessage("Please select a creature."); + SetSentErrorMessage(true); + return false; + } + CreatureInfo const* cInfo = pCreature->GetCreatureInfo(); + + m_session->GetPlayer()->SetDisplayId(cInfo->DisplayID_A[0]); + //To my knowledge in most scenarios DisplayID_A[0..1] and DisplayID_H[0..1] should be the same. + + return true; +}

Finally it works with 3.2 ?????

http://getmangos.eu/community/viewtopic.php?id=3018 i think you search for some like this

I just recently read anothe thread about this, it wasn't your double post, but an older thread. http://getmangos.eu/community/viewtopic.php?id=6504&highlight=maiden+of+grief All you had to do was search , maiden or grief, or heroic, or all those.

Here's the thread where it was submitted to the under review section: [patch] Race/Faction change It was buried way back on page 5, which isn't very encouraging. A lot of good, promising patches in the under review section seem to be dying off. DJNefast hasn't worked on this patch for quite a while and this topic here in Core Mods actually has more recent data.

http://getmangos.eu/community/showthread.php?14286-Vehicles-10052&p=117320&viewfull=1#post117320

Both of you are using very old cores. and LordPsyan: UDB is at 391, so your DB is also what could be considered old. Best thing is to update and then try. A process of elimination will soon tell you exactly what was the problem.

XTZGZoReX insisted on this ..... it's the same thing eater use the value from db or use index++ but i think it's convenient this way for db ppl for when i will not provide data for upcoming quests since no one appreciated i headed out the data on a plate and started complaining why isn't the plate silver since is not every day you get hours of memory editing and parsing data for noting my bad for trying to bring something cool to mangos

**cough** http://getmangos.eu/community/showthread.php?8517-Which-Rev-Do-I-Use-For-Client-Ver-X-New%21 **cough**

What bug does the patch fix? What features does the patch add? It modifies calculation of Righteous Vengeance to add remaining damage of previous aura. It adds proc from Crusader Strike talent. UPDATE: Added Sheath of Light ( it has same effect as RV ) For which repository revision was the patch created? 8946 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=10673 Who has been writing this patch? Please include either forum user names or email addresses. Me DB part UPDATE spell_proc_event SET SpellFamilyMask1 = 163840 WHERE entry IN (53380,53381,53382); Core part diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index b373f80..27f2df7 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -5973,6 +5973,22 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu // 4 damage tick basepoints0 = triggerAmount*damage/400; triggered_spell_id = 61840; + + if ( !target ) + break; + // get previous aura + Unit::AuraList const &periodicAuras = target->GetAurasByType( SPELL_AURA_PERIODIC_DAMAGE ); + for( Unit::AuraList::const_iterator i = periodicAuras.begin(); i != periodicAuras.end(); ++i ) + { + if ( (*i)->GetCasterGUID() == GetGUID() && (*i)->GetSpellProto()->SpellIconID == 3025 ) + { + // add remaining damage to new aura + Modifier const* mod = (*i)->GetModifier(); + int32 tickCount = 1 + int32( (*i)->GetAuraDuration() / mod->periodictime ); + basepoints0 += int32( mod->m_amount * tickCount / 4 ); //damage per tick * remaining ticks count + break; + } + } break; } // Sheath of Light @@ -5981,6 +5997,22 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu // 4 healing tick basepoints0 = triggerAmount*damage/400; triggered_spell_id = 54203; + + if ( !target ) + break; + // get previous aura + Unit::AuraList const &periodicAuras = target->GetAurasByType( SPELL_AURA_PERIODIC_HEAL ); + for( Unit::AuraList::const_iterator i = periodicAuras.begin(); i != periodicAuras.end(); ++i ) + { + if ( (*i)->GetCasterGUID() == GetGUID() && (*i)->GetSpellProto()->SpellIconID == 3030 ) + { + // add remaining heal to new aura + Modifier const* mod = (*i)->GetModifier(); + int32 tickCount = 1 + int32( (*i)->GetAuraDuration() / mod->periodictime ); + basepoints0 += int32( mod->m_amount * tickCount / 4 ); //damage per tick * remaining ticks count + break; + } + } break; } switch(dummySpell->Id)

* What bug does the patch fix? What features does the patch add? Pet quest giver doesn't update status when player accepted or finished the quest. * For which repository revision was the patch created? [7760] * Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. Serials fixes for Children's Week:) http://getmangos.eu/community/viewtopic.php?id=7773 * Who has been writing this patch? Please include either forum user names or email addresses. Me. Patch: diff --git a/src/game/QuestHandler.cpp b/src/game/QuestHandler.cpp index 7e8e1a5..c458fe8 100644 --- a/src/game/QuestHandler.cpp +++ b/src/game/QuestHandler.cpp @@ -609,7 +609,7 @@ void WorldSession::HandleQuestgiverStatusQueryMultipleOpcode(WorldPacket& /*recv uint8 questStatus = DIALOG_STATUS_NONE; uint8 defstatus = DIALOG_STATUS_NONE; - if(IS_CREATURE_GUID(*itr)) + if (IS_CREATURE_OR_PET_GUID(*itr)) { // need also pet quests case support Creature *questgiver = ObjectAccessor::GetCreatureOrPetOrVehicle(*GetPlayer(),*itr);

What bug does the patch fix? What features does the patch add? Fixes the poblem that distract removes stealth from distracted and stealthed targets (rogues, druids). Fixes the poblem that Mass Dispel removes stealth from stealthed targets (rogues, druids). For which SubVersion revision was the patch created? 146ab472b6ae20e84c03f3782969f43156d5857b Is there a thread in the bug report section? If yes, please add a link to the thread. http://getmangos.eu/community/viewtopic.php?id=3358&highlight=distract patch: http://paste2.org/p/105085

@Blueboy I was unable to recreate the crash on my debug core (link to post containing the stuff im talking about) But you said you had the crash earlier...can you give me more details on when it occured? i tried, like the user that reported the crash, to go into a random instance with 9 bots.. it went fine...

What bug does the patch fix? What features does the patch add? This patch fixes damage done to target while Hysteria is active For which repository revision was the patch created? [11003] Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. http://getmangos.eu/community/showthread.php?9892-[rev-8416][spell][49016]-Hysteria Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 0c9588c..a4dc2c5 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -7670,6 +7670,13 @@ void Aura::PeriodicDummyTick() // Blood of the North // if (spell->SpellIconID == 30412) // return; + // Hysteria + if (spell->SpellFamilyFlags & UI64LIT(0x0000000020000000)) + { + uint32 deal = m_modifier.m_amount * target->GetMaxHealth() / 100; + target->DealDamage(target, deal, NULL, DIRECT_DAMAGE, SPELL_SCHOOL_MASK_NORMAL, NULL, false); + return; + } break; } default:

I can't get dual spec to work ether, and the new repo at edu doesn't work, I get merge errors all over thplace and when I get them fixed it still won't compile...I have no clue as to whats been done in the core to break dual spec but it used to be rock solid.

Crash Log http://getmangos.eu/community/showpost.php?p=89820&postcount=5 Crash Log http://getmangos.eu/community/showpost.php?p=89825&postcount=6

In [8064]. Thank you Loading errors for outdated recored i will fix in next patch as suggested early in ( http://getmangos.eu/community/viewtopic.php?id=8481 )

yeha it has been mentioned before somewhere in here: http://getmangos.eu/community/viewforum.php?id=22 cant remmeber what it was refered to so cant search but yeah, someone had a working idea...

http://getmangos.eu/community/viewtopic.php?id=6407 posting code here to avoid other questions later @@ -5721,11 +5721,11 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu triggered_spell_id = 58879; break; } } // Ancestral Awakening - if (dummySpell->SpellIconID == 2018) + if (dummySpell->SpellIconID == 3065) { // TODO: frite dummy fot triggered spell triggered_spell_id = 52759; basepoints0 = triggerAmount * damage / 100; target = this;

I am attempting to set up MaNGOS with ScriptDev2, ACID, and UDB. I have MaNGOS 11893, ScriptDev2 2433, ACID 3.0.9, and UDB 0.12.0 11792 with the additions up to the 403 update. I am able to successfully set up the databases per World of Warcraft Server for Windows (Part 14). At part 15, however, I am uncertain which SQL updates I should apply. My tables are as listed: characters table version "required_11785_02_characters_instance" mangos table version "required_11785_01_mangos_instance_encounters" realmd table version "required_10008_01_realmd_realmd_db_version" There are the following MaNGOS updates available: 11785_02 (same) - no need to update "11807_01_mangos_gameobject_addon"-"11885_01_mangos_spell_proc_event" (newer) - need to update 10008 (same) - no need to update There are the following UDB updates available: "402_corepatch_characters_11377_to_11792" "402_corepatch_mangos_11377_to_11792" and "402_updatepack_mangos" + "403_corepatch_mangos_11793_to_11840" and "403_updatepack_mangos" none I am under the impression that I will need to apply the (in my case) "C:\\MaNGOS\\sql\\updates\\" "11807_01_mangos_gameobject_addon"-"11885_01_mangos_spell_proc_event" first, then apply the "402_updatepack_mangos" and "403_updatepack_mangos" second. The MaNGOS updates complete successfully. The UDB 402 update pack completes with errors, but I do not know which. I know that the version listed in the table does not change, and that there are a sum of 1946 queries that did not affect any rows (but I don't know if that's normal. I've always found that MySQL wording to be odd.) I applied the 403 update pack regardless, and it completed without errors. Subsequently, I applied both ACID 3.0.9 and 3.0.9b; both also completed without errors. Should I be doing this differently? EDIT: I hadn't known how to look at table data in SQLyog when I made this post. For the curious, though there doesn't seem to be any, the errors were due to the fact that UDB 402 was already installed. I skipped the UDB 402 update pack and moved directly on to 403, then I was set. Running through some low-level quests (with playerbot) now and I'm impressed.