Langerz82

On the latest revision I could cast rank 2 in cat form and it was making a noticeable extra damage output. Can you re-confirm this is still bugged. I noticed the talents didnt take into account the extra ranks but that looks like a client sided bug.....

UPDATE `gameobject` SET `spawntimesecs`='10800' WHERE `guid`='12029';

If it's every 3 hours like the OP states.

Have you still got the error on the master latest revision?

Most of the are feedback errors.

WaypointMovementGenerator::LoadPath: Creature (Entry: 645 Guid: 79344) doesn't have waypoint path 0 <-- self explanatory.

Also checked code for handling this error and it shouldn't have crashed the server.

Spell entry 29705, effect 0 has EffectImplicitTargetA/EffectImplicitTargetB = TARGET_SCRIPT, but creature are not defined in `spell_script_target` <-- needs fixing but we need to know the target entry for it. https://vanilla-twinhead.twinstar.cz/?spell=29715

 Summoned pet (Entry: 4661) not have pet stats data in DB <-- May have occurred because your players where higher levels than 60 which should now not occur. Were you using very high level players above 60?

NULL target for ACTION_T_CAST Creature (Entry: 7115 Guid: 40628) casting spell id # <-- May be a race condition with projectiles, the target is available when casted but not on hit when the projectile lands.

That is kind of unavoidable to check that there are no objects in line of sight. In the maps we only check the Z axis, and the client does the rest in terms of line of sight.

Can you provide a bit more info? Is the item spell not working?

ref:

https://www.wowhead.com/item=21685/petrified-scarab

Implemented. Refocus Spell:

See:

Langerz82/WoWSpellRefocusImpl.patch

5% is for version 6. I say close issue.

It's an unsigned int so it cant go into negative values.

Change to:

        void SetInUse(bool state)
        {
            if (state)
                { ++m_in_use; }
            else
            {
                if (m_in_use > 0)
                    { --m_in_use; }
            }
        }

This is fixed latest revision. 

Fixed on latest revision.

Re-test on latest revision I am pretty sure this has been fixed.

Resolved?

Not Core, Is Script Issue.

It's a simple fix, apply patch:

diff --git a/src/game/WorldHandlers/SpellEffects.cpp b/src/game/WorldHandlers/SpellEffects.cpp
index 73b58bf..24f77ad 100644
--- a/src/game/WorldHandlers/SpellEffects.cpp
+++ b/src/game/WorldHandlers/SpellEffects.cpp
@@ -3937,6 +3937,12 @@ void Spell::EffectDuel(SpellEffectIndex eff_idx)
     Player* caster = (Player*)m_caster;
     Player* target = (Player*)unitTarget;
 
+	if (caster->duel)
+		caster->DuelComplete(DUEL_INTERRUPTED);
+
+	if (target->duel)
+		target->DuelComplete(DUEL_INTERRUPTED);
+
     // caster or target already have requested duel
     if (caster->duel || target->duel || !target->GetSocial() || target->GetSocial()->HasIgnore(caster->GetObjectGuid()))
         { return; }

Is this still an issue on latest revision?

Fixed on latest Revision. Please close.

This has been fixed on latest version. Please close.

Patch needs further testing.

See:

Langerz82/ChannelInterrupts.patch

edit:

This is partial fix and does not take into account when target dies (I think).

Hello,

Ok so Ive worked out the offending line of code is:

void Player::SetGameMaster(bool on)
{
    if (on)
    {
        m_ExtraFlags |= PLAYER_EXTRA_GM_ON;
        //setFaction(35); // <-- Makes selecting players disabled

Question is do we need that line?

Apparently we do: https://www.ownedcore.com/forums/world-of-warcraft/world-of-warcraft-emulator-servers/wow-emu-guides-tutorials/56782-guide-npc-factions-commands.html

OwnedCore seems to list the faction as Villian: https://www.wowhead.com/faction=35/villian

So maybe we need to edit the Faction interaction with other factions??

I'll try and work on this.

I think this issue would be more related to Movement in the core and not the DB. Am I wrong?

IMG Deadlink. Is this still an issue on latest version?

Cosmetic only, please change to low priority.

Fix.

Note - Couldnt access Spell Object in SpellAuraHolder so had to pass the Spell pointer across to it. If there is a better way please let me know.

Langerz82/ChannelRangeUpdateFix.patch