Langerz82

Please re-test as I think this bug may be fixed latest HEAD version.

On 1/25/2019 at 8:29 AM, Necrovoice said:

.2 or .04?

Thanks fixed and updated.

Implemented and tested briefly.

See:

Langerz82/GMSilence1852impl.patch

This is only cosmetic and priority should be low.

Partial Fix (Just needs the level requirements added to it):

unlocking-the-second-tier-of-t-r455.diff

Tested and Fixed. Please close.

Edit: Scrap those changes.

This should have been fixed as the baseValue gets set to 0, in ApplySpellMod which is behaviour as intended. Close.

Duplicate Bug: 

Tested and Fixed. Close.

Try this fix:

diff --git a/src/game/Object/Unit.cpp b/src/game/Object/Unit.cpp
index 08ba7cd..408960e 100644
--- a/src/game/Object/Unit.cpp
+++ b/src/game/Object/Unit.cpp
@@ -634,10 +634,11 @@ uint32 Unit::DealDamage(Unit* pVictim, uint32 damage, CleanDamage const* cleanDa
             victim->SetLootRecipient(this);
 
         if (IsControlledByPlayer()) // more narrow: IsPet(), IsGuardian() ?
-            victim->LowerPlayerDamageReq(health < damage ? health : damage);
+            victim->LowerPlayerDamageReq(victim->GetHealth() < damage ? victim->GetHealth() : damage);
+
     }
 
-    if (health <= damage)
+    if (pVictim->GetHealth() <= damage)
     {
         DEBUG_FILTER_LOG(LOG_FILTER_DAMAGE, "DealDamage %s Killed %s", GetGuidStr().c_str(), pVictim->GetGuidStr().c_str());
 

This is an outdated bug so all the debug lines are out of sync now. I can only guess what the might have been the error and here it is.

diff --git a/src/game/WorldHandlers/SpellAuras.cpp b/src/game/WorldHandlers/SpellAuras.cpp
index fb14a6f..08095b0 100644
--- a/src/game/WorldHandlers/SpellAuras.cpp
+++ b/src/game/WorldHandlers/SpellAuras.cpp
@@ -5533,6 +5533,10 @@ void SpellAuraHolder::Update(uint32 diff)
         }
     }
 
+	// DoTs-crash-the-server-r509 - Maybe Fix.
+	if (!m_target)
+		return;
+
     // Channeled aura required check distance from caster
     if (IsChanneledSpell(m_spellProto) && GetCasterGuid() != m_target->GetObjectGuid())
     {

edit: Damage is should not be the issue as it clamped here:

    if (Creature* victim = pVictim->ToCreature())
    {
        if (!victim->IsPet() && !victim->HasLootRecipient())
            victim->SetLootRecipient(this);

        if (IsControlledByPlayer()) // more narrow: IsPet(), IsGuardian() ?
            victim->LowerPlayerDamageReq(health < damage ? health : damage);
    }

Its a dot so ap_bonus should be set to 0 and ap_dot_bonus set to the desired value. 

ex:

UPDATE mangos0.spell_bonus_data SET `dot_bonus`=0, `ap_dot_bonus`=0.04 WHERE entry=26573

Hello,

Is this an old bug? Because I can see that Arcane Shot is calling the following method.

 DealDamage(pVictim, damageInfo->damage, &cleanDamage, SPELL_DIRECT_DAMAGE, GetSchoolMask(damageInfo->school), spellProto, durabilityLoss);

And the console stats its doing Arcane Damage.