michalpolko

@qsa, yes, this is also a major problem

P.S. Has anyone a good fix for stacking buffs from passive areaauras? Unleashed Rage - Abomination's Might, Windfury Totem and Imp. Icy Talons etc.? ;P

I notied this problem first time when Anub'Rekhan in Naxxramas didn't aggro when players pulled his Crypt Guards

This is interesting topic. Since I remember, overall dps on MaNGOS servers was much too high comparing to official servers.

Some tests from players found on wow community forums prove, that many (maybe all) % modifiers should be added, not multiplied by themselves.

This (probably) bug leads (example from my server) prot warriors to 1st place in arenas or battlegrounds (because this spec has A LOT of % modifiers and when they are multipied then they gain pretty big boost in damage).

I guess it would be easier to understand their purpose and easier to operate with them if they had those *_week and *_season parts added...

So, is this proof enough to review the patch by devs?

OK, I finnally got to level 5 with my priest on trial account

Here it is:

9-10 clean damage dealt = 10rage

9-10 fully absorbed damage dealt = 10rage

11 fully absorbed damage dealt = 11rage

I didn't record rage from damage taken because it is clearly written in the patch notes

This was recorded on trial 4.0.1, but on 3.3.5 it was exactly the same.

I hope this is a good proof.

Unknown also appears in situations where a unit (not only pet) is summoned with other phaseMask then player's and when that player changes it's phaseMask to the unit's phaseMask then it is unknown.

I hope You understand me

I'm leveling my priest roght now, BUT clean WotLK is gone (farewell) and it's 4.0.1 Trial, so you can't say now how it should be on 3.3.5 But I will still make this movie

In dbc they don't have this flag so: no, this doesn't fix that issue. This fixes, for example, Overpower.

bump easy to review fix..

This can currently be exploited by third party programs which can place spells on the totem bar that are not normally allowed by client. Doing so allows those spells (even passive abilities/talents) to be cast on self with Call of the Elements/Ancestors/Spirits instantly.

maybe such info should be stored on the server's side?

There was a blue post saying, that blizz is thinking about introducing rage from absorbs when dealing damage, together with rage from absorbed damage taken. But there was no official post saying that it was finally implemented.

On my server's community forum there was a long discussion about this and I was protecting the statement, that absorbs from damage dealt shouldn't be rewarded with rage. And then I came with an idea of creating 2 trial accounts and testing this with 4 lvl priest and warrior And I was always getting rage when hitting priest in a duel with full absorbs.

Maybe I will create 2 accounts again and make a movie of this test...

Then why did my warrior gain rage when hitting shielded target? 7~9 rage per fully absorbed hit and 7~9 rage per clean hit...? Tested on two 3.3.5 Trial accounts a few weeks ago.

With this fix would a spell be cast on the surface when i will be standing on a hill?

Does Overkill count as Damage Done in battlegrounds summary?

tested by players, they say it works well: http://github.com/przemratajczak/mangos/commit/baef73abc7771467c609286ae3c6a15b10833ded

About Judgements, there is still a bug, because:

Patch 3.2.0 (2009-08-04):

Some of these attacks were considered ranged and some melee. They are all now considered melee attacks that can't be dodged, parried or blocked.

All paladin judgements are now properly considered as melee attacks that cannot be dodged, blocked or parried. Previously Seal of Light, Seal of Wisdom, Seal of Justice and Seal of Righteousness would cause the judgement to be considered a ranged attack.

About the patch, I'm gonna test it as soon, as I finish my current work

updated, there was already bool isCrit calculated so we can use it.

I tested it with Living Bomb only and it works now very well. Please test it with other DoT crits if You know any.

MaNGOS Revision: 10459

What does it fix?

Some spells proc from periodic damage crits, such as Living Bomb DoT crits should proc Ignite. This fix allows choosing between NORMAL and CRITICAL_HIT PROC_EX flag.

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 92ea8a4..7b38298 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -6508,6 +6508,7 @@ void Aura::PeriodicTick()
            // Set trigger flag
            uint32 procAttacker = PROC_FLAG_ON_DO_PERIODIC; //  | PROC_FLAG_SUCCESSFUL_HARMFUL_SPELL_HIT;
            uint32 procVictim   = PROC_FLAG_ON_TAKE_PERIODIC;// | PROC_FLAG_TAKEN_HARMFUL_SPELL_HIT;
+            uint32 procEx       = isCrit ? PROC_EX_CRITICAL_HIT : PROC_EX_NORMAL_HIT;
            pdamage = (pdamage <= absorb + resist) ? 0 : (pdamage - absorb - resist);

            SpellPeriodicAuraLogInfo pInfo(this, pdamage, 0, absorb, resist, 0.0f, isCrit);
@@ -6516,7 +6517,7 @@ void Aura::PeriodicTick()
            if (pdamage)
                procVictim|=PROC_FLAG_TAKEN_ANY_DAMAGE;

-            pCaster->ProcDamageAndSpell(target, procAttacker, procVictim, PROC_EX_NORMAL_HIT, pdamage, BASE_ATTACK, spellProto);
+            pCaster->ProcDamageAndSpell(target, procAttacker, procVictim, procEx, pdamage, BASE_ATTACK, spellProto);

            pCaster->DealDamage(target, pdamage, &cleanDamage, DOT, GetSpellSchoolMask(spellProto), spellProto, true);

remember about 2 dummy effects, not 1 ;] it must have some purpose

You can do this in Spell::SetTargetMap or Spell::SpellEffects. But in both ways, You have to check the target by entry, so there's no point in solving this by custom case in SetTargetMap, I think...

http://www.wowhead.com/spell=54517 has area of effect targets type... so I think that everybody in the area are included as targets and we need to check them.

Yup, I implemented it in this and proposed by me 2 posts earlier version and it works just fine. But let's think about optimalization. What would be optimal, dummy in SD2 or handling this in core?

Are You sure that Your crashes are caused by this patch? In what situations does it crash?

And when do those players get more rage, with normal white hits? Or maybe there's some bug similiar to Execute's bug with adding 100 rage when used sometimes?

On clean official mangos core I get exactly the same ammounts of rage with normal and absorbed hits. Maybe it's non compatible with some custom patches in Your core? Could You paste the crash log?

refering to a pointer (CleanDamage const* cleanDamage) with "." operator? did You compile it? it may crash because of NULL pointer, so I'm adding ckecks right now and updating the 1st post.

Warrior gains the same ammount of rage from absorbs as from damage, which is reasonable. Did You notice higher gains of rage when absorbing then when getting/dealing normal clean hits?