Chucksta

I have no idea what would cause it to show up, but until it does, there's nothing to work with really.

They may mean absolutely nothing. Not used in the current system. Maybe I should try and figure out where they are used, but then there is plenty out there to do that is way more important. I'll wait :)

Thanks, not many left of the "Missing US text" to go. I'm not going through the "UDB Missing US text" ones yet. I'll wait till they pop up. They may have nothing to do with npc_text table, which I am aiming this at.

The Baron has been dealt with already, or should have been. I'll check.

I'll PR it tomorrow. Need a fresh head for final checks to make sure all is correct :-)

Yes, I think that would be a good idea, to use the same text.

Reading through all those comments, it does seem that there were many bugs in retail, and there's mention of no message text too.

[B][COLOR="#008000"][SIZE=3]*** Missing US Text Issue ***[/SIZE][/COLOR][/B]

[SIZE=3]Table [B]npc_text[/B][/SIZE] - the following records contain "Missing US Text" in field text0_0
record: 10059 is not linked to a creature/NPC via [B]gossip_menu [/B]table
record: 10061 is not linked to a creature/NPC via [B]gossip_menu [/B]table
[B][COLOR="#FF0000"]record:[/COLOR][/B] 17880 is linked to Sprok Away Team ([B]creature_Template[/B]: Entry 8320) via [B][COLOR="#800080"]GossipMenuId [/COLOR][/B]12741 in the [B]gossip_menu [/B]table
[B][COLOR="#FF0000"]record:[/COLOR][/B] 17838 is linked to Lorekeeper Raintotem ([B]creature_Template[/B]: Entry 3233) via [B][COLOR="#800080"]GossipMenuId [/COLOR][/B]12707 in the [B]gossip_menu [/B]table
[B][COLOR="#FF0000"]record:[/COLOR][/B] 17805: is linked to Kibler ([B]creature_Template[/B]: Entry 10260) via [B][COLOR="#800080"]GossipMenuId [/COLOR][/B]12663 in the [B]gossip_menu [/B]table
[B][COLOR="#FF0000"]record:[/COLOR][/B] 16528: is linked to Terl Arakor ([B]creature_Template[/B]: Entry 2153) via [B][COLOR="#800080"]GossipMenuId[/COLOR][/B] 11788 in the [B]gossip_menu [/B]table
record: 16336: this has a [B]gossip_menu[/B] entry, but does not exist in the GossipMenuId field of any [B]creature_template [/B]record
[B][COLOR="#FF0000"]record:[/COLOR][/B] 16432: is linked to Griniblix the Spectator ([B]creature_Template[/B]: Entry 14395) via [B][COLOR="#800080"]GossipMenuId[/COLOR][/B] 11738 in the [B]gossip_menu [/B]table
[B][COLOR="#FF0000"]record:[/COLOR][/B] 16334: is linked to Commander Aggro'gosh ([B]creature_Template[/B]: Entry 2464) via [B][COLOR="#800080"]GossipMenuId[/COLOR][/B] 11673 in the [B]gossip_menu[/B] table
[B][COLOR="#FF0000"]record:[/COLOR][/B] 16335 is linked to Far Seer Mok'thardin ([B]creature_Template[/B]: Entry 2465) via [B][COLOR="#800080"]GossipMenuId[/COLOR][/B] 11674 in the [B]gossip_menu [/B]table
record: 15719: (Shandris Feathermoon - Entry 3936) is showing a proper message in game, even though the npc_text record this links to says Missing US Text. Ah ha, it's using the text in the next field: text0_1. I'll leave this one alone.
record: 14625: (Baron Longshore - Entry 3467) this too is showing a proper message in game.
[B][COLOR="#FF0000"]record:[/COLOR][/B] 2368: is linked to Jangdor Swiftstrider ([B]creature_Template[/B]: Entry 7854) via [B][COLOR="#800080"]GossipMenuId[/COLOR][/B] 1964 in the [B]gossip_menu [/B]table
record: 5935 (Ravenholdt Guard) has a proper message in game (many NPCs).
record: 5940 (Ravenholdt Assassin) has a proper message in game (many NPCs).
record: 7775 this has a [B]gossip_menu[/B] entry, but does not exist in the GossipMenuId field of any [B]creature_template [/B]record
record: 8656 this too has a [B]gossip_menu[/B] entry, but does not exist in the GossipMenuId field of any [B]creature_template [/B]record

[B]note:[/B] Baron Revilgaz has also been added to the list. I need to locate the npc_text ID for him too, just-in-case we locate a better text for him to use.

I'll probably put this in a table format of some sort.

[B][COLOR="#008000"]FIXES[/COLOR][/B]

[B]Sprok[/B] - Gnomeregan (Entry 8320)
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='12741' WHERE `Entry`='8320';
UPDATE npc_text SET `text0_0`='Greetings $N' WHERE `ID`='17880'; [/COLOR]
[B]Note:[/B] probably not the correct text for the NPC

[B]Lorekeeper Raintotem[/B] - Mulgore (Entry 3233)
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='12707 ' WHERE `Entry`='3233';
UPDATE npc_text SET `text0_0`='Only the most valiant and honorable amongst the tribe can earn the honor of being laid to rest at Red Rocks.' WHERE `ID`='17838';[/COLOR]

[B]Kibler[/B] - Burning Steppes (Entry 10260)
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='12663' WHERE `Entry`='10260';
UPDATE npc_text SET `text0_0`='What!' WHERE `ID`='17805 '; [/COLOR]

[B]Terl Arakor[/B] - Wetlands (Entry 2153)
[url]http://www.wowhead.com/npc=2153/terl-arakor[/url]
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='11788' WHERE `Entry`='2153';
UPDATE npc_text SET `text0_0`='This is MY WAGON!$B$BMINE!' WHERE `ID`='16528';[/COLOR]
[B]Note:[/B] All text has now been found. See a few posts down - many images of the text used by this NPC

Judging by the comments in the linked page, this NPC also responds to the
"Wetlands is under attack!" message
and says: WHERE IN WETLANDS? Maybe next time you could just warn me "Azeroth is under attack, somewhere!"

[B]Griniblix the Spectator[/B] - Dire Maul - Feralas (Entry 14395)
[url]http://www.wowhead.com/npc=14395#comments[/url]
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='11738' WHERE `Entry`='14395';
UPDATE npc_text SET `text0_0`='Woohoo! They are into it now!' WHERE `ID`='16432'; [/COLOR]
[B]Note:[/B] This NPC says different things dependent on which boss is spawned!
"Can that be the Razza down there in the Maul? This is going to be exciting!"

[B]Commander Aggro'gosh[/B] - Grom'Gol - STV (Entry 2464)
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='11673' WHERE `Entry`='2464';
UPDATE npc_text SET `text0_0`='Welcome to Grom\'gol, $C. Before we get off on the wrong foot, I\'ll have you know that I won\'t have slackers in my Base Camp.. I expect a healthy $R like you to pull your own weight around here.' WHERE `ID`='16334'; [/COLOR]

[B]Far Seer Mok'thardin[/B] - Grom'Gol - STV (Entry 2465)
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='11674' WHERE `Entry`='2465';
UPDATE npc_text SET `text0_0`='Even in this remote corner of the world, know that Hellscream\'s eyes are upon you.' WHERE `ID`='16335';[/COLOR]

[B]Jangdor Swiftstrider[/B] - Camp Mojache - Feralas (Entry 7854)
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='1964' WHERE `Entry`='7854';
UPDATE npc_text SET `text0_0`='Welcome to Camp Mojache, brave $C. How may I assist you this day?' WHERE `ID`='2368';[/COLOR]

[B]Baron Revilgaz[/B] - Booty Bay (Entry 2496)
[COLOR="#0000FF"]UPDATE creature_template SET `GossipMenuId`='6685' WHERE `Entry`='2496';
UPDATE npc_text SET `text0_0`='Welcome to Booty Bay, partner. I hope your stay in my town is enjoyable and uneventful - emphasis on the latter. We\'ve got plenty of drink if you\'re thirsty, and plenty of bouncers if you\'re antsy.$B$BNow then... what can this humble servant of the Steamwheedle Cartel do for you? Better still - what can you do for me, eh?' WHERE `ID`='7965'; [/COLOR]
-- Deleted as we only need a link to the 7965 record in the npc_text table
[COLOR="#0000FF"]DELETE FROM gossip_menu WHERE `entry`='6685' and`text_id`='13062';[/COLOR]

[B]NOTE:[/B] using USA English spelling, so as to stay true to Blizzard

Quick look and it appears that this is all there is, judging by the comments here: [url]http://db.vanillagaming.org/?quest=1531#wh-comments[/url]

I've not looks at the other quest you linked, but this Call To Air can be picked up in TB and Org, so that may explain the other quest:
[url]http://www.wowwiki.com/Quest:Call_of_Air[/url]

I could not see any other text, handing in point/quest completion or whatever. No doubt another one (text) lost to the void.

We could make one up, perhaps?
e.g...

[B][COLOR="#0000FF"]"Arn't you a clever cookie! Have a gift for your troubles"[/COLOR][/B]

[B][COLOR="#0000FF"]'Ere you go 'andsom[/COLOR][/B]

Okay, I cannot figure out how to get to the area these mobs are in!!! Teleporting does not help as it looks like the area needs to be instantiated before that will work, otherwise you are just teleported into a void. [B]Note[/B]: you have to teleport to one of the other creatures in the area, as the minion has no [B]creature [/B]table record.

If anyone reads this, and are a able to, can they test to see if changing the creature's Faction to 73 fixes this?
You need to set to 73, fields: [B]FactionAlliance[/B], [B]FactionHorde [/B]in the [B]creature_template [/B]table of the Doomguard Minion's record: Entry 14385

This fixes the issue (tested in-game):

UPDATE npc_text SET `text0_0`='Greetings $N' WHERE `ID`='8406';

UPDATE creature_template SET `GossipMenuId`='0' WHERE `Entry`='2497';

Having to set the GossipMenuId to 0 seems odd to me, unless I am misunderstanding how this works.
[B][COLOR="#B22222"]GossipMenuId changed from 16667 to 0.[/COLOR][/B]

This is another NPC/creature who very likely says more than a simple greeting, but I have been unable to locate what it does say.

[B]EDIT:[/B] Before I PR this, I am going to go through each of the records in the npc_text table that contain "Missing US Text"; trace them back to the creature/NPC and fix all that I can locate the correct text for. I'll add the information to this thread for every record I successfully deal with.

Blimey, another one!!!

Going to be testing my proposed fixes on both MS windows and Linux (Ubuntu) builds from now on; just as I did when I started out here.

Let's see if I can make this my first fix of the day. Oops, jinxed myself now!

This NPC is linked to the [B]npc_text [/B]table record: [B][COLOR="#0000FF"]8406[/COLOR][/B], which shows this message: "Missing US Text"

Quick look and they do not have the correct Faction. That should be set to 73: demon. They currently have 90.

[url]http://db.vanillagaming.org/?npc=14385[/url]
On that page, if you hover over the Faction Demon, over on the right side, you'll see that links to a page with Faction=73 in the URL.

Not sure if that is causing the problem, but I'll try it out tomorrow.

This has already been fixed, PR'd and merged with the core DB.

[B][SIZE=3][COLOR="#800080"]This issue can be considered resolved[/COLOR][/SIZE][/B]

[COLOR="#0000CD"][B]Just as a note:[/B][/COLOR]

The Unforgiven will also be added to: One (TBC), Two (WoTLK), and Three (CATA). I have no idea if this elite still exists in MoP.

I have just created a Pull Request for One.

Next: install WOTLK and getmangos Two server/DB, so that I can add this elite and its adds

Oops, sorry. Geez, I'm making a lot of mistakes lately!

Okay, I lied, or going senile.

When attempting to loot it comes up with:
“[COLOR="#B22222"][B]Another action is in progress[/B][/COLOR]”

After applying the salve the corrupted plants are not despawning! Both corrupted and cleansed occupy the same space.

[B]EDIT:[/B] I reckon I have figured out how to get the Corrupted version of the plant to despawn (not reported issue, I know)

It will require a second entry in the [B]dbscripts_on_quest_end [/B]table. In there it already has one entry which spawns the Cleansed plant, but we also need an entry that despawns the Corrupted plant. Of course, I will test this to be sure.

The Corrupted Whipper Root is linked to the dbscripts_on_quest_end table through the quest: Corrupted Whipper Root, thus:

[B]gameobject_template[/B] (entry 173284) [B][COLOR="#008000"]→[/COLOR][/B] [B]gameobject_involvedrelation[/B] (id 173284) [B][COLOR="#008000"]→[/COLOR][/B] [B]quest_template [/B](4443) [B][COLOR="#008000"]→[/COLOR][/B] [B]dbscripts_on_quest_end[/B]

The table [B]dbscripts_on_quest_end[/B] can have many record entries for a quest.

In the [B]dbscripts_on_quest_end[/B] table, the field: command, is used to say what will happen: summon object/creature, despawn self, etc (many things can be done). The following 2 fields are used to specify the GUID of the object to be spawned, and the time it should stay in the game world till it despawns (feilds: datalong, datalong2).

Hopefully with all this research I'll also figure out for why the looting problem occurs.

Okay, now to test this!

NUTS! The despawning is only for creatures!

[B]EDIT again:[/B] Very strange, when interacting with the Cleansed Whipper Root it says in the mangos terminal: [B][COLOR="#0000FF"]Goober ScriptStart ID 4118 on Entry 164883 GUID 48881[/COLOR][/B]

The Entry and GUID is that plant, so where is this ID 4118.
If it's the one from [B]dbscripts_on_quest_end[/B], then that is very, very strange, because that's for the Corrupted Songflower plant and quest!!!

Cabfever said it's ok now, after his SQL script fix was merged :)

Right, this WILL fix it:

[B][SIZE=3]DATABASE[/SIZE][/B]
UPDATE `creature_item_template` SET `inventory_type`='18' WHERE `class`='11' AND `subclass`='2';

UPDATE `item_template` SET `InventoryType`='18' WHERE `class`='11' AND `subclass`='2';

[B][SIZE=3]SERVER[/SIZE][/B]

Remove the following line

[COLOR="#B22222"][B]case INVTYPE_QUIVER:[/B][/COLOR]

from Player.cpp, line 7712

Yep, I got that code part totally wrong! Misinterpreted the meaning in the database, which led to the supposed code fix!!!!

I'll PR a fix for the fix that was not a fix :o

I'll have at this and other issues first thing tomorrow. Need to wind down now, or sleep won't happen.

I'll also liaise with the others on this and the other issues you posted today, cabfever.

[B][COLOR="#B22222"][SIZE=3]NOTE:[/SIZE][/COLOR][/B] It's got to be due to the quiver being in the bag slot. Yesterday after applying the fix, logging in and successfully equipping the quiver in the bag slot, I then did not log off and log back in, therefore I did not experience the crash.
Right, after this is fixed, I'm firing myself!

Geez, we must have a Gremlin infestation!!! I tested that and it worked fine, nightmare! :(

Just adding this image of the crash:

[IMG]http://s22.postimg.org/65hrdbne9/Login_Crash_With_Hunter.jpg[/IMG]

That looks like it's crashing when checking to see what items are in the bag and making sure they can go in the bag. This is occurring as the player character goes into the game world.

And again, very strange, because I was able to do that yesterday!!!! :(

Nasty! Okay, and damn, I should've tested equipping and firing an arrow.

EDIT: Just went in, and it killed the server entering as a hunter. This did not happen yesterday. I went in fine as my hunter; just did not use the quiver other than to equip it.

Interesting, I tried creating a new hunter and that crashed on entering the game world. I was not expecting that, because I had no issue with this after applying the fix myself.

Hmm... so what's different since yesterday for me???

May have to revert back to the original set up, even though they were incorrect in the database.

Your one has been merged with the database (4 hours ago):
[url]https://github.com/mangoszero/database/commits/Rel20[/url]

I have no idea about anything else. Antz will need to look at this, but he's not around at the moment.

I left a message re this on the group chat on Skype. I'll also send one directly to Antz in Skype.

"Values in the database: MinMeleeDamage 1636 MaxMeleeDamage 2165"

Where did you get those values from?

In the [B]creature_template[/B] table, the values for 12259 (Gehennas) are:
MinMeleeDamage: 168
MaxMeleeDamage: 234

I checked an older copy of the database and that had exactly the same values.

Looking on the page you linked it says the damage is:
"Damage: 14,700 - 17,010 (Physical)"

So, me confused :confused:

[B]Just checking the other stats:[/B]
Armour is correct: 4635
Health is correct: 351780

[B]EDIT:[/B] I just checked the stats and database record of Kel'Thuzad in Naxxramas and they are pretty much correct/the same, so it does look like the Molten Core ones are way wrong.

The question now is, what values do go into those fields ?

There is a [B]DamageMultiplier [/B]field in the creature_template table; for Gehennas this is 35, and for Kel'Thuzad it is 1. I am guessing that this should be taken into consideration when we decide on the values to go into the fields: MinMeleeDamage and MaxMeleeDamage

[SIZE=3][B][COLOR="#008000"]The fix has now been merged with the server core[/COLOR][/B][/SIZE] :)

A Pull Request has now been made with this fix :)

Ah fiddle stick and Alistair!

Okay, yep, that commit did cause the issue. In fact 2 things caused that issue

1) That commit
2) Me not testing it!!!

That commit was necessary due to errors on start up of the server. Those errors were found to be caused by invalid entries in the creature_item_template and item_template tables.

The field in those records that can be used to identify if an item is equipable, is the inventory_type field. Quivers were set as Bag (18), but should be Quiver (27).
see the following in the Wiki:
[url]https://www.getmangos.eu/wiki/Reference%20Information/DB/mangos/MaNGOSZero/creature_item_template.md[/url]

[B]EDIT[/B]: True fault found in the server core. It is not considering the Quiver as an equipable item that can go in a bag slot. In fact it is not considering the Quiver at all.
Faulty code is at:
Player.cpp
function: FindEquipSlot( )
Line: 7619

Pre code fix
case INVTYPE_BAG:
slots[0] = INVENTORY_SLOT_BAG_START + 0;
slots[1] = INVENTORY_SLOT_BAG_START + 1;
slots[2] = INVENTORY_SLOT_BAG_START + 2;
slots[3] = INVENTORY_SLOT_BAG_START + 3;
break;

Code fix applied:
case INVTYPE_BAG:
case INVTYPE_QUIVER:
slots[0] = INVENTORY_SLOT_BAG_START + 0;
slots[1] = INVENTORY_SLOT_BAG_START + 1;
slots[2] = INVENTORY_SLOT_BAG_START + 2;
slots[3] = INVENTORY_SLOT_BAG_START + 3;
break;

This time I tested it, and it worked as it should!

I'll now PR the fix!

Thinking about it, AMMO POUCH should probably go in there too.
EDIT: It's ok, AMMO POUCH is classed as QUIVER in the DBC files

Thanks, Xenithar :)

Will need to look at that one again, though. That field I placed a 0 in should hold the ID number that will lead to the npc_text record that the original script added the Greetings $N to.

Something is not working as it should, it seems.

It is working (seemingly), so good, but I'll be back!