cyrex

[FIX] Fix 1 small typo when compiling with gcc What bug does the patch fix? What features does the patch add? A small typo For which repository revision was the patch created? 9681 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No see any Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/CombatHandler.cpp b/src/game/CombatHandler.cpp index ab821bf..a284355 100644 --- a/src/game/CombatHandler.cpp +++ b/src/game/CombatHandler.cpp @@ -36,7 +36,7 @@ void WorldSession::HandleAttackSwingOpcode( WorldPacket & recv_data ) if(!pEnemy) { if(!guid.IsUnit()) - sLog.outError("WORLD: %u isn't player, pet or creature", guid.GetString().c_str()); + sLog.outError("WORLD: %s isn't player, pet or creature", guid.GetString().c_str()); else sLog.outError( "WORLD: Enemy %s not found", guid.GetString().c_str()); Link - http://neogm.com/tools/mangos/Compile.patch

Ok For the second part i found out that the attribute warn_unused_result is a common problem for gcc. gcc 4.5 fixes tis issue but since i have ubuntu 9.10 am still using the 4.4 branch. So this will be solve when 10.04 comes out. For the first part i need to wait for gcc 4.5 to find out about something since it looks it is also something not fixed yet.

Tested paladin and works good.

Updated to latest. Added a couple of more git apply patches.

Am working on finishing it for a git apply version. Give me an hour to test and ill post it. For the crashes and related stuff that just is outside of my grasp...for now. EDIT: Here is the git apply version. Compiled correctly. http://www.neogm.com/tools/mangos/Vehicles.patch

I find that using patch -d when git apply does not work somewhat of a workaround instead of solving the problem. Thanks anyway but i had to go manually on this patch until i made the git apply version of it.

I want to remove all this compile bugs before posting on that section. Also fix the scriptdev2 bugs when compiling so it looks more clean. They are not that important as others but look clean when compiling.

Not working with Linux Ubuntu. Am using git apply which is the standard i use for all patches. All work except this one.

When compiling latest Mangos on Ubuntu i get several warnings. I leave here one of the fixes while i learn how to fix the rest: diff --git a/src/game/CombatHandler.cpp b/src/game/CombatHandler.cpp index ab821bf..a284355 100644 --- a/src/game/CombatHandler.cpp +++ b/src/game/CombatHandler.cpp @@ -36,7 +36,7 @@ void WorldSession::HandleAttackSwingOpcode( WorldPacket & recv_data ) if(!pEnemy) { if(!guid.IsUnit()) - sLog.outError("WORLD: %u isn't player, pet or creature", guid.GetString().c_str()); + sLog.outError("WORLD: %s isn't player, pet or creature", guid.GetString().c_str()); else sLog.outError( "WORLD: Enemy %s not found", guid.GetString().c_str()); The rest of the warnings are divided into 2 groups. The functions which are this 3: /bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I../../../../dep/ACE_wrappers -I.. -DACE_BUILD_DLL -W -Wall -Wpointer-arith -g -O2 -pthread -pipe -O3 -MT libACE_la-LSOCK.lo -MD -MP -MF .deps/libACE_la-LSOCK.Tpo -c -o libACE_la-LSOCK.lo `test -f 'LSOCK.cpp' || echo '../../../../dep/ACE_wrappers/ace/'`LSOCK.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I../../../../dep/ACE_wrappers -I.. -DACE_BUILD_DLL -W -Wall -Wpointer-arith -g -O2 -pthread -pipe -O3 -MT libACE_la-LSOCK.lo -MD -MP -MF .deps/libACE_la-LSOCK.Tpo -c ../../../../dep/ACE_wrappers/ace/LSOCK.cpp -fPIC -DPIC -o .libs/libACE_la-LSOCK.o ../../../../dep/ACE_wrappers/ace/LSOCK.cpp: In member function ‘ssize_t ACE_LSOCK::send_handle(ACE_HANDLE) const’: ../../../../dep/ACE_wrappers/ace/LSOCK.cpp:62: warning: dereferencing type-punned pointer will break strict-aliasing rules ../../../../dep/ACE_wrappers/ace/LSOCK.cpp: In member function ‘ssize_t ACE_LSOCK::recv_handle(ACE_HANDLE&, char*, ssize_t*) const’: ../../../../dep/ACE_wrappers/ace/LSOCK.cpp:126: warning: dereferencing type-punned pointer will break strict-aliasing rules mv -f .deps/libACE_la-LSOCK.Tpo .deps/libACE_la-LSOCK.Plo /bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I../../../../dep/ACE_wrappers -I.. -DACE_BUILD_DLL -W -Wall -Wpointer-arith -g -O2 -pthread -pipe -O3 -MT libACE_la-LSOCK_Stream.lo -MD -MP -MF .deps/libACE_la-LSOCK_Stream.Tpo -c -o libACE_la-LSOCK_Stream.lo `test -f 'LSOCK_Stream.cpp' || echo '../../../../dep/ACE_wrappers/ace/'`LSOCK_Stream.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I../../../../dep/ACE_wrappers -I.. -DACE_BUILD_DLL -W -Wall -Wpointer-arith -g -O2 -pthread -pipe -O3 -MT libACE_la-LSOCK_Stream.lo -MD -MP -MF .deps/libACE_la-LSOCK_Stream.Tpo -c ../../../../dep/ACE_wrappers/ace/LSOCK_Stream.cpp -fPIC -DPIC -o .libs/libACE_la-LSOCK_Stream.o ../../../../dep/ACE_wrappers/ace/LSOCK_Stream.cpp: In member function ‘ssize_t ACE_LSOCK_Stream::send_msg(const iovec*, size_t, ACE_HANDLE)’: ../../../../dep/ACE_wrappers/ace/LSOCK_Stream.cpp:87: warning: dereferencing type-punned pointer will break strict-aliasing rules ../../../../dep/ACE_wrappers/ace/LSOCK_Stream.cpp: In member function ‘ssize_t ACE_LSOCK_Stream::recv_msg(iovec*, size_t, ACE_HANDLE&)’: ../../../../dep/ACE_wrappers/ace/LSOCK_Stream.cpp:123: warning: dereferencing type-punned pointer will break strict-aliasing rules mv -f .deps/libACE_la-LSOCK_Stream.Tpo .deps/libACE_la-LSOCK_Stream.Plo /bin/bash ../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H -I../../../../dep/ACE_wrappers -I.. -DACE_BUILD_DLL -W -Wall -Wpointer-arith -g -O2 -pthread -pipe -O3 -MT libACE_la-POSIX_Proactor.lo -MD -MP -MF .deps/libACE_la-POSIX_Proactor.Tpo -c -o libACE_la-POSIX_Proactor.lo `test -f 'POSIX_Proactor.cpp' || echo '../../../../dep/ACE_wrappers/ace/'`POSIX_Proactor.cpp libtool: compile: g++ -DHAVE_CONFIG_H -I../../../../dep/ACE_wrappers -I.. -DACE_BUILD_DLL -W -Wall -Wpointer-arith -g -O2 -pthread -pipe -O3 -MT libACE_la-POSIX_Proactor.lo -MD -MP -MF .deps/libACE_la-POSIX_Proactor.Tpo -c ../../../../dep/ACE_wrappers/ace/POSIX_Proactor.cpp -fPIC -DPIC -o .libs/libACE_la-POSIX_Proactor.o ../../../../dep/ACE_wrappers/ace/POSIX_Proactor.cpp: In member function ‘virtual int ACE_POSIX_AIOCB_Proactor::get_result_status(ACE_POSIX_Asynch_Result*, int&, size_t&)’: ../../../../dep/ACE_wrappers/ace/POSIX_Proactor.cpp:1242: warning: null argument where non-null required (argument 1) ../../../../dep/ACE_wrappers/ace/POSIX_Proactor.cpp:1246: warning: null argument where non-null required (argument 1) ../../../../dep/ACE_wrappers/ace/POSIX_Proactor.cpp: In member function ‘virtual int ACE_POSIX_AIOCB_Proactor::start_aio_i(ACE_POSIX_Asynch_Result*)’: ../../../../dep/ACE_wrappers/ace/POSIX_Proactor.cpp:1433: warning: null argument where non-null required (argument 1) ../../../../dep/ACE_wrappers/ace/POSIX_Proactor.cpp:1437: warning: null argument where non-null required (argument 1) mv -f .deps/libACE_la-POSIX_Proactor.Tpo .deps/libACE_la-POSIX_Proactor.Plo And the warn_unused_result: CXX genrevision.o ../../../../src/tools/genrevision/genrevision.cpp: In function ‘void extractDataFromSvn(FILE*, bool, RawData&)’: ../../../../src/tools/genrevision/genrevision.cpp:41: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:42: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:43: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:44: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:45: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:46: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:47: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:48: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:49: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result ../../../../src/tools/genrevision/genrevision.cpp:50: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result CXXLD genrevision CXX dotconfpp.o ../../../../src/shared/Config/dotconfpp/dotconfpp.cpp: In member function ‘int DOTCONFDocument::setContent(const char*)’: ../../../../src/shared/Config/dotconfpp/dotconfpp.cpp:425: warning: ignoring return value of ‘char* fgets(char*, int, FILE*)’, declared with attribute warn_unused_result CXX mempool.o CXX ModelContainer.o ../../../../src/shared/vmap/ModelContainer.cpp: In member function ‘bool VMAP::ModelContainer::readFile(const char*)’: ../../../../src/shared/vmap/ModelContainer.cpp:258: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result CXX SubModel.o CXX VMapManager.o ../../../../src/shared/vmap/VMapManager.cpp: In member function ‘bool VMAP::VMapManager::_existsMap(const std::string&, unsigned int, int, int, bool)’: ../../../../src/shared/vmap/VMapManager.cpp:294: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result AR libmangosvmaps.a CXX DBCStores.o ../../../src/game/DBCStores.cpp: In function ‘bool ReadDBCBuildFileText(const std::string&, const char*, std::string&)’: ../../../src/game/DBCStores.cpp:191: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result CXX debugcmds.o CXX Map.o ../../../src/game/Map.cpp: In static member function ‘static bool Map::ExistMap(uint32, int, int)’: ../../../src/game/Map.cpp:85: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp: In member function ‘bool GridMap::loadData(char*)’: ../../../src/game/Map.cpp:1131: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp: In member function ‘bool GridMap::loadAreaData(FILE*, uint32, uint32)’: ../../../src/game/Map.cpp:1184: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1192: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp: In member function ‘bool GridMap::loadHeightData(FILE*, uint32, uint32)’: ../../../src/game/Map.cpp:1201: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1212: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1213: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1221: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1222: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1230: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1231: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp: In member function ‘bool GridMap::loadLiquidData(FILE*, uint32, uint32)’: ../../../src/game/Map.cpp:1244: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1258: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result ../../../src/game/Map.cpp:1263: warning: ignoring return value of ‘size_t fread(void*, size_t, size_t, FILE*)’, declared with attribute warn_unused_result CXX MapInstanced.o

Going to test also. Give me about 4 to 5 hours.

Actually that does not work. it does not apply perfectly.

Do i need to compile this patch and others related like Warbringer and Juggernaut, or is this all of them together.

Compiled perfectly on Ubuntu.

Getting the following error on Ubuntu fatal: git apply: bad git-diff - expected /dev/null on line 4 Even though the line 4 IS dev/null Did a fresh compile and same problem.

I forgot to add. Official used something very similar. I say this because of the following: One time i had a problem with a player of offi who was very rude to me. I told some offensive words back to the player and called for a GM to intervene. When i called the GM and told him about my situation he/she said that i too had said some offensive words back which were and he wrote the same words i had said to the other player. So they DO have a similar system that logs everything a player says in EVERY chat including whisper since at that time both, the player and me offended each other via whisper messages. So with this i like to say that this type or enhancement does exist on official server.

BeFree you are on a roll. Thank you.

Awesome! nice one

Confirmed. Patch works perfect on linux and compile finished correctly. Now what should i test or could test with a population between 20 and 30 players?

One last question here. How much LESS memory will this help mangos use up. I have a 1GB Server and i have to literally kill mangos every 24 hours so it does not crash later.

On Ubuntu: ./patches/Terrain.patch:3558: trailing whitespace. After removing the trailing it started compiling fine but then: CXX AccountMgr.o In file included from ../../../src/game/Map.h:36, from ../../../src/game/BattleGround.h:24, from ../../../src/game/Group.h:24, from ../../../src/game/Player.h:30, from ../../../src/game/ObjectAccessor.h:32, from ../../../src/game/AccountMgr.cpp:21: ../../../src/game/TerrainMgr.h:39: error: use of enum ‘ZLiquidStatus’ without previous declaration ../../../src/game/TerrainMgr.h:79: error: ‘ZLiquidStatus’ does not name a type In file included from ../../../src/game/Map.h:36, from ../../../src/game/BattleGround.h:24, from ../../../src/game/Group.h:24, from ../../../src/game/Player.h:30, from ../../../src/game/ObjectAccessor.h:32, from ../../../src/game/AccountMgr.cpp:21: ../../../src/game/TerrainMgr.h:143: error: ‘ZLiquidStatus’ does not name a type In file included from ../../../src/game/BattleGround.h:24, from ../../../src/game/Group.h:24, from ../../../src/game/Player.h:30, from ../../../src/game/ObjectAccessor.h:32, from ../../../src/game/AccountMgr.cpp:21: ../../../src/game/Map.h: In member function ‘ZLiquidStatus Map::GetLiquidStatus(float, float, float, uint8, LiquidData*)’: ../../../src/game/Map.h:418: error: ‘struct TerrainData’ has no member named ‘GetLiquidStatus’ make[2]: *** [AccountMgr.o] Error 1 using Core 9637 + SD2

What Ceris is saying which is true is that you should only get the debuff ONLY when entering Dalaran, not exiting. when entering you get the debuff to dismount but when you are leaving you should not get anything.

Thank the lord!

Thanks Betaman2k. Was wondering how was this doing since it affects several spells at once.

Updated git patches to include freezing arrow and shadow dance. Tested again on 9613. Works perfect. If you by any chance get ANY error whatsoever then check the way you are compiling and what you are missing since this patches were already tested on 2 systems.

@Balacas - Please tell me the Core version you are using and if any other modifications you are adding. I will post here my compilation script anyway which i use to test of 2 PCs.