Darkruler

My commits are the same as Salja's (used the same source, Traponinet and Tasssadar) so the only difference is that i use Insider42's commits :confused: hope someone can test Insider42's GIT without vehicle patch, can't imagine the vehicles can f*** up DK start zone

Which repo, mine or Salja's?

Working on it!

Updated my Insider42 git

somewhere around line 661 of PetHandler.cpp try changing - //recvPacket >> targets.ReadForCaster(pet); + recvPacket >> targets.ReadForCaster(pet); i will update my Insider42 repo for you

Salja's repo has more features and is updated more frequently... off-topic: i don't have much time to update it because: i'm working on an application that downloads source from a github repo, automatically compiles it and filters all compile errors and puts those in seperate logs (one for SD2, one for the core) and it can also use SVN to receive a database and import it

BUMP, is this proper for implementation in the master branch?

no you didn't not tested this, but atleast it compiles Aura *aur = GetAura(71905, EFFECT_INDEX_0); + if (aur && uint32(aur->GetStackAmount()) == 1) + CastSpell(this, 72521, false); // First Effect + + if (aur && uint32(aur->GetStackAmount()) == 6) + { + RemoveAurasDueToSpell(72521); // remove First Effect + CastSpell(this, 72523, false); // Second Effect + } if (aur && uint32(aur->GetStackAmount() + 1) >= aur->GetSpellProto()->StackAmount) { + RemoveAurasDueToSpell(72523); // remove Second Effect RemoveAurasDueToSpell(71905); // remove Shards CastSpell(this, 71904, true); // Chaos Bane return true; } This is the first time i write something for a spell, before this i've only made custom configs for various stuff, so i would appreciate it if someone more experienced can respond on this

Sorry, just woke up so this might be completely bullshit, but seems to me this should work (or atleast partially) // Item - Shadowmourne Legendary case 71903: { if (!roll_chance_i(triggerAmount)) return false; Aura *aur = GetAura(71905, EFFECT_INDEX_0); -------------------------------------------------------------------------- if(GetStackAmount()== 1) caster->AddAura(72521, caster); if(GetStackAmount() == 6) { caster->RemoveAura(72521); caster->CastSpell(caster, 72523, false); } -------------------------------------------------------------------------- if (aur && uint32(aur->GetStackAmount() + 1) >= aur->GetSpellProto()->StackAmount) { caster->RemoveAura(72523); RemoveAurasDueToSpell(71905); CastSpell(this, 71904, true); // Chaos Bane return true; } added part is between -------------------------------------------------------------------------- don't try to use it, i know it's wrong but i need some caffeine before fixing it

read the notes by Vlad [9715]

I don't want to be rude... but can anyone translate above post to normal english i don't really get it i will answer the part i do understand: - Dual-spec is officially included in MaNGOS as of Rev [9715] - Vehicles aren't yet as the developers would like to see them.. so it needs some more attention (i don't have time to develop it further though...that's up to Traponinet and Wojta...and ofcourse the other collaborators on the patch)

might be because of my git config try git checkout-m origin/Insider42

git clone git://github.com/Darkrulerz/mangos.git git checkout -m Insider42 you can't select a branch in a clone

going to do a forced push to get the credits straight ~~solved~~

Clean MaNGOS with vehicle patch : http://github.com/Darkrulerz/mangos/commits/master Insider42's repo with vehicle patch : http://github.com/Darkrulerz/mangos/commits/Insider42 if it doesn't compile or anything, don't hesitate to send me a PM on github

working on it... will make github branches based on insiders repo and one on plain mangos with vehicles and keep track of comming updates Will post a link tomorrow

mmh ok.. if someone gives me an updated file (with previous fixes posted here)..i will maintain a GIT and put all posted updates in it

Solving merge conflicts and compile errors is easy...afterwards i pull the additional things for vehicles that somehow aren't in the vehicle branch from the master branch (target types and not use pet AI for example)

git pull git://github.com/Tasssadar/Valhalla-Project.git vehicle and apply the 2 patches posted earlier... no need for a patch file

lol, perhaps you can make pics for him?

Tasssadar's repo... check the 2nd commit from the top.. that's what tester20 is talking about

Fixed in 9724

I meant being free to mount up while inside Dalaran (everywhere)

can't be because of his patch.... he removed 2 checks...nothing added...

make it so that when this patch is turned off (disabled), Dalaran is a zone where you can freely fly (so disabling results in the exact opposite)