Skirnir

If this is correct it should be in under review, and you could use [ code = diff ] tags: diff --git a/src/game/Player.cpp b/src/game/Player.cpp index d16196b..f579213 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -13930,15 +13930,21 @@ void Player::RewardQuest(Quest const *pQuest, uint32 reward, Object* questGiver, QuestStatusData& q_status = mQuestStatus[quest_id]; // Not give XP in case already completed once repeatable quest - uint32 XP = q_status.m_rewarded ? 0 : uint32(pQuest->XPValue(this)*sWorld.getConfig(CONFIG_FLOAT_RATE_XP_QUEST)); + uint32 xp = 0; + if ( !q_status.m_rewarded ) + { + if (getLevel() < sWorld.getConfig(CONFIG_UINT32_MAX_PLAYER_LEVEL)) + { + xp = uint32(pQuest->XPValue(this)*sWorld.getConfig(CONFIG_FLOAT_RATE_XP_QUEST)); + GiveXP( xp, NULL); + } + else + { + uint32 money = uint32(pQuest->GetRewMoneyMaxLevel() * sWorld.getConfig(CONFIG_FLOAT_RATE_DROP_MONEY)); + ModifyMoney( money ); + GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_MONEY_FROM_QUEST_REWARD, money); + } - if (getLevel() < sWorld.getConfig(CONFIG_UINT32_MAX_PLAYER_LEVEL)) - GiveXP(XP , NULL); - else - { - uint32 money = uint32(pQuest->GetRewMoneyMaxLevel() * sWorld.getConfig(CONFIG_FLOAT_RATE_DROP_MONEY)); - ModifyMoney( money ); - GetAchievementMgr().UpdateAchievementCriteria(ACHIEVEMENT_CRITERIA_TYPE_MONEY_FROM_QUEST_REWARD, money); } // Give player extra money if GetRewOrReqMoney > 0 and get ReqMoney if negative @@ -13993,7 +13999,7 @@ void Player::RewardQuest(Quest const *pQuest, uint32 reward, Object* questGiver, q_status.uState = QUEST_CHANGED; if (announce) - SendQuestReward(pQuest, XP, questGiver); + SendQuestReward(pQuest, xp, questGiver); bool handled = false; Regards Skirnir

MaNGOS can't find ACE 5.8.3. There should be a lib 'libACE-5.8.3.so' in /usr/lib/ (check it via "ls /usr/lib/libACE-*"). You have build mangos with -DACE_USE_EXTERNAL=1 on a computer where libace 5.8.3 was installed and moved your binary to a different computer or updated or removed the ace 5.8.3 installation. Install ace 5.8.3 again or build mangos with your new ace version again or build mangos with internal ace. There would be a fourth option, symlinking to another ace version, but since ace is somewhat special w/o any nonsense, why start testing how it reacts on nonsense. Regards Skirnir PS: /usr/lib/libACE-* must have ACE in capitals and sudo isn't required. Just for verification: ls /usr/lib/libACE-*.so /usr/lib/libACE-6.0.1.so

Just for curiosity can you finish your quest with .quest complete? If not, could you move the quest item into another bag when handing in the quest (I once had a messed up bag)? Guess it's database related and no core problem. Regards Skirnir

For 2. You misplaced "then": "if foo; then bar; fi" and don't run MaNGOS as root. In my folder there is a restarter called "run-mangosd" ... Regards Skirnir

@MasterControlProgram: Doesn't matter eh? We archers already have it in AUR since the first opensource announce (though it needs /usr/lib64): [1] @UnkleNuke: You wont be beta tester for their final product. It was announced that ekopath will be opensource at github (pathscale already has a reop with some stuff). They'll make enough money with Enzo and paid support. Anyways, you currently can't build MaNGOS with ekopath and I highly doubt that our devs will try to support another 64bit compiler. Just have a look how often gcc compile breaks. Even if MaNGOS core would build there are some nasty third party libraries (Intel TreadBuildingBlocks and ACE) that wont build. Regards Skirnir [1] https://aur.archlinux.org/packages.php?ID=49808&comments=all

Yes it's supposed to be up to date. All yes you are correct, udb character updates failed, because your character file already was the latest. This happens because: There is a certain db entry updated with every updated version of the database. MaNGOS core reads this field, if it matches what the core expects your good, else you'll see a error message.Lets say the field entry at start is X. Now the core gets some updates. You build a new core, but now the expected database version is X+1. Until you apply this update the core prints something like: you have database version X. required is X+1 Updates use this logic as well. They are written to check if there is a required version, before they apply. In the given example: You have version X. You apply updatepack X+1, which updates entry X to X+1. The core starts and reads the database version which is X+1 and your good to go. What could happen is you start with version X and try to apply X+2 before you run update X+1, in this case your mysql console prints an error. In your case you already had X+200 and tried to apply X+5, this could have erased the entry field. Just drop the database and reimport the linked sql file. For a fresh start you run create_mysql.sql, realmd.sql and characters.sql. Ofc you edit create_mysql.sql to your needs! After that you import the latest sql dump of your database provider and run mangos updates till the next database provider updatepack revision. You do that until you have applied all updatepacks and after that you apply all MaNGOS updates till the revision of your core. This update procedure can take some time ;-) After that, modify your mangos conf files (maybe import scriptdev2 and acid) and your done. I've once written a script for myself which creates a file with the correct order to create a fresh world db, you might find the output useful [1]. I did update it to the latest, but no one cared and it's not that beautiful written. I don't know about what your talking. I'm not offended, I didn't write the articles. I just feel like they cover most of the relevant aspects, have a look at the linux guides, maybe they are better than the windows guides. Also I'm quite often member of the silent (and dying) mangos user irc channel, for questions join us and ask.Regards Skirnir PS: Wall of text and I'm supposed to finish my diploma thesis -.- [1] https://gist.github.com/747461

In case you refer to this file: [1] After running this you shouldn't need to apply other updates. Updates for character database are required if you like to convert an existing database. If you apply the above linked file your server is ready for account creation. On a side note, all required information how to setup and update a database are in the wiki [2] Regards Skirnir [1] https://github.com/mangos/mangos/blob/master/sql/characters.sql [2] http://getmangos.eu/wiki/

The code tag is semi broken You can use it, but the output ignores any newlines you placed. Text \\\\ Another Line\\\\ Final Line the correct output as quote: Just like quote code should show three lines. Regards Skirnir

maybe I was a bit to optimistic, needs some more love I did some more testing. I was fooled due to running make CC=clang CCX=clang++ after cmake creation. Currently compilation does not work. For more information have a look at: http://getmangos.eu/wiki/Compile_MaNGOS_with_Clang original post Sometimes you wake up and do things you didn't plan to do. Something like this happened today. I was doing some MaNGOS stuff, updating my scripts, compiling a new core, etc. when I thought hm the Linux Kernel can be compiled with Clang, what about MaNGOS+SD2? Installed Clang, replaced "make" with "clang" and waited. Compiling works, what about running? Running works (login and walking around, later we'll see about the rest) Regards Skirnir PS: I used this "cmake" command, so I didn't build ACE and Intel TBB. cmake ../ -DPREFIX=/opt/clangmangos -DPCH=1 -DACE_USE_EXTERNAL=1 -DDEBUG=1 -DTBB_USE_EXTERNAL=1 PPS: On archlinux x86_64 with mangos master [11629] clang -v clang version 2.9 (tags/RELEASE_29/final) Target: x86_64-unknown-linux-gnu Thread model: posix Information: Clang on wikipedia: http://en.wikipedia.org/wiki/Clang Clangs website: http://clang.llvm.org/

@Princess: Well there is a bit of water between the american and the european continent. Noting MaNGOS can do about it. Regards Skirnir

I'd push the 'Say "Thank You"' button *yay* Regards Skirnir

Bump Stumbled over this yesterday. Anyone had a look, or a comment? Anything? If you like to have some live action look at www.archlinux.org www.xfce.org Regards Skirnir

I'm not "cab", but there you go: http://getmangos.eu/wiki/Compile_MaNGOS_On_Ubuntu#World_Database Regards Skirnir

Yes

SilverIce is working on it's implementation (and some other awesome things) at: https://github.com/SilverIce/mangos Dynamic vmaps are in branch dynamic_vmaps (Cpt. Obvious at your service). I've compiled it and did some basic running around, but sadly nothing deeper. Just don't have enough time to play. Regards Skirnir

Sorry to interrupt, but which part of Windows is based on (a part of) Unix? Did Microsoft change something with Windows 7 I missed? Regards Skirnir

... which was impossible with the Chinese client last autumn according to our forum posts. Chinese client is somewhere at Burning Crusade (because of skeletons and other offensive stuff). To enjoy the MaNGOS experience others have, you have to use the EnUS/EnGB Client. Regards Skirnir

Still don't know who or which site you mean, anyways antiroot who seems to be the new ahbot master created his repo just two postings befor your rant against anonymous. His repo is up to the latest mangos revision [11386] at the time I'm typing. You could just clone his repo and build it. Regards Skirnir

Who the hell your talking to? Use github and create your own patch files. Yours Skirnir

@lillecarl if I got it right Neo2003 implemented a way to run a warden instance with mangos. It should work like original warden does and I doubt he will change that. Other than that google will tell you how to fake a mac address, it's just as effective as ip bans. Other than that I still don't know why your friends cheat on your non public servers. Regards Skirnir

@Sky1: The sql file is no longer required. Just make sure that your server uses cyberiums patch (1) and that you have the required ahbot.conf file. After starting the server will boost the auctionhouse with items. Regards Skirnir 1: I dont know if there's currently a working ahbot patch, I enjoy my spring time away from WoW

Change this to the correct value and your fine. On GNU/Linux I do it like this: Copy all data files into a folder 'data' next to mangos bin directory. Now you have a folder /opt/mangos with /opt/mangos/bin, /opt/mangos/etc and /opt/mangos/data. Change mangosd.conf to "DataDir = "../data" On Windows things should be the same just that you have different path names like C:\\Mangos\\ with C:\\Mangos\\data etc. Regards Skirnir

@mrelfire: Try using a clean core. I have [11241]+SD2 1990, ahbot, mmaps and playerbot (branch flight) and can't reproduce freezing after clicking the calendar button (don't use that special addon). Regards Skirnir

@Nocommentte: Send a PM to rsa. He's around at this forum and at some others and frequently checks github comments. My guess is you mixed something up, it's highly unlikely that you have a different scripting library. rsa uses a patched ScriptDev2 if I remember correctly. In this case your still mysterious patch file just tells you that your sources are already patched. Anyways ask rsa. In case you don't use a clean core your on your own. Regards Skirnir

@Nocommentte: You should tell us a bit more. Which "mangos" (maybe one or zero, or trunk?) you want to compile and which file you are going to patch. Other than that, have a look at the patch file and at src/bindings/CMakeLists.txt. Your patch somehow does not match this files information. Hard to tell why w/o having a look at the patch and the file. Have a look at how to manually patch sources and you'll be able to easily fix it. Guess you just have to add "add_subdirectory(ScriptDev2)". Regards Skirnir