Skirnir

I'd like to reply to UnkelNuke and X-Savior (and the always asking vladex ;-) ), as I feel I'm one of the more active members in this thread. I'm using Ahbot since Naicisum has started his work with it. I read his opening post "how to handle the ahbot repository" and since then I'm merging and updating my local branch. I'm doing so at least once a day. I've shipped round some of the more dangerous cliffs (I remember the day mangos reverted the "minimal load" function). Basicaly I had my branch running all the time and I would be able to compile ahbot on a daily basis. I have no public repo because I can't assure that I can have it updated for the far or near future. My C++ knowledge is quite poor (and it doesn't look like this is gonna change in the near future), if I see something and it works I'm happy, but if it doesn't work ... well I can not "develop" it. And that's what Ahbot imho needs, someone that actually can develop it. Someone who can improve the code, someone who can really update it at every stage. I could only provide a daily merged mangos master branch. This is the "most" important reason why I think I should not do it. Another one is, I'm a guy who knows how hard you have to fight for your free time and I can perfectly understand if Naicisum needs his day/week/month off. In Europe the universitys are still in examination phase and if he's trough with that he might have his holidays. Since I respect him as person and his work as developer, I'd feel rather uneasy to push a sloppy branch, I couldn't even maintain properly. I don't want to take his credit or push him out of business. If you X-Savior want an up to date ahbot patch, I'll be more than pleased to help you out with that. Hence how much fun do I have with mangos due to your work with ACID. Just tell me for which revision you want a patch file and I'll do my very best to deliver it as fast as possible. Regards Skirnir

Hello everyone, I was about to type this post about 2 weeks ago, that time github showed ~800 forks. Right now it shows 900 forks. 900 forks of MaNGOS of which close to 99% are more or less useless, guys forking MaNGOS just to have ScriptDev2 integrated, forks that stopped about a week after MaNGOS initial creation etc. pp. You might think "who the hell cares?" Well I do. Github makes MaNGOS able to use their infrastructure. The give away their traffic, their webspace etc. for free (they didn't even shout at MaNGOS during the DDoS attacks some month ago). All they want is to support opensource software (well and for sure sell some of their bigger git repos ...). Now what can be spotted? Somewhere inside the inner deeps of the internet, a noobish mangos guide exists, showing every user how to setup a github account and how to push a fork and not only shows them, it tells them to do so [1]. This is not just completely useless - as shown above, how many forks actually are of any use - it's even more. It's abuse of an open access resource [2]. 900 forks, well calculate yourself 900 * xxMB. This doesn't just kill the cool feature of the network graph, it even overuses the good will of the free github service. Iirc 100MB are for free, with all MaNGOS forks out there, not all are clearly declared as MaNGOS forks, we're easily way above that limit. I don't know if MaNGOS team (or the one that owns the github repository) can delete some long abandoned forks or whatsoever. All I see is, within the 1. third of 2010 we will have a network of more than 1000 forks integrating ScriptDev2, ahbot, vehicles branch and others. We need about 10 or 12 forks (with those patches), that are maintained frequently, updated etc. 900 right now are about 890 to much. I just had to post this else I'd feel bad maybe think about it and delete some of your not used forks Regards & thanks for reading Skirnir [1] Just like the guides that tell you to do a complete clone every time you compile [2] In economics you call it tragedy of the commons

check where the errors appear: here: patching file src/game/AuctionHouseMgr.cpp Hunk #1 FAILED at 463. 1 out of 1 hunk FAILED -- saving rejects to file src/game/AuctionHouseMgr.cpp.rej and here: patching file src/game/Mail.cpp Hunk #2 FAILED at 901. 1 out of 2 hunks FAILED -- saving rejects to file src/game/Mail.cpp.rej have a look at the patch file in a text editor. open the two files in a text editor and merge the patch manually. maybe in the files some lines were added/removed and now "patch" isn't able to patch correctly. hard to say w/o having a look at the files. also it's quite difficult to tell someone, w/o any knowledge and w/o the will to have a look on his own, how to do things properly. I've seen in another thread, that you already patched your sources. Maybe that explains your patch errors, who knows. You have to try it on your own until someone popps out and tries to patch the same sources and hands over a solution. Skirnir

@belfedia and maxmax27: most of the things you need is shown at the fist post of this thread. git clone git://github.com/Naicisum/mangos.git ahbot cd ahbot git checkout origin/ahbot git checkout -b ahbot do this to get ahbot for Naicisums ahbot branch. Now find here: http://github.com/Naicisum/mangos/commits/ahbot the commit id. after that "git checkout git_commit_id" in ahbot branch. After that switch to master branch (git checktout master) checkout the needed commit id http://github.com/Naicisum/mangos/commits/master and create the patch git diff master ahbot > auctionhousebot.patch @wowquebec: it works, compiled 9439 and no problems

@Kugel for your 9310 Ahbot: What you need is my updated 9310 ahbot.patch file you get it here: http://gist.github.com/310405 (i've had two game.vcproj messed up, that's why you need the updated file). Now I show you the commands needed to get 9310 mangos with ahbot: If your on GNU/Linux you should be able to copy paste the lines, for windows I don't know. First cd to a dir of your choice, then pull mangos. If you already have done that, switch to your mangos directory. With git checkout e8... we get mangos rev9310. Git checkout -b ahbot creates our AuctionhouseBot branch, and lets us swith to it. Now we are at rev9310. NOW you copy the downloaded ahbot9310.patch file in your mangos dir. With git apply ahbot9310.patch mangos sources are patched. With git add * we add every file inside our branch to our upcoming commit. With git commit -a (for all) -m (message) "ahbot for 9310" we commit the files to our ahbot branch. Now you can compile mangos the way your used to do. Maybe you first apply the scriptdev2 patch if your on linux, just do it like your used to do. If your tired of 9310 and want to see whats master branch is doing just: $ git checkout master to switch back to the master branch. With git pull, you get the latest updates. cd mangos git checkout e8af832ac20f75de313f39b8f9f7d3724299c311 git checkout -b ahbot git apply ahbot9310.patch git add * git commit -a -m "ahbot.patch" @shaan: you basicaly do the same: create a new branch. patch the source with "git apply ahbot.patch" or "patch -p1 < ahbot.patch", "git add *" to apply all files to your commit and "git commit -a -m "message"" commit your stuff. If you have any further questions about git feel free to send me a personal board message, as this isn't related to this thread. Hope that helps Good luck Skirnir

Derex is a gnu/linux dude, maybe you could ask if it compiles under win ;-) kind regards & thanks derex (again for all you did and do) Skirnir

@Shaan: Try this ahbot.diff: http://gist.github.com/311334 I just created it out of my branch, haven't tested it as I'm right now compiling. (If your patch is successful I advise you to create a branch and update/merge it manually. Thats no big deal and even people that have barly no clue of C++, like me, can do it.) @kugel did you succeed? If you create a new branch with the patched files, the corruption message should go away. If not you have to ask everyones good friend google. Good luck Skirnir

@kugel and UnkleNuke You could try this one: http://gist.github.com/310405 I checked out Naicisums ahbot0.15 patch and merged up to 9310. Only merge probs were with VCx0/game.vcproj, but I hopefully fixed these (can't test, as I don't use windows). I haven't (and won't do so) tested the patch myself, but I'm quite positiv it will compile. If you spot some compile errors connected to ahbot, post them and I'll have a look. And I don't think Vladimir reads in this thread that often, if you have a message for him you better post it someplace else ;-) Be calm with Naicisum, he's a busy man. Regards Skirnir

Mangos Version: 8398 Custom Patches: AuctionHouseBot SD2 Version: 1573 Database Name and Version : YTDB 534, UDB 387 (both checked) How it SHOULD work: Player one should be able to close the loot window, w/o affecting player twos loot window How it DOES work: Player one closing the loot window this action closes player twos loot window as well A small bug that seems to be there since the 3.x switch. Two players of a group kill an npc, now they both open the loot window. Player one checks the loot, doesn't care and closes the loot window by pressing the close button. Now the window closes for both of them. Player twos loot window seems to be connected with player ones.

Mangos Version: 8398 Custom Patches: AuctionHouseBot SD2 Version: 1573 Database Name and Version : YTDB 534, UDB 387 (both checked) How it SHOULD work: 2 persons should be able to complete the same quest one after another How it DOES work: Only the fist person can complete a quest I'm having this problem now for a bunch of revisions I don't know where exactly it started. What happens: Two players do a quest (e.g. quest 8287). You have to fetch an item, both players grab it and move to the npc where they should complete the quest. Player one speaks to the npc and can complete the quest like intended. Player two speaks to the npc, but can't complete the quest. The npc simply ignores that player two has the quest item. You can't click the "complete" button. I can't even complete the quest by ".quest remove 8287" and ".quest add 8287" or ".quest complete 8287" whatever I do, the npc still ignores player two. As said, I've spotted this problem about one or two weeks ago. Sometimes npcs accept quests sometimes not, like completely random. I've checked both databases and I'm quite clueless. Have I forgotten to apply a update sql file or has anyone else spotted this behavior? Regards Skirnir EDIT THIS CAN BE CLOSED AS ITS A FALSE POSITIVE!

http://gist.github.com/304653 A small fix for mangos rev.9389

Just a little cleanup, mangos is at release 0.16-dev1 so I added 0.14, 0.15 and 0.16 folder with sql files by revision (hopefully everything is correct) and cleaned up Makefile.am http://paste2.org/p/655593 My SQLyog runnig under wine was becoming slower and slower due to 250 files in one folder kind regards Skirnir.

I just remembered this thread, has anyone ever tried using readlin/ncurses beside raczman? Regards Skirnir

@X-Savior: Well, there is an alternative. On page1 of this topic was shown how to create a patch file out of the auctionhouse git branch. I made this about the time I spotted this topic. Next I applied it to my local mangos git branch. After that I created a new branch called "ahbot". Now everytime I build mangos, I first check out mangos git repo, with git pull next I switch to my branch git checkout ahbot and merge git merge origin/master . After that I build mangos. And after building I switch back git checkout master . Whenever "git merge" returns errors, I see if my poor C++ understanding helps me, else I see if the problem was discussed here, or if theres a new "hotfix" at Nacs. repo. So at least on linux this variant has proven it's usability. Regards Skirnir

@The_Game_Master updated link was already posted hth Skir.

just as quick note. works with 8727

Have a look for yourself AHBot-005-Alpha-00 Naicisium was as busy as a bee

Hi, merged 8596 with my local ahbot brach from old 3.1 days. After manual merge fix, everything runs flawless. On Debian Lenny x64. PS: Naicisum I'm still waiting to test ahbot-dev branch ...

Yes I think thats right. Until a countrys court system validates a license (e.g. the GPL) it's just some written text. And about that part of the GPL, your completely right: If you sell it, you have to say your using GPL code. I mistakenly was referring about this part: to myself delivering the source code would be 'indicating' "that their software is licensed under the GPL". From my point of view I interpreted you meant "saying so explicitly on their web page" and I just don't think that's required. I this case "prominent notices" could mean anything, from a layer on the web page, a pop-up at program start up to a README file inside the binary folder. I'm sorry for misinterpretation.Regards Skirnir

Hm I'm not sure. If you for instance buy RedHat Linux afaik you receive a serial, code to use the version of the OS on one PC, just like any Windows OS, but still Red Hat delivers a lot of GPL copyrighted software. I haven't ever cared in how Red Hat does so, but I think there is somehow a way. A way which could also be used by the Chinese. Yes definitely. But just one little hint, even worlds famous software giant Microsoft has sold Windows Vista dvds in Germany with a big button saying: You cannot sell this dvd again (which is against German law. Everything you can legally buy in Germany can be legally sold in Germany). Surly MS tried to circumvent reselling via ebay, but what I tried to explain is: even if the Chinese are in conflict with GPL in this case, it's not that big deal to judge them for. MS wasn't stopped by selling those dvds and the Chinese won't be stopped either. Even IF they violate GPL you'll first have to make sure that China accepts the GPL as license and have to make sure that there are no Chinese laws securing them. Which can only be proved by actually buying the software. You'll only have to deliver the parts of the original source code and a copy of the GPL to those that actually bought the software. And saying that you use parts of GPL software is afaik nice, but not necessary. Regards Skirnir

Selling GPL OpenSourceSoftware is not illegal. GPL and not even the FreeSoftwareFoundation prevent this: Read more. Of course you have to behave by the rules of GPL, providing source code etc. So beside the fact that they are breaking the "mangos users honor codex" not to sell the code and mangos EULA they can't be judged for selling. First you have to buy the Software to see if they share the part of the source code which is under GPL. Hosting a public server of course is a violation against heavy snowstorms EULA and maybe some laws (which needs to be checked for the Chinese case). And since EULAs are no laws and in such way rather weak, you'll have to get a Chinese lawyer ... quite an expensive plan with a unsure ending. my thoughts Skir.

Hm, what about this patch? Pastbin run out. But otherwise no complains so far. Seems like it's rdy!

@imblizzspy: In my opinion the opening post wasn't demanding anything, it was just a post of a person that worrys about someone else, which is in my opinion a very human action. And if someone worrys about you here, it's maybe the biggest honor one can recive Regards Skirnir PS: btw I have asked myself the very same question a while ago ...

Ok, in this case I was wrong. I just felt that posting a question, and after that changing the subject, just to say "haha dumb-ass" was kinda lame. But I got it wrong and I learned something new about gitk. Sorry and thanks Skirnir

Wyk3d You obvious changed the repos address to a (for me not working) different git repo. My reply was posted to the first working repo, which imho wouldn't do just "gitk and search 3xxx". It might be just me, but I feel that's (Your "deep searching" is just[...]) somehow unfair If mrlocus wants rev 3xxx he has now atleast one working way. Skirnir