pelle

thanks for the answer and for the patch too

sorry for question, but this is for multirealms only right?

you know, could be a very spamming waty to do this.... i suggest, let them join a channel. the .announce command is a _gm_ command, and probably for a reason...?

nice for the patch, but bump for this bcz is so important!

right sorry .

this should improve performances of the ahbot patch... right?

so you are thinking to autojoin them at login?

you should set in conf 0 to merged chats, and to create with the gm the channel. the channel should be avaiable from horde and ally but not merged... probably, not tested

ok thanks. so this patch is better than derex' one?

ok four questions: -will this work on 0.12? -how much this can improve performance? -what bad effects _could_ have? -why whe should include this ? thanks for patience

sorry for the noob question, but this is only for trinity or for mangos too?

for what branch this will work? for 0.12 too?

sorry but, what this patch will improve? i think 0.12 stealth system is quite good...?

Hi, i'd like to know how the spells are organized on mangos. So where are wrote the effects of every spell? and the proc? and how dbc are used? Only for desciption or more? Thank you .

I'm Trying to fix this talent ( http://www.wowhead.com/?spell=14195 ). It should add another combo point if an ability that add it have a crit chance. I tested it and it _don't_ work. it work only for a gounge's damage crit. so, if it partially work, won't be so hard to add other spells to the crit check so, searching in the mangos code, i found this: // Hemorrhage if (m_spellInfo->SpellFamilyName==SPELLFAMILY_ROGUE && (m_spellInfo->SpellFamilyFlags & UI64LIT(0x2000000))) { if(m_caster->GetTypeId()==TYPEID_PLAYER) ((Player*)m_caster)->AddComboPoints(unitTarget, 1); } so, this is the part of the code that add a combo point to the hemo spell. now, shouldn't be so hard to add a check of the talent and a check to the crit right? on unit.cpp i found: MeleeHitOutcome Unit::RollMeleeOutcomeAgainst (const Unit *pVictim, WeaponAttackType attType, int32 crit_chance, int32 miss_chance, int32 dodge_chance, int32 parry_chance, int32 block_chance, bool SpellCasted ) const this is the declaration a a function that check the crit or dodge/miss of a certain spell. the funcition return an anumerator, for us will be return MELEE_HIT_CRIT, so should be // Hemorrhage if (m_spellInfo->SpellFamilyName==SPELLFAMILY_ROGUE && (m_spellInfo->SpellFamilyFlags & UI64LIT(0x2000000))) { if(m_caster->GetTypeId()==TYPEID_PLAYER) ((Player*)m_caster)->AddComboPoints(unitTarget, 1); talent_check(); // ? //outcome = RollPhysicalOutcomeAgainst (pVictim, attType, spellCasted); //if crit if(outcome == MELEE_HIT_CRIT) ((Player*)m_caster)->AddComboPoints(unitTarget, 1); } now, this function is declared in unit.cpp and not on the included unit.h, so, how i can add this code o spelleffect.cpp? and how i check the talent learning?

assasination rogues need some love....

*epic up* come on ç_ç

Mangos is a learning prodjet, a "funny way" to play wow with your friend, to lean c++, mysql and php/html if you do a website too.

yes, i fixed that line and i haven't too. probably my repo hadn't _that_ commit.... :confused:

i don't know, i downloaded the 8067 and i got this error. so i looked into the commits to see if were applied and found that this commit ( http://github.com/mangos/mangos/commit/b78d15978fcaaf421e95b871bf56b8e816bfed83 ) wasn't. (don't know if my error or git error) now i applied it manually... working.

mmm no one interested :rolleyes: if i do a thing like this: switch(spell_id_casted_by_rogue){ case kidney_shot_id: { palyer->proc_talent;} break; case rupture_id: { player->proc_talent;} break; } will this work? and where should i put it? (variables name aren't correct because i don't know what are used)

i'm not so sure if it will work... you use master branch or what?

probably uncomment the map check for flying mounts, but i think it's not a so great idea.

ti posso suggerire di andare su quel file a quella riga e dare un'occhiata se ci sono errori stupidi, se è una funzione che non serve commentala :rolleyes: uso un website praticamente uguale a quello blizz4rd... che va benissimo se ti interessa piemmami

but... how can (if we can) take the 0.13 milestone?