Devastate doesn't apply sunder armor

Heres a hack fix

// Devastate
            if (m_spellInfo->SpellVisual == 671 && m_spellInfo->SpellIconID == 1508)
            {
                customBonusDamagePercentMod = true;
                bonusDamagePercentMod = 0.0f;               // only applied if auras found

                // Sunder Armor
                Aura* sunder = unitTarget->GetAura(SPELL_AURA_MOD_RESISTANCE, SPELLFAMILY_WARRIOR, UI64LIT(0x0000000000004000), m_caster->GetObjectGuid());

                // Devastate bonus and sunder armor refresh, additional threat
                if (sunder)
                {
                    sunder->GetHolder()->RefreshHolder();

                    // 100% * stack
                    bonusDamagePercentMod += 1.0f * sunder->GetStackAmount();

                    // 25 * stack
                    unitTarget->AddThreat(m_caster, 25.0f * sunder->GetStackAmount(), false, GetSpellSchoolMask(m_spellInfo), m_spellInfo);

                  // Cast sunder armor

                  m_caster->CastSpell(unitTarget, 11597, true);
                }
                else
                    m_caster->CastSpell(unitTarget, 11597, true);
            }
            break;
        }

Can confirm, I have this same problem.

This is the only way to implement the mechanic without spell_linked_spell DB table. However it is wrong in details, and additional info is needed.

Warrior's Devastate has 3 ranks, Sunder Armor - 6 ranks (looks like that 5 legitimate ones only, the 6th is for TBC). The proposed code casts Sunder Armor 5 irrespectively of Devastate rank. So,

• will it be correct to use the highest Sunder Armor known to the character?
• how the underranking situation must be handled, i.e. when a character knowing all 3 Devastate ranks and 5 S.A. ranks, uses Devastate 1?

Devastate has 3 ranks and use 3 ranks of Sunder Armor

• Devastate(Rank 1) - use Sunder Armor(Rank 4)
• Devastate(Rank 2) - use Sunder Armor(Rank 5)
• Devastate(Rank 3) - use Sunder Armor(Rank 6)

I fix this problem with MyDbcEditor Download

1.  
2.  
3.  
4. Go to ID of Devastate : Rank 1 - 20243 , Rank 2 - 30016 , Rank 3 - 30022
5. Change values
6. Save and start server

Now Devastate gives Sunder Armor GJ !

Thank you for the valuable info on spell linking.

However the fix proposed is unacceptable. An obvious reason is sharing issue. If you do need to modify Spell.dbc visible within the server, use SpellMgr::ModDBCSpellAttributes(). This is not the case, the spell_linked table must have the desired effect and deserves to be filled finally.

I wonder what blizz have meant omitting Effect1. I suspect the link between the spells may be more complex, but the presented info gives us a good start.

This is a DB-based implementation. I was confused about the spell_linked table (whch core does contain it and which one does not), so I had to port it from Zero.

Hi , I try your update and dont work correctly. I found problem with applying Sunder Armor . When I use Devastate on NPC and I have under 30 rage dont apply Sunder Armor ,and said "Not enough rage" ,but if I use Devastate over 30 rage apply Sunder Armor.

Devastate cost 15 rage and Sunder Armor 15 rage (15+15=30)

I try all ranks of Devastate.

I have this core commit.

Yes, I have it checked, not good. WIP.

Good job ! 

Console Error : 

Loading Spell Linked definitions...
ERROR:Spell 30016 listed in `spell_linked` is not first rank (20243) in chain
ERROR:Spell 30022 listed in `spell_linked` is not first rank (20243) in chain

I'm aware of that. You could try to remove the two spell assotiations reported here, from the table, and check all the 3 ranks.

Otherwise, you can ignore it safely.