Jump to content
  • Devastate doesn't apply sunder armor

    • Status: Completed
      Main Category: Core / Mangos Daemon
      Sub-Category: Spell
      Version: 22.1 Milestone: 24 Priority: High
      Implemented Version: 22.1
      Assigned: Olion

    User Feedback

    Recommended Comments

    // Devastate
                if (m_spellInfo->SpellVisual == 671 && m_spellInfo->SpellIconID == 1508)
                    customBonusDamagePercentMod = true;
                    bonusDamagePercentMod = 0.0f;               // only applied if auras found

                    // Sunder Armor
                    Aura* sunder = unitTarget->GetAura(SPELL_AURA_MOD_RESISTANCE, SPELLFAMILY_WARRIOR, UI64LIT(0x0000000000004000), m_caster->GetObjectGuid());

                    // Devastate bonus and sunder armor refresh, additional threat
                    if (sunder)

                        // 100% * stack
                        bonusDamagePercentMod += 1.0f * sunder->GetStackAmount();

                        // 25 * stack
                        unitTarget->AddThreat(m_caster, 25.0f * sunder->GetStackAmount(), false, GetSpellSchoolMask(m_spellInfo), m_spellInfo);

                      // Cast sunder armor

                      m_caster->CastSpell(unitTarget, 11597, true);
                        m_caster->CastSpell(unitTarget, 11597, true);

    Edited by JPlady42
    Link to comment
    Share on other sites

    This is the only way to implement the mechanic without spell_linked_spell DB table. However it is wrong in details, and additional info is needed.

    Warrior's Devastate has 3 ranks, Sunder Armor - 6 ranks (looks like that 5 legitimate ones only, the 6th is for TBC). The proposed code casts Sunder Armor 5 irrespectively of Devastate rank. So,

    • will it be correct to use the highest Sunder Armor known to the character?
    • how the underranking situation must be handled, i.e. when a character knowing all 3 Devastate ranks and 5 S.A. ranks, uses Devastate 1?
    Link to comment
    Share on other sites

    Devastate has 3 ranks and use 3 ranks of Sunder Armor

    • Devastate(Rank 1) - use Sunder Armor(Rank 4)
    • Devastate(Rank 2) - use Sunder Armor(Rank 5)
    • Devastate(Rank 3) - use Sunder Armor(Rank 6)

    I fix this problem with MyDbcEditor Download

    1.  1.thumb.png.ad4320b9da994e4b5ad23f6c60aeaa0b.png
    2.  2.thumb.png.d7a1a6ce85d0f751377e0cc638185e4b.png
    3.  3.thumb.png.5c39e9c15c7b7d6e40c5617e1373fcb0.png
    4. Go to ID of Devastate : Rank 1 - 20243 , Rank 2 - 30016 , Rank 3 - 300224.thumb.png.aa0b647bbf1ffbd45d283ff4193d3638.png
    5. Change values5.thumb.png.9aefafb942f7d51851f50bdf1905f1ec.png
    6. Save and start server6.thumb.png.5f2f9acfbc1023f94612ec916253c130.png

    Now Devastate gives Sunder Armor GJ ! :D

    Link to comment
    Share on other sites

    Thank you for the valuable info on spell linking.

    However the fix proposed is unacceptable. An obvious reason is sharing issue. If you do need to modify Spell.dbc visible within the server, use SpellMgr::ModDBCSpellAttributes(). This is not the case, the spell_linked table must have the desired effect and deserves to be filled finally.

    I wonder what blizz have meant omitting Effect1. I suspect the link between the spells may be more complex, but the presented info gives us a good start.

    Link to comment
    Share on other sites

    Hi , I try your update and dont work correctly. I found problem with applying Sunder Armor . When I use Devastate on NPC and I have under 30 rage dont apply Sunder Armor ,and said "Not enough rage" ,but if I use Devastate over 30 rage apply Sunder Armor.

    Devastate cost 15 rage and Sunder Armor 15 rage (15+15=30)

    I try all ranks of Devastate.



    Link to comment
    Share on other sites

    Console Error : 

    Loading Spell Linked definitions...
    ERROR:Spell 30016 listed in `spell_linked` is not first rank (20243) in chain
    ERROR:Spell 30022 listed in `spell_linked` is not first rank (20243) in chain

    Link to comment
    Share on other sites

    Create an account or sign in to comment

    You need to be a member in order to leave a comment

    Create an account

    Sign up for a new account in our community. It's easy!

    Register a new account

    Sign in

    Already have an account? Sign in here.

    Sign In Now

  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use