CreatureEventAI Action Type Needs Syncing with Zero and One

[B][SIZE=3]Server side changes[/SIZE][/B]

[B]CreatureEventAI.h[/B] from line 127
[PHP] ACTION_T_SET_STAND_STATE = 47, // StandState, unused, unused
ACTION_T_CHANGE_MOVEMENT = 48, // MovementType, WanderDistance, unused
ACTION_T_SUMMON_UNIQUE = 49, // CreatureId, Target, SpawnId
ACTION_T_EMOTE_TARGET = 50, // EmoteId, TargetGuid[/PHP]


other changes/additions to make:

[B][COLOR="#800080"]ACTION_T_EMOTE_TARGET[/COLOR][/B]

[B]CreatureEventAI.h[/B] new code (for Two): from line 426 approximately
[PHP]
struct
{
uint32 creatureId;
uint32 target;
uint32 spawnId;
} summon_unique;
// ACTION_T_EMOTE_TARGET = 50[/PHP]


[B]CreatureEventAI.cpp[/B] new code (for Two): in function ProcessAction( )
[PHP]
case ACTION_T_EMOTE_TARGET:
{
Unit* pCreature = m_creature->GetMap()->GetCreature(ObjectGuid(HIGHGUID_UNIT, action.emoteTarget.targetGuid));
if (!pCreature)
{
sLog.outErrorEventAI("Event %d. Cannot find creature by guid %d", EventId, action.emoteTarget.targetGuid);
return;
}


m_creature->SetFacingToObject(pCreature);
m_creature->HandleEmote(action.emoteTarget.emoteId);
break;
}[/PHP]


[B][COLOR="#800080"]ACTION_T_SUMMON_UNIQUE[/COLOR][/B]

CreatureEventAIMgr.cpp - function CheckUnusedAISummons()
[PHP]
switch (action.type)
{
case ACTION_T_SUMMON_ID:
case ACTION_T_SUMMON_UNIQUE:
{
if (action.summon_id.spawnId)
{ idx_set.erase(action.summon_id.spawnId); }
break;
}
default: break;
}[/PHP]

CreatureEventAIMgr.cpp - function LoadCreatureEventAI_Scripts()
[PHP]

case ACTION_T_SUMMON_UNIQUE: //47
if (!sCreatureStorage.LookupEntry(action.summon_unique.creatureId))
{ sLog.outErrorEventAI("Event %u Action %u uses nonexistent creature entry %u.", i, j + 1, action.summon_unique.creatureId); }
IsValidTargetType(temp.event_type, action.type, action.summon_unique.target, i, j + 1);
if (m_CreatureEventAI_Summon_Map.find(action.summon_unique.spawnId) == m_CreatureEventAI_Summon_Map.end())
{ sLog.outErrorEventAI("Event %u Action %u summons missing CreatureEventAI_Summon %u", i, j + 1, action.summon_unique.spawnId); }
break;[/PHP]

---------------------------------------------

[B][SIZE=3]Database side changes[/SIZE][/B]

[B]creature_ai_scripts[/B]

[B]ACTION_T_SET_STAND_STATE[/B]
Right now in Two, after applying the start-up fixes, there are 0 entries using 47 (ACTION_T_SUMMON_UNIQUE), and 6 entries using 48 (ACTION_T_SET_STAND_STATE); this is checking the fields: action1_type, action2_type, and action3_type.

So, we can safely change the records that use 48 to 47 (value should also be changed in CreatureEventAI.h)

[COLOR="#0000FF"]UPDATE creature_ai_scripts SET action1_type = 47 WHERE id IN (454207, 840003, 1684701, 1029903, 2861201);
UPDATE creature_ai_scripts SET action2_type = 47 WHERE id = 1722601;[/COLOR]

[B]ACTION_T_SUMMON_UNIQUE[/B]
Not currently used in Two, so nothing needs to be done.

[B]ACTION_T_CHANGE_MOVEMENT[/B]
Not currently used in Two, so nothing needs to be done.

Corrections/changes made to server core. Currently building...
VS, and cmake (Linux)

----------------------------------------------

Build successful... going in-game and checking logs

-----------------------------------------------

Successfuly passed the Travis build :D

[B][COLOR="#008000"][SIZE=3]Pull Request has now been made:[/SIZE][/COLOR][/B]

server core
[url]https://github.com/mangostwo/server/pull/92[/url]

database
[url]https://github.com/mangostwo/database/pull/19[/url]