[sql][8992] some proc flag corrections

[pasdVn]

http://www.wowhead.com/?search=ferocious#talents

Missing Entry, pocs only on crit:

/*Ferocious Inspiration*/
DELETE FROM `spell_proc_event` WHERE `entry` IN (34457);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES
(34457, 0, 0, 0, 0, 0, 0, 2, 0, 0, 0);

http://www.wowhead.com/?spell=19621

Missing Entry, pocs only on crit:

/*Frenzy*/
DELETE FROM `spell_proc_event` WHERE `entry` IN (20784);
INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`)VALUES 
('20784', '0', '0', '0', '0', '0', '0', '2', '0', '0', '0');

http://www.wowhead.com/?search=Master+Tactician#talents

Missing entry. Needs proc flag because also non direct damage spells should be abled to trigger (stings etc.).

/*Master Tactician*/
DELETE FROM `spell_proc_event` WHERE `entry` IN (34506, 34507, 34508, 34838, 34839);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES
(34506, 0, 9, 522753, 8392833, 134218241, 0, 0, 0, 0, 0),
(34507, 0, 9, 522753, 8392833, 134218241, 0, 0, 0, 0, 0),
(34508, 0, 9, 522753, 8392833, 134218241, 0, 0, 0, 0, 0),
(34838, 0, 9, 522753, 8392833, 134218241, 0, 0, 0, 0, 0),
(34839, 0, 9, 522753, 8392833, 134218241, 0, 0, 0, 0, 0);

http://www.wowhead.com/?search=Hunting+Party#talents

Strange familyflags currently. Update for the 3 correct trigger spells.

/*Hunting Party*/
DELETE FROM `spell_proc_event` WHERE entry IN (53290, 53291, 53292);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES
(53290, 0, 9, 0x800, 0x1, 0x200, 0, 0x2, 0, 0, 0),
(53291, 0, 9, 0x800, 0x1, 0x200, 0, 0x2, 0, 0, 0),
(53292, 0, 9, 0x800, 0x1, 0x200, 0, 0x2, 0, 0, 0);

http://www.wowhead.com/?spell=46913

Wrong family- and procEx flags. Thanks to Lightguard.

/*Bloodsurge*/
DELETE FROM `spell_proc_event` WHERE `entry` IN (46913, 46914, 46915);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `cooldown`) VALUES
(46913, 0, 4, 64, 1028, 0, 0, 0, 0, 0, 0),
(46914, 0, 4, 64, 1028, 0, 0, 0, 0, 0, 0),
(46915, 0, 4, 64, 1028, 0, 0, 0, 0, 0, 0);

http://www.wowhead.com/?search=entrapment

Udated familyflags (new flags with 3.?.?)

/*Entrapment*/
DELETE FROM `spell_proc_event` WHERE `entry` IN (19184, 19387, 19388);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES
(19184, 0, 9, 0x10, 0x2000, 0, 0, 0, 0, 0, 0),
(19387, 0, 9, 0x10, 0x2000, 0, 0, 0, 0, 0, 0),
(19388, 0, 9, 0x10, 0x2000, 0, 0, 0, 0, 0, 0);

http://www.wowhead.com/?spell=35100

Updatet Family Flags for new effect since 3.?.?

/*Concussive Barrage*/
DELETE FROM `spell_proc_event` WHERE `entry` IN (35100, 35102);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES
(35100, 0, 9, 4096, 0, 1, 256, 0, 0, 0, 0),
(35102, 0, 9, 4096, 0, 1, 256, 0, 0, 0, 0);

http://www.wowhead.com/?spell=51521

Set Family Flags, to trigger just from stormstrike. The thing with the cooldown is in fact just a kind of workaround, to trigger not twice every use of Stormstrike (main and offhand spell have same familyflags :-/ )

/*Imp. Stormstrike*/
DELETE FROM `spell_proc_event` WHERE `entry` IN (51521, 51522);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) VALUES
(51521, 0, 11, 0, 16, 0, 0, 0, 0, 0, 1),
(51522, 0, 11, 0, 16, 0, 0, 0, 0, 0, 1);

[Sephiroth1983]

Nice, can you use delete before insert if records don't exist as well?

Is to avoid duplicate errors at reapply, Devs prefeare it like that.

[Lightguard]

UPDATE spell_proc_event SET SpellFamilyMask0=0, SpellFamilyMask1=1096, SpellFamilyMask2=0 WHERE entry=46915;

(Bloodsurge proc)

We could add this too. Afaik there's already a row for it so we just update that.

[pasdVn]

Added the DELETE's... even if I don't think that a dev will be more motivated now to have look on that

To Lightguards Suggestion:

Are you sure you have the correct FamilyFlags? I rechecked that, and have the following one:

/*Bloodsurge*/
DELETE FROM spell_proc_event WHERE entry IN (46913, 46914, 46915);
INSERT INTO `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `cooldown`) VALUES
(46913, 0, 4, 64, 1028, 0, 0, 0, 0, 0, 0),
(46914, 0, 4, 64, 1028, 0, 0, 0, 0, 0, 0),
(46915, 0, 4, 64, 1028, 0, 0, 0, 0, 0, 0);

I also removed the 'procEx' (was onCrit before).

[Lightguard]

That was simply unworkable. (Please read my name again.)

[pasdVn]

(Please read my name again.)

Oh, sorry :-/.

[Sephiroth1983]

Bump, Frenzy is procing on normal attacks, this fixes that overpower

please review.

ps: the bloodsurge query is missing a ` quote

[pasdVn]

Ah ok. Now I know what he meant by "unworkable"^^.

Maybe anybody could give a feedback if Bloodsurge is correct now (the family flags I suggested). I could move it to the first post than.

[Lightguard]

I can confirm, it's working correctly. Thank you.

[mokanina]

bumping. tested and looks good

[pasdVn]

Added changing procflags for "Entrapment". Rest is still hot

Edit: Also updated family flags for "Master Tactician" (added black arrow)

[KAPATEJIb]

You make a typo in Entrapment first rank

Should be 19184, not 19384

[pasdVn]

You are right. Thank you!

[Morphau]

Thanks, insert in the source ?

[Morphau]

Euh, sorry but this:

 
/*Frenzy*/
DELETE FROM spell_proc_event WHERE entry IN (20784);
INSERT INTO `mangos`.`spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`)VALUES
('20784', '0', '0', '0', '0', '0', '0', '2', '0', '0', '0');

is a litle fasle because of:

 `mangos`.`spell_proc_event`

The good is:

 
/*Frenzy*/
DELETE FROM spell_proc_event WHERE entry IN (20784);
INSERT INTO `spell_proc_event` (`entry` ,`SchoolMask` ,`SpellFamilyName` ,`SpellFamilyMask0` ,`SpellFamilyMask1` ,`SpellFamilyMask2` ,`procFlags` ,`procEx` ,`ppmRate` ,`CustomChance` ,`Cooldown`)VALUES
('20784', '0', '0', '0', '0', '0', '0', '2', '0', '0', '0');

? ^^

[pasdVn]

Thanks and sorry. Hope it is finally bug free now :-/

[merlinus]

Using mangos 8231 I'm testing this sql patch.

Have this error when mangos start:

2009-07-22 10:55:38 ERROR:Spell 53294 listed in `spell_proc_event` does not exist

2009-07-22 10:55:38 ERROR:Spell 53293 listed in `spell_proc_event` does not exist

Is about the "Hunting Party" patch above.

Any comments?

[dardennf]

Yes, rank 3 and 4 don't exist ^^.

So, I think the talent has been changed.

[pasdVn]

Ah, yes of course. Was reduced to a 3 point talent with 3.1.3. Updated.

[Morphau]

Euh, for make a real update, not forgot clean spell 53293 and 53294 in spell_proc_event ...

I think the good request it's:

DELETE FROM `spell_proc_event` WHERE entry IN (53290, 53291, 53292, 53293, 53294);

Not ? ^^

[pasdVn]

They aren't in the in the official sql dumps anymore, so we won't need to DELETE them

[thenecromancer]

Missing entry. Needs proc flag because also non direct damage spells should be abled to trigger (stings etc.).

I don't agree, if there are problem with non direct damage spells, core needs to be fixed instead

[pasdVn]

Maybe you are right, and we should simply let all spells trigger...

I don't know which is the more generic way. But if we would change the code, so that every spell is abled to trigger (so also dot's or any other aura applying spells), we will have to add spell_proc_event entries for other spells as well, that won't work correct with this logic.

[Davletuner]

pasdVn look your PM

[pasdVn]

Added "Improved Stormstrike" and "Concussive Barrage". Updatet Entrapment provflags (just snake- and frosttrap now).