Playerbot (archive)

[BThallid]

There is also Gnomish Army Knife, which has its own totem category.

We have two options: 1) Call HasItemTotemCategory() for all pickaxe categories, or 2) write own method which would check all types of picks in single iteration.

I tested this. Did you read my note after the code?

The core's function also calls another function, IsTotemCategoryCompatiableWith, that checks if the item is compatible with the current TotemCategory, so it only has to be called for the specific category.

I guess it was kind of vague, but I noticed the different totem categories myself. I used the army knife as a test for the bot before I submitted.

Here is the mentioned code from the core:

bool IsTotemCategoryCompatiableWith(uint32 itemTotemCategoryId, uint32 requiredTotemCategoryId)
{
   if(requiredTotemCategoryId==0)
       return true;
   if(itemTotemCategoryId==0)
       return false;

   TotemCategoryEntry const* itemEntry = sTotemCategoryStore.LookupEntry(itemTotemCategoryId);
   if(!itemEntry)
       return false;
   TotemCategoryEntry const* reqEntry = sTotemCategoryStore.LookupEntry(requiredTotemCategoryId);
   if(!reqEntry)
       return false;

   if(itemEntry->categoryType!=reqEntry->categoryType)
       return false;

   return (itemEntry->categoryMask & reqEntry->categoryMask)==reqEntry->categoryMask;
}

It checks it already in the core.

[blueboy]

I checked out the source of Mangos from git, then I checked out ScriptDev2 sources from their SVN, and then merged your repo with the local files.

Just like the Tutorial suggests it. Am I missing some point?

Yeah,

I'm sure it's something specific you have missed. I was hoping you would provide a step-by-step procedure, not a problem. Please bear with me, I will show you what I use.

I prefer to use scripts to execute each stage in the process. It's apparent from the info on pastebin that your running a *nix server.

I use '/home/mangos/compile/portal' as my working directory and the playerbot code is obtained from the development repo portal rather than blueboy. You will need to change this to suite your system.

Script to obtain playerbot.patch (run this first)

#!/bin/bash -x
git clone git://github.com/mangos/mangos.git portal_patch
cd portal_patch
git fetch git://github.com/blueboy/portal.git master:portal
git checkout portal
HASH=`git log --pretty=oneline | grep -m 1 '\\[1[0-9]\\{4\\}]' | cut -d " " -f 1`
git diff $HASH > playerbot.patch

Script to obtain MaNGOS code and organize various service scripts and mod patches

#!/bin/bash -x

unset WORK

WORK="/home/mangos/compile/portal"

if [ !  -d "${WORK}"   ]; then
   mkdir ${WORK};
fi

cp scripts/org.sh ${WORK}
cp scripts/build.sh ${WORK}
cp scripts/scriptdev2.sh ${WORK}
cp scripts/patch.sh ${WORK}
cp portal_patch/playerbot.patch ${WORK}/
cp patches/config.h.in.patch ${WORK}/

cd ${WORK}

# raw mangos setup
git init
git pull git://github.com/mangos/mangos.git master

cd portal

git log will give you the commit history so you can select the appropriate MaNGOS code (branch). If your using the MaNGOS HEAD this is not necessary.

git apply --check --whitespace=fix playerbot.patch check for possible merge conflicts with MaNGOS. If none, run again without --check option. Repeat this procedure for all additional mod patches.

Script to obtain scriptdev2.sh code (run this now).

#!/bin/bash

unset VERSION
unset DEST

VERSION=$1
DEST="/home/mangos/compile/portal/src/bindings/ScriptDev2"
if [ -z "${VERSION}" ]; then
echo "No ScriptDev2 VERSION specified, assume latest VERSION";
else
VERSION="-r "${VERSION};
fi

if [ -d "${DEST}" ]; then
rm -R ${DEST};
fi

mkdir ${DEST};
svn co [url]https://scriptdev2.svn.sourceforge.net/svnroot/scriptdev2/[/url] ${DEST} ${VERSION}

I have notified Scriptdev2.com of an issue that prevents 'scriptdev2.conf' from loading as it should. It's been ignored, but here is a patch config.h.in.patch anyway. (apply this now)

diff --git a/src/bindings/ScriptDev2/config.h.in b/src/bindings/ScriptDev2/config.h.in
index bb3caf8..1605075 100644
--- a/src/bindings/ScriptDev2/config.h.in
+++ b/src/bindings/ScriptDev2/config.h.in
@@ -24,7 +24,7 @@

// Format is YYYYMMDDRR where RR is the change in the conf file
// for that day.
-#define SD2_CONF_VERSION    2009040501
+#define SD2_CONF_VERSION    2010062001

#ifdef WIN32
  #define MANGOS_DLL_EXPORT extern "C" __declspec(dllexport)

You now need to bind the MaNGOS and scriptdev2 code so they compile together. (Only on *nix systems)

#!/bin/bash 

unset BRANCH
unset PATCHES

BRANCH=$1
PATCHES="/home/mangos/compile/portal/src/bindings/ScriptDev2/patches/"

[ ! -z "${BRANCH}" ] || { echo "available patches:>"; ls ${PATCHES}; exit 1 ; }

patch -p1 < ${PATCHES}'MaNGOS-'${BRANCH}'-ScriptDev2.patch'

run this ./patch.sh to show current patches.

available patches:>

MaNGOS-9519-ScriptDev2.patch custom

run again specifying required patch.

./patch.sh 9519

You now need to create an objdir folder to prepare and build your source org.sh (run this now)

#!/bin/bash
autoreconf --install --force
mkdir /home/mangos/compile/portal/objdir
mv build.sh /home/mangos/compile/portal/objdir

cd objdir

You now need to compile the source build.sh (run this now)

#!/bin/bash
../configure --prefix=/home/mangos/wow --sysconfdir=/home/mangos/wow/etc \\
   --with-python \\
   --enable-cli \\
   --enable-ra \\
   --datadir=/home/mangos/wow/data

and finally link the code

make

The code should now compile and link without issue. Sorry if you know most of this, but I hope it will help

[blueboy]

Hi BThallid,

Sorry for the misunderstanding with your patch, it was my bad. I have now tested the code with all types of pick and your right

IsTotemCategoryCompatiableWith() used by HasItemTotemCategory(), does check that the pick can be used to mine.

TotemCategory Entry Name Mine

--------------- ----- ------ ------

none none none no

167 40892 Hammer Pick yes

168 40893 Bladed Pickaxe yes

161 40772 Gnomish Army Knife yes

165 1959 Cold Iron Pick yes

I will update portal ASAP.

Would you like to be added as a collaborator to the playerbot project. You can then push your own changes without further confusion, mostly by me

Let us know

[kyle1]

There is a new branch in portal repo called 'buffs'. It is a try to implement sane buffs for bots. New buff() method performs several checks before casting a spell which include:

1) Target level. If level is too low, then AI looks for a lower rank of the spell.

2) Target auras, If spell applies an aura which is better then one that already exists on target, or target does not have such aura at all, then spell is casted. This check allows to overwrite auras from same spell if new aura has better modifier. One example is talented Blessing of Might. MaNGOS core does not perform this check and always overwrites such auras.

So far only paladin AI was updated to use this method. There is one flaw in current implementation, I want to point to. Since paladins can have only one blessing per target, in several scenarios paladin bots will "lock" their talented spells for buff targets. One way to solve this problem would be implementing buff manager, which will decide how each bot buffs each target. This will require some kind of command queue for bots.

[BThallid]

Would you like to be added as a collaborator to the playerbot project. You can then push your own changes without further confusion, mostly by me

Let us know

I'm not sure if all my ideas would be suitable for the repo. One part that I had been working on was to utilize more of the SMSG handling instead of accessing the core's functions. For example, sending a CMSG_CAST_SPELL packet instead of accessing the CastSpell function directly. Also, there is a leak some where in the handling of the get part of HandleCommand function that I was able to remove for mining and herb gathering by replacing it, but I still need to do further testing and add back in the rest of the get capabilities. I had also added in SMSG_SPELL_FAILED, SMSG_SPELL_START, and SMSG_LOOT_RESPONSE for various pieces of it.

There is a new branch in portal repo called 'buffs'. It is a try to implement sane buffs for bots. New buff() method performs several checks before casting a spell which include:

I was looking at moving all the buff related code into the function BuffPlayer(Player* target) but then renaming that function to BuffTarget(Unit& target) because more than just players could be buffed (escorts, pets, etc). The only additional check I was going to include was a function for checking if spell reagents were available. It might be a good to make it an option for the master to set whether the bot should use reagents or not.

Here is the HasReagents(uint32 spellId) code that I adapted from the core's TakeReagents() function:

diff --git a/src/game/playerbot/PlayerbotAI.cpp b/src/game/playerbot/PlayerbotAI.cpp
index 08d674e..b86fe36 100644
--- a/src/game/playerbot/PlayerbotAI.cpp
+++ b/src/game/playerbot/PlayerbotAI.cpp
@@ -2541,6 +2541,30 @@ bool PlayerbotAI::HasPick()
    return false;
}

+bool PlayerbotAI::HasReagents(uint32 spellId)
+{
+    const SpellEntry* const pSpellInfo = sSpellStore.LookupEntry(spellId);
+    if (!pSpellInfo)
+        return false;
+
+    if (m_bot->CanNoReagentCast(pSpellInfo))
+        return true;
+
+    for (uint32 i = 0; i < MAX_SPELL_REAGENTS; ++i)
+    {
+        if(pSpellInfo->Reagent[i] <= 0)
+            continue;
+
+        uint32 itemid = pSpellInfo->Reagent[i];
+        uint32 count = pSpellInfo->ReagentCount[i];
+
+        if (!m_bot->HasItemCount(itemid, count))
+            return false;
+    }
+
+    return true;
+}
+
// extracts all item ids in format below
// I decided to roll my own extractor rather then use the one in ChatHandler
// because this one works on a const string, and it handles multiple links
diff --git a/src/game/playerbot/PlayerbotAI.h b/src/game/playerbot/PlayerbotAI.h
index 8341580..eea1249 100644
--- a/src/game/playerbot/PlayerbotAI.h
+++ b/src/game/playerbot/PlayerbotAI.h
@@ -181,6 +181,7 @@ public:

    bool PickPocket(Unit* pTarget);
    bool HasPick();
+    bool HasReagents(uint32 spellId);

    uint8 GetHealthPercent(const Unit& target) const;
    uint8 GetHealthPercent() const;

[kyle1]

I'm not sure if all my ideas would be suitable for the repo.

Ideas can always be discussed. I usually create a branch for new stuff, so people can leave comments on the code before it gets merged. Of course you can post pull requests from your own git repo.

The only additional check I was going to include was a function for checking if spell reagents were available.

Thank you. I've been thinking of implementing it as well. Speaking about reagents I think bots should always use them. They are not so expensive.

[madmax765]

Just wonding... lets say when im in game with my hunter..and i add bots.. and i mount they mount too.. but it only works with my hunter as main charater... if i try a mage or any other.. they dont seem to mount...they just run behind, its no biggie.... but is this only happing to me ? could this be fixed ?

Mangos: rev. using db: PSDB WotLK (r339) for 3.3.5a (Core r10605 / SD2 r1842)

[kyle1]

Bots should have same quality mounts as their master has. For example if your mage has 100% ground mount and hunter has only 60% one, then he won't mount at all after master.

[blueboy]

Hi Guys,

They have made some changes to the core that will cause a compilation error

CXX Player.o

../../../src/game/Player.cpp: In member function virtual void Player::Update(uint32, uint32):

../../../src/game/Player.cpp:1494:33: error: p_time was not declared in this scope

../../../src/game/Player.cpp:1496:34: error: p_time was not declared in this scope

In Player.cpp change all instances of 'p_time' to 'update_diff' and it will compile and run without issue.

I will be updating both repos shortly

Hope this helps

[conan513]

another compilation error

[blueboy]

another compilation error

Have you got anymore information :rolleyes: For instance, a snippet of the error you are getting...

O.K. The changes made in the MaNGOS commit [10677] have been reversed. So to correct the following compile error

  CXX    Player.o
../../../src/game/Player.cpp: In member function virtual void Player::Update(uint32)
../../../src/game/Player.cpp:1498:33: error: update_diff was not declared in this scope
../../../src/game/Player.cpp:1500:34: error: update_diff was not declared in this scope

In Player.cpp change all instances of 'update_diff' to 'p_time' and it will compile and run without issue.

I will update both repos shortly

Hope this helps

[vladex]

got a new error:5>..\\..\\src\\game\\playerbot\\PlayerbotMgr.cpp(394): error C2664: 'Group::RemoveMember' : cannot convert parameter 2 from 'int' to 'RemoveMethod'

i have other addons installed too but they dont have anything to do with playerbot.

[KiriX]

got a new error:5>..\\..\\src\\game\\playerbot\\PlayerbotMgr.cpp(394): error C2664: 'Group::RemoveMember' : cannot convert parameter 2 from 'int' to 'RemoveMethod'

i have other addons installed too but they dont have anything to do with playerbot.

You are wrong...

Dungeonfinder made this conflict... Look at 394 line in PlayerbotMgr.cpp and modify parameter for RemoveMember as it should be if you install Dungeonfinder patch...

[blueboy]

Hi,

error:5>..\\..\\src\\game\\playerbot\\PlayerbotMgr.cpp(394): error C2664: 'Group::RemoveMember' : cannot convert parameter 2 from 'int' to 'RemoveMethod'

Are you getting this error at compile time or run time. I have just compiled the playerbot code with MaNGOS[10686] and had no problems.

        case CMSG_SPIRIT_HEALER_ACTIVATE:
       {
           // sLog.outDebug("SpiritHealer is resurrecting the Player %s",m_master->GetName());
           for (PlayerBotMap::iterator itr = m_playerBots.begin(); itr != m_playerBots.end(); ++itr)
           {
               Player* const bot = itr->second;
               Group *grp = bot->GetGroup();
               if (grp)
                   grp->RemoveMember(bot->GetGUID(), 1);
           }
           return;
       }

The error suggests that the second parameter being passed to RemoveMember is incorrect.

In Group.h

uint32 RemoveMember(ObjectGuid guid, uint8 method); // method: 0=just remove, 1=kick

You will see that parameter 2 is an 'int' and there is no conversion required.

What is 'RemoveMethod' ? I have searched the code (MaNGOS & Playerbot) and find no reference to it.

Let me know.

[blueboy]

Hi Guys,

Guess what?

CXX Player.o

../../../src/game/Player.cpp: In member function virtual void Player::Update(uint32, uint32):

../../../src/game/Player.cpp:1494:33: error: p_time was not declared in this scope

../../../src/game/Player.cpp:1496:34: error: p_time was not declared in this scope

Yes, they have decided to change it back again :rolleyes: in MaNGOS commit [10688]

Just in case they change their mind again, I will not update the repos for a day or two. In the meantime, change all instances of 'p_time' to 'update_diff' in Player.cpp.

Hope this helps

[vladex]

thanks,forgot to say i last added the dungeonfinder i realised while i was ingame testing it...

[conan513]

I can't compile the portal repo

9 succes 3 faild but in the bin directory only found the realmd files

[kyle1]

Please post compilation errors here. Latest portal code works fine for me.

[conan513]

here's my full build log

VC2010 and VC2008 was tried in, but the result is the same

1>------ Build started: Project: tbb, Configuration: Release Win32 ------
2>------ Build started: Project: ACE_Wrappers, Configuration: Release Win32 ------
1>Assembling...
1> Assembling: ..\\..\\dep\\tbb\\src\\tbb\\ia32-masm\\lock_byte.asm
1>Assembling...
2>Compiling...
1> Assembling: ..\\..\\dep\\tbb\\src\\tbb\\ia32-masm\\atomic_support.asm
1>generating tbb.def file
1>win32-tbb-export.def
2>XTI_ATM_Mcast.cpp
2>XML_Svc_Conf.cpp
1>Compiling...
1>tbb_thread.cpp
2>WIN32_Proactor.cpp
2>WIN32_Asynch_IO.cpp
1>tbb_misc.cpp
1>task.cpp
1>spin_rw_mutex_v2.cpp
1>spin_rw_mutex.cpp
1>spin_mutex.cpp
1>rml_tbb.cpp
2>WFMO_Reactor.cpp
2>UUID.cpp
1>recursive_mutex.cpp
1>queuing_rw_mutex.cpp
1>queuing_mutex.cpp
1>private_server.cpp
2>UTF8_Encoding_Converter.cpp
1>pipeline.cpp
2>UTF32_Encoding_Converter.cpp
1>mutex.cpp
2>UTF16_Encoding_Converter.cpp
2>UPIPE_Stream.cpp
1>itt_notify.cpp
1>dynamic_link.cpp
2>UPIPE_Connector.cpp
1>concurrent_vector_v2.cpp
1>concurrent_vector.cpp
1>concurrent_queue_v2.cpp
1>concurrent_queue.cpp
1>concurrent_hash_map.cpp
1>Compiling...
1>cache_aligned_allocator.cpp
1>Compiling...
1>itt_notify_proxy.c
2>UPIPE_Acceptor.cpp
2>UNIX_Addr.cpp
2>TTY_IO.cpp
1>Compiling resources...
1>Microsoft (R) Windows (R) Resource Compiler Version 6.1.6723.1
1>Copyright (C) Microsoft Corporation.  All rights reserved.
1>Linking...
1>   Creating library ..\\..\\dep\\lib\\Win32_Release\\tbb.lib and object ..\\..\\dep\\lib\\Win32_Release\\tbb.exp
1>Generating code
1>Finished generating code
2>TSS_Adapter.cpp
1>Embedding manifest...
1>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\tbb__Win32_Release\\BuildLog.htm"
1>tbb - 0 error(s), 0 warning(s)
2>Trace.cpp
3>------ Build started: Project: tbbmalloc, Configuration: Release Win32 ------
3>Assembling...
3> Assembling: ..\\..\\dep\\tbb\\src\\tbb\\ia32-masm\\lock_byte.asm
3>Assembling...
3> Assembling: ..\\..\\dep\\tbb\\src\\tbb\\ia32-masm\\atomic_support.asm
3>generating tbbmalloc.def file
3>win32-tbbmalloc-export.def
3>Compiling...
3>Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.30729.01 for 80x86
3>Copyright (C) Microsoft Corporation.  All rights reserved.
3>cl /GL /I "..\\..\\dep\\tbb\\include" /I "..\\..\\dep\\tbb\\src" /I "..\\..\\dep\\tbb\\build" /I "..\\..\\dep\\tbb\\build\\vsproject" /D "_WINDLL" /FD /MD /Fo".\\tbbmalloc__Win32_Release\\\\" /Fd".\\tbbmalloc__Win32_Release\\vc90.pdb" /W3 /c /Zi /TP /wd4244 /wd4267   /c /MD /O2 /Zi /EHs- /Zc:forScope /Zc:wchar_t /Oy /DDO_ITT_NOTIFY /DUSE_WINTHREAD /D_CRT_SECURE_NO_DEPRECATE /D_WIN32_WINNT=0x0400 /D__TBB_BUILD=1 /I../../src /I../../include /I../../src/tbbmalloc /I../../src/tbbmalloc
3>   ..\\..\\dep\\tbb\\src\\tbbmalloc\\tbbmalloc.cpp
3>   ..\\..\\dep\\tbb\\src\\tbb\\tbb_misc.cpp
3>   ..\\..\\dep\\tbb\\src\\tbbmalloc\\MemoryAllocator.cpp
3>   ..\\..\\dep\\tbb\\src\\tbb\\dynamic_link.cpp
3>tbbmalloc.cpp
2>TP_Reactor.cpp
3>tbb_misc.cpp
2>Token_Request_Reply.cpp
2>Token_Manager.cpp
2>Token_Invariants.cpp
2>Token_Collection.cpp
3>MemoryAllocator.cpp
2>Token.cpp
3>dynamic_link.cpp
2>TLI_Stream.cpp
2>TLI_Connector.cpp
3>Compiling...
3>Microsoft (R) 32-bit C/C++ Optimizing Compiler Version 15.00.30729.01 for 80x86
3>Copyright (C) Microsoft Corporation.  All rights reserved.
3>cl /GL /I "..\\..\\dep\\tbb\\include" /I "..\\..\\dep\\tbb\\src" /I "..\\..\\dep\\tbb\\build" /I "..\\..\\dep\\tbb\\build\\vsproject" /D "_WINDLL" /FD /MD /Fo".\\tbbmalloc__Win32_Release\\\\" /Fd".\\tbbmalloc__Win32_Release\\vc90.pdb" /W3 /c /Zi /TC /wd4244 /wd4267   /c /MD /O2 /Zi /EHs- /Zc:forScope /Zc:wchar_t /Oy /DDO_ITT_NOTIFY /DUSE_WINTHREAD /D_CRT_SECURE_NO_DEPRECATE /D_WIN32_WINNT=0x0400 /D__TBB_BUILD=1 /I../../src /I../../include /I../../src/tbbmalloc /I../../src/tbbmalloc
3>   ..\\..\\dep\\tbb\\src\\tbb\\itt_notify_proxy.c
3>itt_notify_proxy.c
3>Compiling resources...
3>Microsoft (R) Windows (R) Resource Compiler Version 6.1.6723.1
3>Copyright (C) Microsoft Corporation.  All rights reserved.
3>Linking...
2>TLI_Acceptor.cpp
3>   Creating library ..\\..\\dep\\lib\\Win32_Release\\tbbmalloc.lib and object ..\\..\\dep\\lib\\Win32_Release\\tbbmalloc.exp
3>Generating code
2>TLI.cpp
3>Finished generating code
3>Embedding manifest...
3>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\tbbmalloc__Win32_Release\\BuildLog.htm"
3>tbbmalloc - 0 error(s), 0 warning(s)
4>------ Build started: Project: genrevision, Configuration: Release Win32 ------
4>Compiling...
4>genrevision.cpp
2>Timeprobe.cpp
2>Time_Value.cpp
2>Throughput_Stats.cpp
2>Thread_Semaphore.cpp
4>Linking...
4>Generating code
4>Finished generating code
4>Embedding manifest...
2>Thread_Mutex.cpp
4>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\genrevision__Win32_Release\\BuildLog.htm"
4>genrevision - 0 error(s), 0 warning(s)
5>------ Build started: Project: g3dlite, Configuration: Release Win32 ------
5>Compiling...
5>AABox.cpp
5>Vector2.cpp
2>Thread_Manager.cpp
5>UprightFrame.cpp
2>Thread_Hook.cpp
5>TextOutput.cpp
2>Thread_Exit.cpp
2>Thread_Control.cpp
5>TextInput.cpp
2>Thread_Adapter.cpp
2>Thread.cpp
5>Sphere.cpp
5>RegistryUtil.cpp
5>ReferenceCount.cpp
2>Task.cpp
5>Ray.cpp
5>Random.cpp
5>Quat.cpp
2>System_Time.cpp
5>MemoryManager.cpp
5>Matrix4.cpp
2>Synch_Options.cpp
2>Svc_Conf_y.cpp
5>Log.cpp
2>Svc_Conf_Lexer.cpp
5>LineSegment.cpp
5>Line.cpp
5>Cylinder.cpp
5>CoordinateFrame.cpp
2>SV_Shared_Memory.cpp
2>SV_Semaphore_Simple.cpp
5>CollisionDetection.cpp
2>SV_Semaphore_Complex.cpp
2>SV_Message_Queue.cpp
2>SV_Message.cpp
5>Capsule.cpp
2>SUN_Proactor.cpp
2>String_Base_Const.cpp
2>Stats.cpp
2>Stack_Trace.cpp
5>BinaryOutput.cpp
5>BinaryInput.cpp
2>SString.cpp
2>SPIPE_Stream.cpp
5>BinaryFormat.cpp
5>Any.cpp
2>SPIPE_Connector.cpp
2>SPIPE_Addr.cpp
2>SPIPE_Acceptor.cpp
2>SPIPE.cpp
5>stringutils.cpp
2>SOCK_Stream.cpp
5>prompt.cpp
2>SOCK_SEQPACK_Connector.cpp
5>g3dfnmatch.cpp
2>SOCK_SEQPACK_Association.cpp
5>g3dmath.cpp
5>fileutils.cpp
2>SOCK_SEQPACK_Acceptor.cpp
5>debugAssert.cpp
5>Vector4.cpp
5>Vector3.cpp
2>SOCK_Netlink.cpp
2>SOCK_IO.cpp
2>SOCK_Dgram_Mcast.cpp
5>Triangle.cpp
5>System.cpp
2>SOCK_Dgram_Bcast.cpp
5>Port System::memcpy SIMD to all platforms
2>SOCK_Dgram.cpp
5>Port System::memfill SIMD to all platforms
5>Plane.cpp
5>Matrix3.cpp
2>SOCK_Connector.cpp
2>Sock_Connect.cpp
5>format.cpp
5>Crypto.cpp
5>Box.cpp
2>SOCK_CODgram.cpp
2>SOCK_Acceptor.cpp
2>SOCK.cpp
2>Signal.cpp
5>Creating library...
5>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\g3dlite__Win32_Release\\BuildLog.htm"
5>g3dlite - 0 error(s), 0 warning(s)
6>------ Build started: Project: framework, Configuration: Release Win32 ------
6>Compiling...
6>MemoryManagement.cpp
6>EventProcessor.cpp
6>ObjectLifeTime.cpp
2>Sig_Handler.cpp
2>Sig_Adapter.cpp
2>Shared_Object.cpp
2>Shared_Memory_SV.cpp
2>Shared_Memory_Pool.cpp
2>Shared_Memory_MM.cpp
6>Creating library...
6>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\framework__Win32_Release\\BuildLog.htm"
6>framework - 0 error(s), 0 warning(s)
2>Shared_Memory.cpp
7>------ Build started: Project: zlib, Configuration: Release Win32 ------
7>Compiling...
2>Service_Types.cpp
7>adler32.c
7>zutil.c
7>uncompr.c
7>trees.c
7>inftrees.c
7>inflate.c
2>Service_Repository.cpp
7>inffast.c
7>infback.c
7>gzio.c
7>example.c
7>deflate.c
7>crc32.c
7>compress.c
7>Creating library...
7>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\zlib__Win32_Release\\BuildLog.htm"
7>zlib - 0 error(s), 0 warning(s)
2>Service_Object.cpp
2>Service_Manager.cpp
2>Service_Gestalt.cpp
2>Service_Config.cpp
2>Semaphore.cpp
2>Select_Reactor_Base.cpp
2>Sched_Params.cpp
2>Sbrk_Memory_Pool.cpp
2>Sample_History.cpp
2>RW_Thread_Mutex.cpp
2>RW_Process_Mutex.cpp
2>RW_Mutex.cpp
2>Remote_Tokens.cpp
2>Remote_Name_Space.cpp
2>Registry_Name_Space.cpp
2>Registry.cpp
2>Recyclable.cpp
2>Recursive_Thread_Mutex.cpp
2>Read_Buffer.cpp
2>Reactor_Timer_Interface.cpp
2>Reactor_Notification_Strategy.cpp
2>Reactor_Impl.cpp
2>Reactor.cpp
2>Profile_Timer.cpp
2>Process_Semaphore.cpp
2>Process_Mutex.cpp
2>Process_Manager.cpp
2>Process.cpp
2>Proactor_Impl.cpp
2>Proactor.cpp
2>Priority_Reactor.cpp
2>POSIX_Proactor.cpp
2>POSIX_CB_Proactor.cpp
2>POSIX_Asynch_IO.cpp
2>Pipe.cpp
2>Ping_Socket.cpp
2>PI_Malloc.cpp
2>Parse_Node.cpp
2>Pagefile_Memory_Pool.cpp
2>OS_TLI.cpp
2>OS_Thread_Adapter.cpp
2>OS_QoS.cpp
2>OS_NS_wctype.cpp
2>OS_NS_wchar.cpp
2>OS_NS_unistd.cpp
2>OS_NS_time.cpp
2>OS_NS_Thread.cpp
2>OS_NS_sys_wait.cpp
2>OS_NS_sys_utsname.cpp
2>OS_NS_sys_uio.cpp
2>OS_NS_sys_time.cpp
2>OS_NS_sys_stat.cpp
2>OS_NS_sys_socket.cpp
2>OS_NS_sys_shm.cpp
2>OS_NS_sys_sendfile.cpp
2>OS_NS_sys_select.cpp
2>OS_NS_sys_resource.cpp
2>OS_NS_sys_msg.cpp
2>OS_NS_sys_mman.cpp
2>OS_NS_stropts.cpp
2>OS_NS_strings.cpp
2>OS_NS_string.cpp
2>OS_NS_stdlib.cpp
2>OS_NS_stdio.cpp
2>OS_NS_signal.cpp
2>OS_NS_regex.cpp
2>OS_NS_pwd.cpp
2>OS_NS_poll.cpp
2>OS_NS_netdb.cpp
2>OS_NS_math.cpp
2>OS_NS_fcntl.cpp
2>OS_NS_errno.cpp
2>OS_NS_dlfcn.cpp
2>OS_NS_dirent.cpp
2>OS_NS_ctype.cpp
2>OS_NS_arpa_inet.cpp
2>OS_main.cpp
2>OS_Log_Msg_Attributes.cpp
2>OS_Errno.cpp
2>Object_Manager_Base.cpp
2>Object_Manager.cpp
2>Obchunk.cpp
2>NT_Service.cpp
2>Notification_Strategy.cpp
2>Notification_Queue.cpp
2>Netlink_Addr.cpp
2>Naming_Context.cpp
2>Name_Space.cpp
2>Name_Request_Reply.cpp
2>Name_Proxy.cpp
2>Mutex.cpp
2>Multihomed_INET_Addr.cpp
2>Msg_WFMO_Reactor.cpp
2>Monitor_Size.cpp
2>Monitor_Point_Registry.cpp
2>Monitor_Control_Types.cpp
2>Monitor_Control_Action.cpp
2>Monitor_Base.cpp
2>Monitor_Admin_Manager.cpp
2>Monitor_Admin.cpp
2>MMAP_Memory_Pool.cpp
2>Method_Request.cpp
2>Message_Queue_Vx.cpp
2>Message_Queue_NT.cpp
2>Message_Queue.cpp
2>Message_Block.cpp
2>MEM_Stream.cpp
2>MEM_SAP.cpp
2>Mem_Map.cpp
2>MEM_IO.cpp
2>MEM_Connector.cpp
2>MEM_Addr.cpp
2>MEM_Acceptor.cpp
2>Manual_Event.cpp
2>Malloc_Allocator.cpp
2>Malloc.cpp
2>LSOCK_Stream.cpp
2>LSOCK_Dgram.cpp
2>LSOCK_Connector.cpp
2>LSOCK_CODgram.cpp
2>LSOCK_Acceptor.cpp
2>LSOCK.cpp
2>Logging_Strategy.cpp
2>Log_Record.cpp
2>Log_Msg_UNIX_Syslog.cpp
2>Log_Msg_NT_Event_Log.cpp
2>Log_Msg_IPC.cpp
2>Log_Msg_Callback.cpp
2>Log_Msg_Backend.cpp
2>Log_Msg.cpp
2>Lock.cpp
2>Local_Tokens.cpp
2>Local_Name_Space.cpp
2>Local_Memory_Pool.cpp
2>Lib_Find.cpp
2>IPC_SAP.cpp
2>IOStream.cpp
2>IO_SAP.cpp
2>IO_Cntl_Msg.cpp
2>Init_ACE.cpp
2>INET_Addr.cpp
2>ICMP_Socket.cpp
2>High_Res_Timer.cpp
2>Hashable.cpp
2>Handle_Set.cpp
2>Handle_Ops.cpp
2>gethrtime.cpp
2>Get_Opt.cpp
2>Functor_String.cpp
2>Functor.cpp
2>Framework_Component.cpp
2>Flag_Manip.cpp
2>Filecache.cpp
2>File_Lock.cpp
2>FILE_IO.cpp
2>FILE_Connector.cpp
2>FILE_Addr.cpp
2>FILE.cpp
2>FIFO_Send_Msg.cpp
2>FIFO_Send.cpp
2>FIFO_Recv_Msg.cpp
2>FIFO_Recv.cpp
2>FIFO.cpp
2>Event_Handler.cpp
2>Event.cpp
2>Encoding_Converter_Factory.cpp
2>Encoding_Converter.cpp
2>Dynamic_Service_Dependency.cpp
2>Dynamic_Service_Base.cpp
2>Dynamic_Message_Strategy.cpp
2>Dynamic.cpp
2>Dump.cpp
2>DLL_Manager.cpp
2>DLL.cpp
2>Dirent_Selector.cpp
2>Dirent.cpp
2>Dev_Poll_Reactor.cpp
2>DEV_IO.cpp
2>DEV_Connector.cpp
2>DEV_Addr.cpp
2>DEV.cpp
2>Date_Time.cpp
2>Countdown_Time.cpp
2>Copy_Disabled.cpp
2>Containers.cpp
2>Connection_Recycling_Strategy.cpp
2>Configuration_Import_Export.cpp
2>Configuration.cpp
2>Condition_Thread_Mutex.cpp
2>Condition_Recursive_Thread_Mutex.cpp
2>Codeset_Registry_db.cpp
2>Codeset_Registry.cpp
2>Codeset_IBM1047.cpp
2>Codecs.cpp
2>Cleanup.cpp
2>CDR_Stream.cpp
2>CDR_Size.cpp
2>CDR_Base.cpp
2>Capabilities.cpp
2>Basic_Types.cpp
2>Basic_Stats.cpp
2>Based_Pointer_Repository.cpp
2>Base_Thread_Adapter.cpp
2>Barrier.cpp
2>Auto_Event.cpp
2>Atomic_Op.cpp
2>ATM_Stream.cpp
2>ATM_QoS.cpp
2>ATM_Params.cpp
2>ATM_Connector.cpp
2>ATM_Addr.cpp
2>ATM_Acceptor.cpp
2>Asynch_Pseudo_Task.cpp
2>Asynch_IO_Impl.cpp
2>Asynch_IO.cpp
2>Assert.cpp
2>Argv_Type_Converter.cpp
2>Addr.cpp
2>Active_Map_Manager.cpp
2>Activation_Queue.cpp
2>ace_wchar.cpp
2>ACE_crc_ccitt.cpp
2>ACE_crc32.cpp
2>ACE.cpp
2>Compiling...
2>Rtems_init.c
2>Atomic_Op_Sparc.c
2>Compiling resources...
2>Microsoft (R) Windows (R) Resource Compiler Version 6.1.6723.1
2>Copyright (C) Microsoft Corporation.  All rights reserved.
2>Linking...
2>   Creating library ..\\..\\dep\\lib\\Win32_Release\\ACE.lib and object ..\\..\\dep\\lib\\Win32_Release\\ACE.exp
2>Embedding manifest...
2>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\ace__Win32_Release\\BuildLog.htm"
2>ACE_Wrappers - 0 error(s), 0 warning(s)
8>------ Build started: Project: shared, Configuration: Release Win32 ------
8>Extract revision
8>Compiling...
8>Database.cpp
8>Threading.cpp
8>ServiceWin32.cpp
8>Common.cpp
8>WorldModel.cpp
8>VMapManager2.cpp
8>VMapFactory.cpp
8>TileAssembler.cpp
8>ModelInstance.cpp
8>MapTree.cpp
8>BIH.cpp
8>Sha1.cpp
8>SARC4.cpp
8>HMACSHA1.cpp
8>BigNumber.cpp
8>AuthCrypt.cpp
8>Config.cpp
8>Util.cpp
8>ProgressBar.cpp
8>MemoryLeaks.cpp
8>Log.cpp
8>DBCFileLoader.cpp
8>SQLStorage.cpp
8>SqlOperations.cpp
8>SqlDelayThread.cpp
8>QueryResultMysql.cpp
8>Field.cpp
8>DatabaseMysql.cpp
8>Creating library...
8>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\shared__Win32_Release\\BuildLog.htm"
8>shared - 0 error(s), 0 warning(s)
9>------ Build started: Project: realmd, Configuration: Release Win32 ------
10>------ Build started: Project: game, Configuration: Release Win32 ------
10>Compiling...
9>Compiling...
10>pchdef.cpp
9>WheatyExceptionReport.cpp
9>RealmList.cpp
9>PatchHandler.cpp
9>Main.cpp
9>BufferedSocket.cpp
9>AuthSocket.cpp
9>Compiling resources...
9>Microsoft (R) Windows (R) Resource Compiler Version 6.1.6723.1
9>Copyright (C) Microsoft Corporation.  All rights reserved.
9>Linking...
9>   Creating library ..\\..\\bin\\Win32_Release\\realmd.lib and object ..\\..\\bin\\Win32_Release\\realmd.exp
9>Embedding manifest...
9>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\realmd__Win32_Release\\BuildLog.htm"
9>realmd - 0 error(s), 0 warning(s)
10>Compiling...
10>AccountMgr.cpp
10>ThreatManager.cpp
10>HostileRefManager.cpp
10>GroupReference.cpp
10>FollowerReference.cpp
10>PlayerDump.cpp
10>CharacterDatabaseCleaner.cpp
10>Level3.cpp
10>Level2.cpp
10>Level1.cpp
10>Level0.cpp
10>debugcmds.cpp
10>WorldSocketMgr.cpp
10>WorldSocket.cpp
10>WorldSession.cpp
10>Opcodes.cpp
10>DBCStores.cpp
10>Vehicle.cpp
10>Unit.cpp
10>TotemAI.cpp
10>Totem.cpp
10>TemporarySummon.cpp
10>StatSystem.cpp
10>SpellMgr.cpp
10>SocialMgr.cpp
10>ReputationMgr.cpp
10>ReactorAI.cpp
10>PlayerbotWarriorAI.cpp
10>PlayerbotWarlockAI.cpp
10>PlayerbotShamanAI.cpp
10>PlayerbotRogueAI.cpp
10>PlayerbotPriestAI.cpp
10>PlayerbotPaladinAI.cpp
10>PlayerbotMageAI.cpp
10>..\\..\\src\\game\\playerbot\\PlayerbotPaladinAI.cpp(142) : warning C4390: ';' : empty controlled statement found; is this the intent?
10>c:\\mangos\\mangos\\portal\\src\\game\\playerbot\\playerbotpaladinai.cpp(482) : warning C4715: 'PlayerbotPaladinAI::BuffPlayer' : not all control paths return a value
10>PlayerbotHunterAI.cpp
10>PlayerbotDruidAI.cpp
10>PlayerbotDeathKnightAI.cpp
10>PlayerbotClassAI.cpp
10>PlayerbotAI.cpp
10>c:\\mangos\\mangos\\portal\\src\\game\\playerbot\\playerbotclassai.cpp(16) : error C4716: 'PlayerbotClassAI::BuffPlayer' : must return a value
10>PlayerbotMgr.cpp
10>..\\..\\src\\game\\playerbot\\PlayerbotAI.cpp(2460) : warning C4018: '>=' : signed/unsigned mismatch
10>Player.cpp
10>PetAI.cpp
10>Pet.cpp
10>ObjectPosSelector.cpp
10>ObjectMgr.cpp
10>ObjectGuid.cpp
10>ObjectAccessor.cpp
10>Object.cpp
10>NullCreatureAI.cpp
10>LootMgr.cpp
10>ItemEnchantmentMgr.cpp
10>Item.cpp
10>Guild.cpp
10>GuardAI.cpp
10>GMTicketMgr.cpp
10>GameObject.cpp
10>DynamicObject.cpp
10>CreatureEventAIMgr.cpp
10>CreatureEventAI.cpp
10>CreatureAISelector.cpp
10>CreatureAIRegistry.cpp
10>CreatureAI.cpp
10>Creature.cpp
10>Corpse.cpp
10>Camera.cpp
10>Calendar.cpp
10>Bag.cpp
10>AuctionHouseMgr.cpp
10>ArenaTeam.cpp
10>AggressorAI.cpp
10>WaypointMovementGenerator.cpp
10>TargetedMovementGenerator.cpp
10>RandomMovementGenerator.cpp
10>PointMovementGenerator.cpp
10>MovementGenerator.cpp
10>MotionMaster.cpp
10>IdleMovementGenerator.cpp
10>HomeMovementGenerator.cpp
10>FleeingMovementGenerator.cpp
10>DestinationHolder.cpp
10>ConfusedMovementGenerator.cpp
10>World.cpp
10>Weather.cpp
10>WaypointManager.cpp
10>VoiceChatHandler.cpp
10>UpdateData.cpp
10>Transports.cpp
10>TradeHandler.cpp
10>TaxiHandler.cpp
10>SpellHandler.cpp
10>SpellEffects.cpp
10>UnitAuraProcHandler.cpp
10>SpellAuras.cpp
10>Spell.cpp
10>SkillHandler.cpp
10>SkillExtraItems.cpp
10>SkillDiscovery.cpp
10>ScriptCalls.cpp
10>QuestHandler.cpp
10>QuestDef.cpp
10>QueryHandler.cpp
10>PoolManager.cpp
10>PetitionsHandler.cpp
10>PetHandler.cpp
10>ObjectGridLoader.cpp
10>NPCHandler.cpp
10>MovementHandler.cpp
10>MiscHandler.cpp
10>MapManager.cpp
10>MapInstanced.cpp
10>Map.cpp
10>Mail.cpp
10>LootHandler.cpp
10>LFGHandler.cpp
10>ItemHandler.cpp
10>InstanceSaveMgr.cpp
10>InstanceData.cpp
10>GuildHandler.cpp
10>GroupHandler.cpp
10>Group.cpp
10>GridStates.cpp
10>GridNotifiers.cpp
10>GridMap.cpp
10>GossipDef.cpp
10>GMTicketHandler.cpp
10>GameEventMgr.cpp
10>DuelHandler.cpp
10>CombatHandler.cpp
10>ChatHandler.cpp
10>Chat.cpp
10>CharacterHandler.cpp
10>ChannelMgr.cpp
10>ChannelHandler.cpp
10>Channel.cpp
10>CalendarHandler.cpp
10>BattleGroundWS.cpp
10>BattleGroundSA.cpp
10>BattleGroundRV.cpp
10>BattleGroundRL.cpp
10>BattleGroundRB.cpp
10>BattleGroundNA.cpp
10>BattleGroundMgr.cpp
10>BattleGroundIC.cpp
10>BattleGroundHandler.cpp
10>BattleGroundEY.cpp
10>BattleGroundDS.cpp
10>BattleGroundBE.cpp
10>BattleGroundAV.cpp
10>BattleGroundAB.cpp
10>BattleGroundAA.cpp
10>BattleGround.cpp
10>AuctionHouseHandler.cpp
10>ArenaTeamHandler.cpp
10>AchievementMgr.cpp
10>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\game__Win32_Release\\BuildLog.htm"
10>game - 1 error(s), 3 warning(s)
11>------ Build started: Project: mangosd, Configuration: Release Win32 ------
11>Compiling...
11>WorldRunnable.cpp
11>WheatyExceptionReport.cpp
11>stdsoap2.cpp
11>soapServer.cpp
11>soapC.cpp
11>RASocket.cpp
11>Master.cpp
11>MaNGOSsoap.cpp
11>Main.cpp
11>CliRunnable.cpp
11>Compiling resources...
11>Microsoft (R) Windows (R) Resource Compiler Version 6.1.6723.1
11>Copyright (C) Microsoft Corporation.  All rights reserved.
11>Linking...
11>LINK : fatal error LNK1181: cannot open input file '.\\game__win32_release\\game.lib'
11>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\mangosd__Win32_Release\\BuildLog.htm"
11>mangosd - 1 error(s), 0 warning(s)
12>------ Build started: Project: script, Configuration: Release Win32 ------
12>Compiling...
12>sc_defines.cpp
12>sc_default.cpp
12>system.cpp
12>ScriptMgr.cpp
12>Linking...
12>LINK : fatal error LNK1181: cannot open input file 'mangosd.lib'
12>Build log was saved at "file://c:\\MaNGOS\\MANGOS\\portal\\win\\VC90\\script__Win32_Release\\BuildLog.htm"
12>script - 1 error(s), 0 warning(s)
========== Build: 9 succeeded, 3 failed, 0 up-to-date, 0 skipped ==========

[kyle1]

Fix pushed. I can't really test it cos I have no VC, but error log was verbose enough to see the problem. GCC is not so picky as VC... sometimes

[conan513]

Cool, thanks for the quick fix.

invaluable the playerbot and the ahbot for my Single Player Project

[mrelfire]

remote: Counting objects: 3438, done.
remote: Compressing objects: 100% (716/716), done.
remote: Total 3266 (delta 2760), reused 3027 (delta 2550)
Receiving objects: 100% (3266/3266), 1.22 MiB | 243 KiB/s, done.
Resolving deltas: 100% (2760/2760), completed with 68 local objects.
From git://github.com/blueboy/mangos
* branch            master     -> FETCH_HEAD
Auto-merging src/game/Group.cpp
Auto-merging src/game/Makefile.am
Auto-merging src/game/Map.cpp
Auto-merging src/game/Object.cpp
CONFLICT (content): Merge conflict in src/game/Object.cpp
Auto-merging src/game/Player.cpp
Auto-merging src/game/Player.h
Auto-merging src/game/QueryHandler.cpp
Auto-merging src/game/World.cpp
Auto-merging src/game/WorldSession.cpp
Auto-merging win/VC100/game.vcxproj
Auto-merging win/VC100/game.vcxproj.filters
Auto-merging win/VC90/game.vcproj
Automatic merge failed; fix conflicts and then commit the result.

a latest little conflict with a core change

[conan513]

the mangosd.exe is constantly crashing

here is the crash log

Revision: * * 10744 *
Date 19:11:2010. Time 12:30 
//=====================================================
*** Hardware ***
Processor: AMD Athlon(tm) 64 X2 Dual Core Processor 5000+
Number Of Processors: 2
Physical Memory: 4193848 KB (Available: 1917128 KB)
Commit Charge Limit: 4194303 KB

*** Operation System ***
Windows Vista or Windows Server 2008 Professional Service Pack 1, v.721 (Version 6.1, Build 7601)

//=====================================================
Exception code: C0000005 ACCESS_VIOLATION
Fault address:  0041A98F 01:0001998F C:\\full\\world of warcraft\\fscommand\\mangos\\Normal\\mangosd.exe

Registers:
EAX:753FCE5D
EBX:F374FF40
ECX:00000000
EDX:00000000
ESI:00000000
EDI:00000036
CS:EIP:0023:0041A98F
SS:ESP:002B:0848DCA0  EBP:0848ECB0
DS:002B  ES:002B  FS:0053  GS:002B
Flags:00010202

Call stack:
Address   Frame     Function      SourceFile
0041A98F  00000000  Object::GetUInt32Value+1F
004EFA47  00000000  PlayerbotAI::Buff+47
0077BB9F  00000000  PlayerbotPaladinAI::Bless+CF
0077BD3C  00000000  PlayerbotPaladinAI::BuffPlayer+EC
0077BEBA  00000000  PlayerbotPaladinAI::DoNonCombatActions+6A
004F1066  00000000  PlayerbotAI::UpdateAI+466
0055489D  00000000  Player::Update+74D
0059932E  00000000  Map::Update+5E
00599AB0  00000000  InstanceMap::Update+10
0065B144  00000000  MapManager::Update+64
004790C2  00000000  World::Update+262
0044AB09  00000000  WorldRunnable::run+E9
00459050  00000000  ACE_Based::Thread::ThreadTask+10
6CF87254  00000000  ACE_OS_Thread_Adapter::invoke+74
6E7AC6DE  00000000  _endthreadex+3A
6E7AC788  00000000  _endthreadex+E4
74AF3DFD  00000000  BaseThreadInitThunk+12
77359ED2  00000000  RtlInitializeExceptionChain+63
77359EA5  00000000  RtlInitializeExceptionChain+36
========================
Local Variables And Parameters

Call stack:
Address   Frame     Function      SourceFile
0041A98F  00000000  Object::GetUInt32Value+1F
punting on symbol index
   Local  <user defined> 'st'

004EFA47  00000000  PlayerbotAI::Buff+47
punting on symbol spellId
   Local  <user defined> 'target'
   Local  <user defined> 'beforeCast'
punting on symbol willBenefitFromSpell
punting on symbol i
punting on symbol sameOrBetterAuraFound

0077BB9F  00000000  PlayerbotPaladinAI::Bless+CF
punting on symbol spellId
   Local  <user defined> 'target'

0077BD3C  00000000  PlayerbotPaladinAI::BuffPlayer+EC
   Local  <user defined> 'target'
   Local  <user defined> 'ai'
punting on symbol petCanBeBlessed

0077BEBA  00000000  PlayerbotPaladinAI::DoNonCombatActions+6A
   Local  <user defined> 'fItem'
   Local  <user defined> 'm_bot'
   Local  <user defined> 'itr'
   Local  <user defined> 'msg'

004F1066  00000000  PlayerbotAI::UpdateAI+466
   Local  <user defined> 'p_time'
   Local  <user defined> 'loc'
   Local  <user defined> 'ch'

0055489D  00000000  Player::Update+74D
punting on symbol p_time
punting on symbol now
   Local  <user defined> 'iter'
punting on symbol newzone
punting on symbol newarea

0059932E  00000000  Map::Update+5E
   Local  <user defined> 't_diff'
   Local  <user defined> 'updater'
   Local  <user defined> 'area'
punting on symbol x
punting on symbol y
   Local  <user defined> 'cell'
   Local  <user defined> 'area'
punting on symbol x
punting on symbol y
   Local  <user defined> 'cell'
   Local  <user defined> 'st'

00599AB0  00000000  InstanceMap::Update+10
   Local  <user defined> 't_diff'

0065B144  00000000  MapManager::Update+64
punting on symbol diff

004790C2  00000000  World::Update+262
punting on symbol diff
punting on symbol maxClientsNum

0044AB09  00000000  WorldRunnable::run+E9
punting on symbol prevSleepTime

00459050  00000000  ACE_Based::Thread::ThreadTask+10
punting on symbol param

6CF87254  00000000  ACE_OS_Thread_Adapter::invoke+74
punting on symbol status

6E7AC6DE  00000000  _endthreadex+3A

6E7AC788  00000000  _endthreadex+E4

74AF3DFD  00000000  BaseThreadInitThunk+12

77359ED2  00000000  RtlInitializeExceptionChain+63

77359EA5  00000000  RtlInitializeExceptionChain+36

========================
Global Variables

[kyle1]

Wait for blueboy or me to update github repo. Current MaNGOS revision in portal repository is 10720 and yours is 10744. And portal does not crash for me. Looking at your log and previous post about merge conflict, I can say that problem is in Object class. Maybe it is MaNGOS problem, maybe Playerbot one, or maybe it is your merge problem.

[blueboy]

Hi Guys,

Yes I was aware of this issue when I was testing Ambal's new map system. The conflict occurs with an old fix I applied a long time ago, to improve the calculation of ground height UpdateGroundPositionZ(float x, float y, float &z). My fix is not needed now with the new map system, so it has been removed. I have updated both repos accordingly.

@conan513 I have looked at PlayerbotPaladinAI.cpp and I can't see any problems with the code. The crash on your system appears to occur during the conversion of a unsigned 16bit integer to an unsigned 32bit integer GetUInt32Value. This conversion is used throughout the code in general (MaNGOS and mods) and does not cause an issue to my knowledge. I would welcome comments from other Windows users, 32bit and 64bit users. It maybe an incompatiblity issue with 64bit systems.

Hope this helps