Possible fix - Shadow Dance

Auntie Mangos · January 1, 1970

so which is better fiyx for shadow dance this one whis was posted by jizar or this one http://getmangos.eu/community/viewtopic.php?id=8415&highlight=shadow+dance whis was posted by pelle but made by astellar ????

THX

Auntie Mangos · January 1, 1970

so which is better fiyx for shadow dance this one whis was posted by jizar or this one http://getmangos.eu/community/viewtopic.php?id=8415&highlight=shadow+dance whis was posted by pelle but made by astellar ????
THX

both the same fixxes...

identically with the other.

diff -- git a / src / game / SpellAuras . cpp b / src / game / SpellAuras . cpp
index 3a0862d . .0d28cb8 100644
--- a / src / game / SpellAuras . cpp
+++ b / src / game / SpellAuras . cpp
@@ - 2637 , 6 + 2637 , 9 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
case FORM_SHADOW :
case FORM_STEALTH :
break;
+        case FORM_SHADOWDANCE :
+ PowerType = POWER_ENERGY ;
+            break;
case FORM_TREE :
modelid = 864 ;
break;
@@ - 2682 , 7 + 2685 , 8 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
if( m_target -> m_ShapeShiftFormSpellId )
m_target -> RemoveAurasDueToSpell ( m_target -> m_ShapeShiftFormSpellId , this );

- m_target -> SetByteValue ( UNIT_FIELD_BYTES_2 , 3 , form );
+ // For Shadow Dance we must apply Stealth form (30) instead of current (13)
+ m_target -> SetByteValue ( UNIT_FIELD_BYTES_2 , 3 , ( form == FORM_SHADOWDANCE ) ? uint8 ( FORM_STEALTH ) : form );

if( modelid > 0 )
m_target -> SetDisplayId ( modelid );
@@ - 2747 , 6 + 2751 , 10 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
m_target -> SetPower ( POWER_RAGE , Rage_val );
break;
}
+ // Shadow Dance - apply stealth mode stand flag
+                case FORM_SHADOWDANCE :
+ m_target -> SetStandFlags ( UNIT_STAND_FLAGS_CREEP );
+                    break;
default:
break;
}
@@ - 2779 , 6 + 2787 , 10 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
if( Aura * dummy = m_target -> GetDummyAura ( 37324 ) )
m_target -> CastSpell ( m_target , 37325 , true , NULL , dummy );
break;
+ // Shadow Dance - remove stealth mode stand flag
+            case FORM_SHADOWDANCE :
+ m_target -> RemoveStandFlags ( UNIT_STAND_FLAGS_CREEP );
+                break;
default:
break;
}
diff -- git a / src / game / Unit . h b / src / game / Unit . h
index faefbef . .3f0e578 100644
--- a / src / game / Unit . h
+++ b / src / game / Unit . h
@@ - 167 , 6 + 167 , 7 @@ enum ShapeshiftForm
FORM_GHOUL = 0x07 ,
FORM_DIREBEAR = 0x08 ,
FORM_CREATUREBEAR = 0x0E ,
+ FORM_SHADOWDANCE = 0x0D ,
FORM_CREATURECAT = 0x0F ,
FORM_GHOSTWOLF = 0x10 ,
FORM_BATTLESTANCE = 0x11 ,

jizar · August 15, 2009

What bug does the patch fix? What features does the patch add?

Rogue's shadow dance

For which repository revision was the patch created?

works on 8360

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

--

Who has been writing this patch? Please include either forum user names or email addresses.

Got it from Russian mangos (http://mangos.ru/forum/showthread.php?t=20792)

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp 
index 3a0862d..0d28cb8 100644 
--- a/src/game/SpellAuras.cpp 
+++ b/src/game/SpellAuras.cpp 
@@ -2637,6 +2637,9 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) 
        case FORM_SHADOW: 
        case FORM_STEALTH: 
            break; 
+        case FORM_SHADOWDANCE: 
+            PowerType = POWER_ENERGY; 
+            break; 
        case FORM_TREE: 
            modelid = 864; 
            break; 
@@ -2682,7 +2685,8 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) 
        if(m_target->m_ShapeShiftFormSpellId) 
            m_target->RemoveAurasDueToSpell(m_target->m_ShapeShiftFormSpellId, this); 

-        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, form); 
+        // For Shadow Dance we must apply Stealth form (30) instead of current (13) 
+        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, (form == FORM_SHADOWDANCE) ? uint8(FORM_STEALTH) : form); 

        if(modelid > 0) 
            m_target->SetDisplayId(modelid); 
@@ -2747,6 +2751,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) 
                        m_target->SetPower(POWER_RAGE, Rage_val); 
                    break; 
                } 
+                // Shadow Dance - apply stealth mode stand flag 
+                case FORM_SHADOWDANCE: 
+                    m_target->SetStandFlags(UNIT_STAND_FLAGS_CREEP); 
+                    break; 
                default: 
                    break; 
            } 
@@ -2779,6 +2787,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) 
                if(Aura* dummy = m_target->GetDummyAura(37324) ) 
                    m_target->CastSpell(m_target, 37325, true, NULL, dummy); 
                break; 
+            // Shadow Dance - remove stealth mode stand flag 
+            case FORM_SHADOWDANCE: 
+                m_target->RemoveStandFlags(UNIT_STAND_FLAGS_CREEP); 
+                break; 
            default: 
                break; 
        } 
diff --git a/src/game/Unit.h b/src/game/Unit.h 
index faefbef..3f0e578 100644 
--- a/src/game/Unit.h 
+++ b/src/game/Unit.h 
@@ -167,6 +167,7 @@ enum ShapeshiftForm 
    FORM_GHOUL              = 0x07, 
    FORM_DIREBEAR           = 0x08, 
    FORM_CREATUREBEAR       = 0x0E, 
+    FORM_SHADOWDANCE        = 0x0D, 
    FORM_CREATURECAT        = 0x0F, 
    FORM_GHOSTWOLF          = 0x10, 
    FORM_BATTLESTANCE       = 0x11,

This is the error i get when complying

2>..\\..\\src\\game\\SpellAuras.cpp(2724) : error C2065: 'FORM_SHADOWDANCE' : undeclared identifier

2>..\\..\\src\\game\\SpellAuras.cpp(2724) : error C2051: case expression not constant

2>..\\..\\src\\game\\SpellAuras.cpp(2795) : error C2065: 'FORM_SHADOWDANCE' : undeclared identifier

2>..\\..\\src\\game\\SpellAuras.cpp(2861) : error C2065: 'FORM_SHADOWDANCE' : undeclared identifier

2>..\\..\\src\\game\\SpellAuras.cpp(2861) : error C2051: case expression not constant

2>..\\..\\src\\game\\SpellAuras.cpp(2897) : error C2065: 'FORM_SHADOWDANCE' : undeclared identifier

2>..\\..\\src\\game\\SpellAuras.cpp(2897) : error C2051: case expression not constant

HELP ME FIX THIS PLZ ....

Namesis · August 16, 2009

I added it (manually) and it didnt gave any error.

Try adding it again.

========== Build: 11 succeeded, 0 failed, 0 up-to-date, 0 skipped ==========

luck

edit: btw, i tested it, it "works" but not like it should be.

When you enter shadow dance, you are NOT stealthed (which is ok) but you have like... stealth movements, (while walking, etc)

but yeah, it kinda works.

jizar · August 16, 2009

nice to know that it worked.... i still getting the same errors, imma try a clean build to see what happens.

EDIT: Got it, a clean solution solved the problem

VladimirMangos · August 16, 2009

Spell have aura SPELL_AURA_MOD_IGNORE_SHAPESHIFT that provide removing form req. for spells.

So setting form is cliary horriable hack. But set UNIT_STAND_FLAGS_CREE maybe ok.

pelle · August 16, 2009

Spell have aura SPELL_AURA_MOD_IGNORE_SHAPESHIFT that provide removing form req. for spells.
So setting form is cliary horriable hack. But set UNIT_STAND_FLAGS_CREE maybe ok.

ignoring the 275 aura's stalth form don't work, i tryed many times, probably there is a further check...

btw this patch work well, you have only the "animation" of stealth moves but walk speed is normal.

OPenaz · August 20, 2009

i'm using now fix from astellar...it works nearly fine, but the visual bug is problem...i will test others flags...maybe this will be solution, maybe not

SharkPD · August 20, 2009

hope anyone can modify it with vladimirs querys...

Rogue is only horrible:(

jizar · August 29, 2009

bump bump bump

ix.bin.perfect · September 3, 2009

bump bump bump

aphataeros · September 4, 2009

I dont want to annoy, but it would interest me too what is up with the fix?

Gamba88 · September 10, 2009

bump bump bump

ix.bin.perfect · September 21, 2009

please, could anybody have a look at this?

bulek · September 26, 2009

any progres:confused:

Clerigon · October 3, 2009

bump, any news?

cyrex · October 3, 2009

Going to test this in a few hours.

bulek · October 26, 2009

any news guys?:mellow:

Morphau · October 27, 2009

Yes, it's work perfectly with the last rev 8742

Insert it in the source ?

bulek · October 27, 2009

ok, and this patch works correct?

diff -- git a / src / game / SpellAuras . cpp b / src / game / SpellAuras . cpp
index 3a0862d . .0d28cb8 100644
--- a / src / game / SpellAuras . cpp
+++ b / src / game / SpellAuras . cpp
@@ - 2637 , 6 + 2637 , 9 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
case FORM_SHADOW :
case FORM_STEALTH :
break;
+        case FORM_SHADOWDANCE :
+ PowerType = POWER_ENERGY ;
+            break;
case FORM_TREE :
modelid = 864 ;
break;
@@ - 2682 , 7 + 2685 , 8 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
if( m_target -> m_ShapeShiftFormSpellId )
m_target -> RemoveAurasDueToSpell ( m_target -> m_ShapeShiftFormSpellId , this );

- m_target -> SetByteValue ( UNIT_FIELD_BYTES_2 , 3 , form );
+ // For Shadow Dance we must apply Stealth form (30) instead of current (13)
+ m_target -> SetByteValue ( UNIT_FIELD_BYTES_2 , 3 , ( form == FORM_SHADOWDANCE ) ? uint8 ( FORM_STEALTH ) : form );

if( modelid > 0 )
m_target -> SetDisplayId ( modelid );
@@ - 2747 , 6 + 2751 , 10 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
m_target -> SetPower ( POWER_RAGE , Rage_val );
break;
}
+ // Shadow Dance - apply stealth mode stand flag
+                case FORM_SHADOWDANCE :
+ m_target -> SetStandFlags ( UNIT_STAND_FLAGS_CREEP );
+                    break;
default:
break;
}
@@ - 2779 , 6 + 2787 , 10 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
if( Aura * dummy = m_target -> GetDummyAura ( 37324 ) )
m_target -> CastSpell ( m_target , 37325 , true , NULL , dummy );
break;
+ // Shadow Dance - remove stealth mode stand flag
+            case FORM_SHADOWDANCE :
+ m_target -> RemoveStandFlags ( UNIT_STAND_FLAGS_CREEP );
+                break;
default:
break;
}
diff -- git a / src / game / Unit . h b / src / game / Unit . h
index faefbef . .3f0e578 100644
--- a / src / game / Unit . h
+++ b / src / game / Unit . h
@@ - 167 , 6 + 167 , 7 @@ enum ShapeshiftForm
FORM_GHOUL = 0x07 ,
FORM_DIREBEAR = 0x08 ,
FORM_CREATUREBEAR = 0x0E ,
+ FORM_SHADOWDANCE = 0x0D ,
FORM_CREATURECAT = 0x0F ,
FORM_GHOSTWOLF = 0x10 ,
FORM_BATTLESTANCE = 0x11 ,

bulek · October 31, 2009

ok, and this patch works correct?

diff -- git a / src / game / SpellAuras . cpp b / src / game / SpellAuras . cpp
index 3a0862d . .0d28cb8 100644
--- a / src / game / SpellAuras . cpp
+++ b / src / game / SpellAuras . cpp
@@ - 2637 , 6 + 2637 , 9 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
case FORM_SHADOW :
case FORM_STEALTH :
break;
+        case FORM_SHADOWDANCE :
+ PowerType = POWER_ENERGY ;
+            break;
case FORM_TREE :
modelid = 864 ;
break;
@@ - 2682 , 7 + 2685 , 8 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
if( m_target -> m_ShapeShiftFormSpellId )
m_target -> RemoveAurasDueToSpell ( m_target -> m_ShapeShiftFormSpellId , this );

- m_target -> SetByteValue ( UNIT_FIELD_BYTES_2 , 3 , form );
+ // For Shadow Dance we must apply Stealth form (30) instead of current (13)
+ m_target -> SetByteValue ( UNIT_FIELD_BYTES_2 , 3 , ( form == FORM_SHADOWDANCE ) ? uint8 ( FORM_STEALTH ) : form );

if( modelid > 0 )
m_target -> SetDisplayId ( modelid );
@@ - 2747 , 6 + 2751 , 10 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
m_target -> SetPower ( POWER_RAGE , Rage_val );
break;
}
+ // Shadow Dance - apply stealth mode stand flag
+                case FORM_SHADOWDANCE :
+ m_target -> SetStandFlags ( UNIT_STAND_FLAGS_CREEP );
+                    break;
default:
break;
}
@@ - 2779 , 6 + 2787 , 10 @@ void Aura :: HandleAuraModShapeshift ( bool apply , bool Real )
if( Aura * dummy = m_target -> GetDummyAura ( 37324 ) )
m_target -> CastSpell ( m_target , 37325 , true , NULL , dummy );
break;
+ // Shadow Dance - remove stealth mode stand flag
+            case FORM_SHADOWDANCE :
+ m_target -> RemoveStandFlags ( UNIT_STAND_FLAGS_CREEP );
+                break;
default:
break;
}
diff -- git a / src / game / Unit . h b / src / game / Unit . h
index faefbef . .3f0e578 100644
--- a / src / game / Unit . h
+++ b / src / game / Unit . h
@@ - 167 , 6 + 167 , 7 @@ enum ShapeshiftForm
FORM_GHOUL = 0x07 ,
FORM_DIREBEAR = 0x08 ,
FORM_CREATUREBEAR = 0x0E ,
+ FORM_SHADOWDANCE = 0x0D ,
FORM_CREATURECAT = 0x0F ,
FORM_GHOSTWOLF = 0x10 ,
FORM_BATTLESTANCE = 0x11 ,

bump this patch work on 8742

Cobra101 · November 2, 2009

Bumpity bump...eh bomp?

bulek · November 3, 2009

devs plz review this patch )

Gamba88 · November 6, 2009

bump bump bump

Cobra101 · November 16, 2009

Any updates to this? Or review?

Sign In

Possible fix - Shadow Dance

Recommended Posts

Top Posters In This Topic

Popular Days

Top Posters In This Topic

Popular Days

Recently Browsing 0 members

Contact Us

Repositories

Important Information