[9482][patch]Blood Presence and Improved Blood/Frost/Unholy presences

[laise]

What bug does the patch fix? What features does the patch add?

-fixes these spells

For which repository revision was the patch created?

-8713

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

-haven't found any

Who has been writing this patch? Please include either forum user names or email addresses.

-me..

Link:

http://pastebin.com/f6ee590cc

SQL

-- (50365) Improved Blood Presence (Rank 1)
DELETE FROM `spell_proc_event` WHERE `entry` IN (50365);
INSERT INTO `spell_proc_event` VALUES
(50365, 0x00, 15, 0x00018000, 0x00000000, 0x00000000, 0x00004000, 0x00000000, 0.000000, 0.000000, 0);

-- (50384) Improved Frost Presence (Rank 1)
DELETE FROM `spell_proc_event` WHERE `entry` IN (50384);
INSERT INTO `spell_proc_event` VALUES
(50384, 0x00, 15, 0x00810000, 0x00000000, 0x00000000, 0x00004000, 0x00000000, 0.000000, 0.000000, 0);

-- (50391) Improved Unholy Presence (Rank 1)
DELETE FROM `spell_proc_event` WHERE `entry` IN (50391);
INSERT INTO `spell_proc_event` VALUES
(50391, 0x00, 15, 0x00808000, 0x00000000, 0x00000000, 0x00004000, 0x00000000, 0.000000, 0.000000, 0);

-- (48266) Blood Presence ()
DELETE FROM `spell_proc_event` WHERE `entry` IN (48266);
INSERT INTO `spell_proc_event` VALUES
(48266, 0x00, 0, 0x00000000, 0x00000000, 0x00000000, 0x00050014, 0x00010000, 0.000000, 0.000000, 0);

-- (63611) Improved Blood Presence ()
DELETE FROM `spell_proc_event` WHERE `entry` IN (63611);
INSERT INTO `spell_proc_event` VALUES
(63611, 0x00, 0, 0x00000000, 0x00000000, 0x00000000, 0x00050014, 0x00010000, 0.000000, 0.000000, 0);

1)fixes improved blood,frost,unholy presences retaining part of original presence

2)fixes blood presence itself (yes SPELL_AURA_MOD_DAMAGE_PERCENT_DONE should proc cause it has charges and/or procFlags in dbc)

3)Blood Aura no longer exists(after 3.1)

4)part of unholy presence related to rune cd might not work

5)idk if honor/experience-only healing of blood presence is still relevant

[ApoC]

+        case SPELLFAMILY_DEATHKNIGHT:
+        {
+            // Improved Unholy Presence (rune cd spells)
+            if (m_spellInfo->Id == 2825)
+            {
+                AddTriggeredSpell(63622);
+                AddTriggeredSpell(65095);
+            }
+            break;
+        }

Spell ID 2825 looks weird to me for deadknight Shouldn't be this spell icon check?

[laise]

can't use spell icon, because normal presence has it...

and i forgot about basepoints =\\

updated:

---last version in the first post

[KAPATEJIb]

I can't understand why you make a same check

+                
+                // Improved Blood Presence and Blood Presence
+                if( (spellInfo_1->Id == 48266 && spellInfo_2->Id == 63611) ||
+                  ( spellInfo_2->Id == 63611 && spellInfo_1->Id == 48266) )
+                    return true;

maybe better

+                
+                // Improved Blood Presence and Blood Presence
+                if( (spellInfo_1->Id == 48266 && spellInfo_2->Id == 63611) ||
+                  ( spellInfo_1->Id == 63611 && spellInfo_2->Id == 48266) )
+                    return true;

?

[laise]

I can't understand why you make a same check

+                
+                // Improved Blood Presence and Blood Presence
+                if( (spellInfo_1->Id == 48266 && spellInfo_2->Id == 63611) ||
+                  ( spellInfo_2->Id == 63611 && spellInfo_1->Id == 48266) )
+                    return true;

maybe better

+                
+                // Improved Blood Presence and Blood Presence
+                if( (spellInfo_1->Id == 48266 && spellInfo_2->Id == 63611) ||
+                  ( spellInfo_1->Id == 63611 && spellInfo_2->Id == 48266) )
+                    return true;

?

yeah..sorry .. idk if this part even needed cause the may replace each other anyway

[Wojta]

bump bump

[KriM]

please update for the new rev=)

[laise]

please update for the new rev=)

what exactly doesn't work/compile with new rev?

[KAPATEJIb]

http://github.com/insider42/mangos/commit/f974e3b7ab19693b417905bfc5c38142e19763ed

[Mathman]

dead link KAPATEJIB

New of this bug?

[VladimirMangos]

I think implementation in overhard way and create additional problems.

Bonuses expected to be applied while Presence active from start and removed at expire.I not see remove part.

In general use for like aura bonuses spell proc handlers wrong. You need sql, you need handler code, you need remove aura code.

Instead binus auras must be added in to Aura::HandleSpellSpecificBoosts specially created for like cases when some bonus with additional requirement applied at first main auras apply and removed at last main aura remove. This lot more easy way: you not need adding sql data, you have all checks in single place.

[laise]

updated for 9457

http://pastebin.com/2yMNbcqE

sql:

-- (48266) Blood Presence ()
DELETE FROM `spell_proc_event` WHERE `entry` IN (48266);
INSERT INTO `spell_proc_event` VALUES
(48266, 0x00, 0, 0x00000000, 0x00000000, 0x00000000, 0x00050014, 0x00010000, 0.000000, 0.000000, 0);

-- (63611) Improved Blood Presence ()
DELETE FROM `spell_proc_event` WHERE `entry` IN (63611);
INSERT INTO `spell_proc_event` VALUES
(63611, 0x00, 0, 0x00000000, 0x00000000, 0x00000000, 0x00050014, 0x00010000, 0.000000, 0.000000, 0);

[Mathman]

Thank you laise

[VladimirMangos]

Please, not use http://pastebin.com. It sometime corrupt patch strcuture as in last posted version case. Exist more safe services: github.com gists or http://www.paste2.org/ (but down currently) or http://pastebin.ca/

[added]I will add more commment, because patch big

triggered_spell_id = 53168;

Must be

triggered_spell_id = 50475;

[VladimirMangos]

Added to [9482] in rewrited form. Thank you