[patch][8875] Lava Burst

[KAPATEJIb]

What bug does the patch fix? What features does the patch add?

Fixed removing fire shocks by Lava Burst (according 3.2.x patches changes)

For which repository revision was the patch created?

8765+

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Didn't find any

Who has been writing this patch? Please include either forum user names or email addresses.

Me

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index ac5f15d..19ae6ba 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -8690,12 +8690,7 @@ bool Unit::isSpellCrit(Unit *pVictim, SpellEntry const *spellProto, SpellSchoolM
                        if (spellProto->SpellFamilyFlags & UI64LIT(0x0000100000000000))
                        {
                            if (Aura *flameShock = pVictim->GetAura(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_SHAMAN, UI64LIT(0x0000000010000000), 0, GetGUID()))
-                            {
-                                // Consume shock aura if not have Glyph of Flame Shock
-                                if (!GetAura(55447, 0))
-                                    pVictim->RemoveAurasByCasterSpell(flameShock->GetId(), GetGUID());
                                return true;
-                            }
                        }
                        break;
                }

[bulek]

bump pls add to rev ,this patch working correctly:)

[Anti]

I think here is more right way, cauze we don't need here case for shamy.

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 166cbaa..cc4e581 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -8685,19 +8685,6 @@ bool Unit::isSpellCrit(Unit *pVictim, SpellEntry const *spellProto, SpellSchoolM
                                return true;
                        }
                        break;
-                    case SPELLFAMILY_SHAMAN:
-                        // Lava Burst
-                        if (spellProto->SpellFamilyFlags & UI64LIT(0x0000100000000000))
-                        {
-                            if (Aura *flameShock = pVictim->GetAura(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_SHAMAN, UI64LIT(0x0000000010000000), 0, GetGUID()))
-                            {
-                                // Consume shock aura if not have Glyph of Flame Shock
-                                if (!GetAura(55447, 0))
-                                    pVictim->RemoveAurasByCasterSpell(flameShock->GetId(), GetGUID());
-                                return true;
-                            }
-                        }
-                        break;
                }
            }
            break;

[KAPATEJIb]

You are wrong, spell should deal a critical hit if target under effect of Flame shock

[Anti]

You are wrong, spell should deal a critical hit if target under effect of Flame shock

oh, sry. i didn't seen

return true;

in that way your fix is correct

[Micks]

What bug does the patch fix? What features does the patch add?

Fixed removing fire shocks by Lava Burst (according 3.2.x patches changes)

For which repository revision was the patch created?

8765+

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

Didn't find any

Who has been writing this patch? Please include either forum user names or email addresses.

Me

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index ac5f15d..19ae6ba 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -8690,12 +8690,7 @@ bool Unit::isSpellCrit(Unit *pVictim, SpellEntry const *spellProto, SpellSchoolM
                        if (spellProto->SpellFamilyFlags & UI64LIT(0x0000100000000000))
                        {
                            if (Aura *flameShock = pVictim->GetAura(SPELL_AURA_PERIODIC_DAMAGE, SPELLFAMILY_SHAMAN, UI64LIT(0x0000000010000000), 0, GetGUID()))
-                            {
-                                // Consume shock aura if not have Glyph of Flame Shock
-                                if (!GetAura(55447, 0))
-                                    pVictim->RemoveAurasByCasterSpell(flameShock->GetId(), GetGUID());
                                return true;
-                            }
                        }
                        break;
                }

I'm using in 8866 and works with no problem.

[VladimirMangos]

In [8875]. Thank you