[9910][patch] Warsong Gulch 25 minutes limit

[LordJZ]

According to changes in Patch 3.2, Warsong Gluch battle is now limited to 20 minutes (it morphed into 25 minutes on live). Quoting official patch notes:

There is a now a 20-minute timer on this Battleground. After that time, the team with the most flag captures wins. If this would result in a tie, the team that captured the first flag wins. If neither side has captured a flag, then the game ends in a tie.

A little time after, a hotfix had been applied to change

If this would result in a tie, the team that captured the first flag wins.

To

If this would result in a tie, the team that captured the last flag wins.

(corrected version of 3.2 change can be found here)

Full tested patch containing all hotfixes and changes: http://paste2.org/p/563471

___________

A little more explanations on my solution to new variables.

m_EndTimer is probably named bad (because of existing m_EndTime used to announce when the battleground will be shutdowned after actual BG end)

m_LastCapturedFlagTeam used to determine which side captured the flag last.

m_LastEndTimeMinutes used to calculate WorldStateUpdate time. Though it is not really needed, it decided to create a variable instead of forcing calculations on every update tick to determine whether or not announce World States.

[TOM_RUS]

There's also message like "Time is over!" (exact message unknown, because i'm playing on Russian realms) at the end of battleground in this case.

[darkstalker]

you doing integer division here then casting to float, decimal data is already lost

uint32 GetEndTimeMinutes() { return ceil(float(m_EndTimer / MINUTE / IN_MILISECONDS)); }

so its better to do:

uint32 GetEndTimeMinutes() { return ceil(float(m_EndTimer) / (MINUTE * IN_MILISECONDS)); }

[balrok]

hello, good to see

the m_endtimer is ok i think.. at least i have no idea for a better name

+ uint32 h = GetTeamScore(HORDE);

+ uint32 a = GetTeamScore(ALLIANCE);

should be avoided, please use meaningful variablenames or maybe just replace the variables by the functioncalls

and we can avoid the variable LastEndTimeMinutes

           uint32 old_minutes = GetEndTimeMinutes() ;
           m_EndTimer -= diff;
           if(GetEndTimeMinutes()  != old_minutes)
...

also i would write:

return m_EndTimer / (MINUTE * IN_MILISECONDS);

or is ceiling the result really needed?

i think it's possible to use ceil also on plain integer division without casting it to float first

edit: if (m_EndTimer > 0) should be

if (m_EndTimer - diff > 0)

else it will get negative

[darkstalker]

ceil rounds up the number, meaningless to use on an integer value

i think he uses ceil to only return 0 value when its effectively 0 (not rounded down)

[bulek]

bump sound good

works with 900x mangos?

edit by balrok: no bumping after ONE day.. also you could just read everything in the thread to find out more about this..

[pyrite]

Work this patch?

[danielich]

Work this patch?

You can test it, mr. Pyrite

Ok. i will test for you jajaja

Saludos!

[Raynar]

works but a little unestable (mangos 9110)

[zergtmn]

Updated for r. 9798. Also fixed timer displaying

http://paste2.org/p/796684

[Unkle Nuke]

Thank you for this update. My play testers have only recently discovered the fun of battlegrounds. Any BG fixes will make you much loved by them. lol

[Vantoo]

Please bear in mind that while both teams have the flag of the opposing team, after 10 minutes without a Flag return or capture, Flag Carrying PCs should be recieving the debuff Focused Assault (#46392), and after 15 minutes they should be recieving the debuff Brutal Assault (#46393). This information can be found in the "General Info" point-section on the WoW site.

Without the inclusion of these debuffs, I fear that many WSG matches will end at 0-0 under a 25m timer.

[Unkle Nuke]

I know this requires a few more case statements and conditional loops. But exactly how to add those debuffs is beyond my reach. I do hope it can be included into the next update. Until then, I think I'll hold off on adding this patch or I may have some torch-wielding BG players knocking at my Admin toon's citadel gates! lol

[VladimirMangos]

return m_EndTimer / (MINUTE * IN_MILISECONDS);

If we want have number full or partly pass minutes then need more code but float better avoid

For example (base at fact that timer can't be < 0:

uint32 GetRemainingTimeInMinutes() { return m_EndTimer ? (m_EndTimer-1) / (MINUTE * IN_MILLISECONDS) + 1 : 0; }

[VladimirMangos]

With this change and also update to new way set world states in [9910]

Thank you