[Question] Spells with same icon

[Delor]

Hello,

why are spells with same icons replacing each other? Spell IDs are different, so it seems that mangos check only icon, not IDs. Why?

[laise]

   // more generic checks
   if (spellInfo_1->SpellIconID == spellInfo_2->SpellIconID &&
       spellInfo_1->SpellIconID != 0 && spellInfo_2->SpellIconID != 0)
   {
       bool isModifier = false;
       for (int i = 0; i < 3; ++i)
       {
           if (spellInfo_1->EffectApplyAuraName[i] == SPELL_AURA_ADD_FLAT_MODIFIER ||
               spellInfo_1->EffectApplyAuraName[i] == SPELL_AURA_ADD_PCT_MODIFIER  ||
               spellInfo_2->EffectApplyAuraName[i] == SPELL_AURA_ADD_FLAT_MODIFIER ||
               spellInfo_2->EffectApplyAuraName[i] == SPELL_AURA_ADD_PCT_MODIFIER )
               isModifier = true;
       }

       if (!isModifier)
           return true;
   }

in isNoStackSpellDueToSpell..anyway there was patch for spell stacking somewhere under review

[Lynx3d]

If you have the ultimate check that covers all spells and doesn't produce false positives, please let us know

Spell IDs themselves don't get you anywhere, you sure don't want to create a 50k x 50k matrix of spell-pairs...