[Revision 9702]Bugged items

[shinra]

Okay as of the new update If you try and add for example item 43516 then use it, It wont teach you a neather drake mount as it should, it will teach you a glyph instead.

This has happened as of the latest path.

[The_Game_Master]

I can confirm this.

[shinra]

All my players are saying all items that teach you something are now bugged.

[The_Game_Master]

Forgot to mention that all items are now red -> 0 durability.

[heugabel]

ALL ID´s now calculating "-1" pleache check this...@Devs please FIX IT

[attentat]

All Spell IDs that will get teached, example: 61230 (Armored Blue Wind Rider) will teach 61229 (Armored Snowy Gryphon)

That won't be a big problem but such like 60021 (Plagued Proto-Drake) will teach 60020 (Freezing Cloud - Deals 5000 Frost damage immediately and 2500 Frost damage per sec. afterwards. Lasts 10 sec.)

And something like above would end up in ppl exploiting...

[The_Game_Master]

This is bad, very very bad.

[VladimirMangos]

spells part fixed in [9701]

durability related absend porper item data conversion at client switch. But it cirrupt only current durability so not nice, bit not so critical. Item 'data' field have same size but small values offset in tail.

That why impossible write safe fix quary working _after_ switch and some time use. Just impossible sort items by old and new.

[The_Game_Master]

Ok, thanks for explaining the durability problem.

You're saying that rev 9701 broken the items learn spells?

[Voldemmort]

Also my testers are saying that when they use the offhand weapon, it is not counting in their base stats like AP or base damage.

Also you say the items was fixed in 9701, but I'm using 9702 and there are some problems still with some items that cast spells like for example:

http://www.wowhead.com/item=47100

http://www.wowhead.com/item=8631

http://www.wowhead.com/item=8629

[The_Game_Master]

BUMP! Need some help here.

[Xfurry]

Confirmed! This happened to me too. Please find a solution to this!

[The_Game_Master]

The problem appeared in 9701, not 9702, just tested to make sure.

I'm not an expert, but maybe this cause the problem?

    float basePointsPerLevel = spellProto->EffectRealPointsPerLevel[effect_index];
-    int32 basePoints = int32(effBasePoints + level * basePointsPerLevel);
+    int32 basePoints = effBasePoints ? *effBasePoints - 1 : spellProto->EffectBasePoints[effect_index];
+    basePoints += int32(level * basePointsPerLevel);
    int32 randomPoints = int32(spellProto->EffectDieSides[effect_index]);
    float comboDamage = spellProto->EffectPointsPerComboPoint[effect_index];

Looks like i was right,

chaning that to,

    int32 basePoints = effBasePoints ? *effBasePoints /*- 1*/ : spellProto->EffectBasePoints[effect_index];
   basePoints += int32(level * basePointsPerLevel);

solved the problem.

But this is not the proper way to fix it.

[laise]

should be fixed in [9709]

[Voldemmort]

Thanks Laise.

Do you know if there is any way to erase the spells that some players learn due to this bug??

[NuRRi]

Perhaps there should be added a sql to remove all this "exploit spells" that some users have now like Freezing Cloud?

[hellrazor]

Ye, is there any SQL or something that can remove the spells they learned?

[Schmoozerd]

I think this cannot be handled so easily, because there are many spells which are valid, yet taught wrong (ie the menctioned wrong colored mounts)

So I think every admin will have to take the bite and compare the characters' spells with a backup and modify if needed

[hellrazor]

dam i hope it works with an SQL or something lol

[Shyke]

As of the latest revision, this is NOT fixed.

Testers still learn illegit spells when they use mounts and enchanting.

[laise]

As of the latest revision, this is NOT fixed.

Testers still learn illegit spells when they use mounts and enchanting.

what spells and exact number of revision

[Shyke]

what spells and exact number of revision

It seems that I was incorrect as of 9709.

I am working on SQL queries to undo the damage. So far the SQL to undo Mount damage is done. Damage done by profession formulae, patterns, etc still exists.

[Shyke]

I apologize for double posting but I felt that my contribution would warrent it.

I have generated a list of queries that will undo all of the damage done by this bug. It is presently untested but it covers all professions and mounts, deleting the spell that it was intended to teach plus one.

I'll be testing this shortly.

[shinra]

Thanks for fixing in latest rev.

[Shyke]

I appear to be incorrect in my research and wish that a moderator would remove the link I posted in my previous post (I don't want people running code that is incorrect).

It appears to be that the bug is the spellid - 1.