Jump to content

[Fix] Spells with same Icons

Auntie Mangos

Recommended Posts

What bug does the patch fix? What features does the patch add?

Now spells with the same icons don't replace each other.

For which repository revision was the patch created?

s0733 :) but it works on higher revisions too

Is there a thread in the bug report section or at lighthouse?


Who has been writing this patch? Please include either forum user names or email addresses.


diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index c48e40c..30646ac 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -1976,10 +1977,13 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons
        bool isModifier = false;
        for (int i = 0; i < MAX_EFFECT_INDEX; ++i)
-            if (spellInfo_1->EffectApplyAuraName[i] == SPELL_AURA_ADD_FLAT_MODIFIER ||
+            if ((spellInfo_1->EffectApplyAuraName[i] == SPELL_AURA_ADD_FLAT_MODIFIER ||
                spellInfo_1->EffectApplyAuraName[i] == SPELL_AURA_ADD_PCT_MODIFIER  ||
                spellInfo_2->EffectApplyAuraName[i] == SPELL_AURA_ADD_FLAT_MODIFIER ||
-                spellInfo_2->EffectApplyAuraName[i] == SPELL_AURA_ADD_PCT_MODIFIER )
+                spellInfo_2->EffectApplyAuraName[i] == SPELL_AURA_ADD_PCT_MODIFIER ) ||
+               (spellInfo_1->EffectApplyAuraName[i] != spellInfo_2->EffectApplyAuraName[i] ||
+                spellInfo_1->Effect[i] != spellInfo_2->Effect[i]))
                isModifier = true;

Link to comment
Share on other sites

  • 40 years later...

okay, but some spell don't work together at time, for example:

IconID: 453




Icon: 173



and many more...

And i checked the problem with Scroll of intellect and Arcane intellect and some more, and it works fine :)

My script is only an extra check for incoming spells

Link to comment
Share on other sites

  • 2 months later...
  • 2 months later...
  • 5 months later...
  • 3 weeks later...
This topic is now closed to further replies.
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use