[FIX]Commendation Badges +30% reputation

[Guest]

Revision: 9773

Patches: none

Bug-Reports: http://getmangos.eu/community/showthread.php?12683-%5BBUG%5D-Argent-Crusade-Commendation-Badge-spell-61311

Bug: the commendation badges in wintergrasp shoul gain reputation by 520points not only 400. this is the patch, maybe its just a hack in your opinion, but I didn't find another way to handle it in a more generic way

author: me

patch:

diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp
index 43c1ccd..86b6cf5 100644
--- a/src/game/SpellEffects.cpp
+++ b/src/game/SpellEffects.cpp
@@ -6704,6 +6704,16 @@ void Spell::EffectReputation(SpellEffectIndex eff_idx)
  int32 rep_change = m_currentBasePoints[eff_idx];

  uint32 faction_id = m_spellInfo->EffectMiscValue[eff_idx];
+  switch(m_spellInfo->Id)
+  {
+    case 69757:
+    case 61311:
+    case 61308:
+    case 61306: 
+    case 61312:
+      rep_change *= 1.3;
+      break;
+  }

  FactionEntry const* factionEntry = sFactionStore.LookupEntry(faction_id);

[sinaka]

*bump* is it complete wrong done? or did just no one read it ^^

[Ceris]

I think that this must be handled by some generic way, because ALL reputation gains for some Northrend factions has been increased by 30%, not only this badges.

[darkstalker]

adjust server rates?

[Micks]

the item http://www.wowhead.com/item=44713 still casting http://www.wowhead.com/spell=61312 and applying only 400 rep with Ebon Blade

obs* not tested the patch, just confirmed the bug

[Br3Ak3R]

just tested, and working

big thanks

[Lynx3d]

Fixed now in [10327] in more generic way with new reputation_reward_rate DB table.

Also Argent Dawn Valor Tokens were affected by missing "hidden" rates.