[9811] [FIX] Shadowflame Stack

[Most_Mangos]

What bug does the patch fix? What features does the patch add?

This patch will correct a problem stack Warlock Shadowflame with other Affliction dots.

For which repository revision was the patch created?

[9812]

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

I didn't find thread with this problem.

Who has been writing this patch? Please include either forum user names or email addresses.

Me (Most_Mangos)

code diff:

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index d1dd4e8..8d91d5d 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -1534,6 +1534,26 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons
                    (spellInfo_2->SpellIconID == 313 || spellInfo_2->SpellIconID == 2039) && (spellInfo_1->SpellIconID == 544  || spellInfo_1->SpellIconID == 91) )
                    return false;

+                // Shadowflame and Curse of Agony
+                if( spellInfo_1->SpellIconID == 544 && spellInfo_2->SpellIconID == 3317 ||
+                    spellInfo_2->SpellIconID == 544 && spellInfo_1->SpellIconID == 3317 )
+                    return false;
+
+               // Shadowflame and Corruption 
+                if( spellInfo_1->SpellIconID == 313 && spellInfo_2->SpellIconID == 3317 ||
+                    spellInfo_2->SpellIconID == 313 && spellInfo_1->SpellIconID == 3317 )
+                    return false;
+
+               // Shadowflame and Unstable Affliction
+                if( spellInfo_1->SpellIconID == 2039 && spellInfo_2->SpellIconID == 3317 ||
+                    spellInfo_2->SpellIconID == 2039 && spellInfo_1->SpellIconID == 3317 )
+                    return false;
+
+               // Shadowflame and Curse of Doom
+                if( spellInfo_1->SpellIconID == 91 && spellInfo_2->SpellIconID == 3317 ||
+                    spellInfo_2->SpellIconID == 91 && spellInfo_1->SpellIconID == 3317 )
+                    return false;
+
                // Metamorphosis, diff effects
                if (spellInfo_1->SpellIconID == 3314 && spellInfo_2->SpellIconID == 3314)
                    return false;

[jluis859]

it works

[darkstalker]

IsNoStackSpellDueToSpell data should be stored on a db table..

[Princess]

IsNoStackSpellDueToSpell data should be stored on a db table..

+10000

[michalpolko]

Imho this whole stacking stuff should be done from the other side, all auras should stack (except the same caster's aura) and some exceptions should be checked what shouldnt (I know only Judgements and the same area auras).

[VladimirMangos]

Yes, what michalpolko say.

Old patch exist at forum from nos4r2zod. But not finish for point when can replace existed way.

[VladimirMangos]

// Shadowflame and Corruption 

// Shadowflame and Unstable Affliction

Tested and work without patch.

Other 2 cases added in [11450]. Thank you