[fix] Everlasting Affliction

[Auntie Mangos]

What bug does the patch fix? What features does the patch add?

Now there is the possibility that Shadow Bolt and Drain Soul reset Corruption.

For which repository revision was the patch created?

10154

Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread.

http://getmangos.eu/community/showthread.php?9890-Everlasting-Affliction&highlight=Everlasting+Affliction

Who has been writing this patch? Please include either forum user names or email addresses.

me

BUG: the damage of corruption is not increased

http://paste2.org/p/905313<- the change

I think that it may be more elegant. Shorter.

I think in this direction:

if ((m_spellInfo->SpellFamilyFlags & UI64LIT(0x00004000000000)) && m_spellInfo->SpellIconID==2128)

I have no idea what this means.

Can one tell me what that means?

How can I increase damage of corruption?

I am open to a lot of advices, because it is my first real fix.

EDIT:

SQL FIX (very elegant)

UPDATE `spell_proc_event` SET `SpellFamilyMask0`='16393' WHERE (`entry`='47201')

[Maxxie]

Hi there, there is a simpler way to fix this.

You should first see how it works currently. Looking at wowhead you can see that the triggering part of spell 47422 is already there, so all you should do is just tell mangos when it should trigger. To do this you'll have to look in the mangos database in the table spell_proc_event looking for the entry of Everlasting Affliction (Rank 1) and edit it so it triggers when you cast Shadow Bolt or Drain Soul.

To do this you need to modify SpellFamilyMask0 from 8 to 16393 (which you obtain by adding SpellFamilyFlags0 value of the spells you need, in this case 1 from Shadow Bolt and 16384 from Drain Soul).

The other effect of the spell does not seem to work correctly because it uses aura SPELL_AURA_ADD_FLAT_MODIFIER instead of SPELL_AURA_ADD_PCT_MODIFIER so damage is increased by 5 instead of 5%.

Hope everything is clear

[breakwater]

thank you for your quick response

Hope everything is clear

Sry not all.

To do this you need to modify SpellFamilyMask0 from 8 to 16393 (which you obtain by adding SpellFamilyFlags0 value of the spells you need, in this case 1 from Shadow Bolt and 16384 from Drain Soul).

From where you get the numbers?

1- Shadow Bolt?

16384 - Drain Soul?

Why works Drain Life and Haunt?

I hope someone can help me.

[breakwater]

Ahhh now i know how it works.

The Numbers are from Spell.dbc

simple addition of rows 209 or 210.

Thanks Maxxie

can the update for right proc in master??

UPDATE `spell_proc_event` SET `SpellFamilyMask0`='16393' WHERE (`entry`='47201')

for Everlasting Affliction

UPDATE `spell_proc_event` SET `procEx`='67' WHERE (`entry`='58872')

for Damage Shield

UPDATE `spell_proc_event` SET `procEx`='112' WHERE (`entry`='12298')

for Shield Specialization

UPDATE `spell_proc_event` SET `procEx`='1' WHERE (`entry`='17793')

for Improved Shadow Bolt

[jluis859]

up.

Does this fix work?

I need only that Shadow Bolt and Drain Soul reset Corruption.

[amaru]

the reason that damage of corruption does not increase is because of bad data in dbc EffectClassMask

            // Everlasting Affliction
           case 47201:
           case 47202:
           case 47203:
           case 47204:
           case 47205:
           {
               spell->EffectSpellClassMaskB[0] = 2;
               spell->EffectSpellClassMaskB[1] = 256+16;
               break;
           }

[breakwater]

the complete Fix for Everlasting Affliction

take a look HERE

and the spell proc entry

DELETE FROM spell_proc_events WHERE entry = 47201;
INSTERT INTO spell_proc_events VALUES
(47201,0,5,16393,16393,16393,262144,262144,262144,0,0,0,0,65536,0,0,0);

I use this Way of Fix on my Server

[jluis859]

nice solution, can someone put it on a rev?

[amaru]

the complete Fix for Everlasting Affliction

take a look HERE

and the spell proc entry

DELETE FROM spell_proc_events WHERE entry = 47201;
INSTERT INTO spell_proc_events VALUES
(47201,0,5,16393,16393,16393,262144,262144,262144,0,0,0,0,65536,0,0,0);

I use this Way of Fix on my Server

rather ugly

[jluis859]

the complete Fix for Everlasting Affliction

take a look HERE

and the spell proc entry

DELETE FROM spell_proc_events WHERE entry = 47201;
INSTERT INTO spell_proc_events VALUES
(47201,0,5,16393,16393,16393,262144,262144,262144,0,0,0,0,65536,0,0,0);

I use this Way of Fix on my Server

This is an old table of spell_proc_event, please can someone convert this to ytdb?.

[VladimirMangos]

262144

Not so ugly if provide in _normal_ hex view. I not undestand why ppl publish mask values in ugly decimal view that make its totally unreadable.

With small changes added in [11530]. Thank you