Dont block Spell_attr_impossible_dodge_parry_block

[michalpolko]

MaNGOS revision: 10154

What does the patch fix?

Checking if a spell has attribute SPELL_ATTR_IMPOSSIBLE_DODGE_PARRY_BLOCK in IsSpellBlocked().

As a bug report: currently Overpower can be blocked (but shouldn't).

diff:

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index d56e6de..a666e38 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -2843,11 +2843,11 @@ void Unit::SendMeleeAttackStop(Unit* victim)
    ((Creature*)victim)->AI().EnterEvadeMode(this);*/
}

-bool Unit::IsSpellBlocked(Unit *pCaster, SpellEntry const * /*spellProto*/, WeaponAttackType attackType)
+bool Unit::IsSpellBlocked(Unit *pCaster, SpellEntry const *spellEntry, WeaponAttackType attackType)
{
    if (HasInArc(M_PI_F,pCaster))
    {
-        /* Currently not exist spells with ignore block
+        /*
        // Ignore combat result aura (parry/dodge check on prepare)
        AuraList const& ignore = GetAurasByType(SPELL_AURA_IGNORE_COMBAT_RESULT);
        for(AuraList::const_iterator i = ignore.begin(); i != ignore.end(); ++i)
@@ -2859,6 +2859,13 @@ bool Unit::IsSpellBlocked(Unit *pCaster, SpellEntry const * /*spellProto*/, Weap
        }
        */

+        if (spellEntry)
+        {
+            // Some spells cannot be blocked
+            if (spellEntry->Attributes & SPELL_ATTR_IMPOSSIBLE_DODGE_PARRY_BLOCK)
+                return false;
+        }
+
        // Check creatures flags_extra for disable block
        if(GetTypeId()==TYPEID_UNIT &&
           ((Creature*)this)->GetCreatureInfo()->flags_extra & CREATURE_FLAG_EXTRA_NO_BLOCK )

[MrLama]

You must uncomment SpellEntry in function variables and to check if spellEntry exists and of course change spellProto to spellEntry

[michalpolko]

right! I must have posted wrong diff. updated.

[michalpolko]

bump easy to review fix..

[goodbadguy]

Does this fix that Paladin Judgments are currently able to be blocked,dodged and parried?

[michalpolko]

In dbc they don't have this flag so: no, this doesn't fix that issue. This fixes, for example, Overpower.

[Ceris]

Does this fix that Paladin Judgments are currently able to be blocked,dodged and parried?

for this issue, there is special spell

http://www.wowhead.com/spell=60091

add it to playercreateinfo_spell for paladins and your problem will be solved

[VladimirMangos]

In [10703]. Thank you