[fixed][10337] .learn command crashing the server

[Auntie Mangos]

In rev.10342 when doing the following command will crash the server also

send items username "title" "content" 22502 22503 22498 22501 22497 22496 22500 22499 23062

confirmed! in rev 10342

http://getmangos.eu/community/viewtopic.php?id=14931&p=121909#post121909

[MysteriousSouL]

on latest revision [10337] whenever i use .learn command for any spell it is crashing the server

Revision: 2010-08-10 02:38:48 10337 73500d21698698794b2000875d4531296041215d
//=====================================================

Exception code: C0000005 ACCESS_VIOLATION
Registers:
EAX:00000000
EBX:F1714000
ECX:00000000
EDX:FBC84000
ESI:0851FDA0
EDI:00003C06
CS:EIP:0023:0077478F
SS:ESP:002B:0851EC9C  EBP:0851ECE0
DS:002B  ES:002B  FS:0053  GS:002B
Flags:00010246

Call stack:
Address   Frame     Function      SourceFile
0077478F  00000000  ChatHandler::HandleLearnCommand+9F
0056951D  00000000  ChatHandler::ExecuteCommand+DD
005697E9  00000000  ChatHandler::ParseCommands+109
007BF631  00000000  WorldSession::HandleMessagechatOpcode+2A1
005E8671  00000000  WorldSession::ExecuteOpcode+21
005ECE8B  00000000  WorldSession::Update+CB
004736B1  00000000  World::UpdateSessions+61
004751E4  00000000  World::Update+124
00446374  00000000  WorldRunnable::run+64
004550E4  00000000  ACE_Based::Thread::ThreadTask+34
759C5B04  00000000  ACE_OS_Thread_Adapter::invoke+74
7549C6DE  00000000  _endthreadex+3A
7549C788  00000000  _endthreadex+E4
75FEE3F3  00000000  BaseThreadInitThunk+E
77D4CFED  00000000  RtlCreateUserProcess+8C
77D4D1FF  00000000  RtlCreateProcessParameters+4E
========================
Local Variables And Parameters

Call stack:
Address   Frame     Function      SourceFile
0077478F  00000000  ChatHandler::HandleLearnCommand+9F
punting on symbol args
punting on symbol allRanks

0056951D  00000000  ChatHandler::ExecuteCommand+DD
   Local  <user defined> 'text'
   Local  <user defined> 'parentCommand'
   Local  <user defined> 'fullcmd'
   Local  <user defined> 'command'
   Local  <user defined> 'sel_guid'

005697E9  00000000  ChatHandler::ParseCommands+109
   Local  <user defined> 'text'
   Local  <user defined> 'st'
   Local  <user defined> 'st'

007BF631  00000000  WorldSession::HandleMessagechatOpcode+2A1
   Local  <user defined> 'recv_data'
punting on symbol type
punting on symbol lang
   Local  <user defined> 'timeStr'
   Local  <user defined> 'msg'
punting on symbol tSecurity
   Local  <user defined> 'msg'
   Local  <user defined> 'to'
   Local  <user defined> 'data'
   Local  <user defined> 'msg'
   Local  <user defined> 'msg'
   Local  <user defined> 'msg'
   Local  <user defined> 'data'
   Local  <user defined> 'msg'
   Local  <user defined> 'data'
   Local  <user defined> 'msg'
   Local  <user defined> 'data'
   Local  <user defined> 'msg'
   Local  <user defined> 'data'
   Local  <user defined> 'msg'
   Local  <user defined> 'data'
   Local  <user defined> 'msg'
   Local  <user defined> 'channel'
   Local  <user defined> 'msg'
   Local  <user defined> 'msg'
   Local  <user defined> 'msg'

005E8671  00000000  WorldSession::ExecuteOpcode+21
   Local  <user defined> 'opHandle'
   Local  <user defined> 'packet'

005ECE8B  00000000  WorldSession::Update+CB
punting on symbol __formal
   Local  <user defined> 'packet'

004736B1  00000000  World::UpdateSessions+61
punting on symbol diff
   Local  <user defined> 'sess'
   Local  <user defined> 'next'

004751E4  00000000  World::Update+124
punting on symbol diff
punting on symbol maxClientsNum

00446374  00000000  WorldRunnable::run+64
punting on symbol prevSleepTime

004550E4  00000000  ACE_Based::Thread::ThreadTask+34
punting on symbol param

759C5B04  00000000  ACE_OS_Thread_Adapter::invoke+74
punting on symbol status

7549C6DE  00000000  _endthreadex+3A

7549C788  00000000  _endthreadex+E4

75FEE3F3  00000000  BaseThreadInitThunk+E

77D4CFED  00000000  RtlCreateUserProcess+8C

77D4D1FF  00000000  RtlCreateProcessParameters+4E

========================
Global Variables

[XdK]

Same problem here. Clean mangos & every .learn crashes server.

Debbuger says:

    bool allRanks = ExtractLiteralArg(&args, "all") != NULL;
   if (!allRanks && *args)                                 // can be fail also at syntax error   <----------------------------------------- HERE HERE HERE
       return false;

In HandleLearnCommand

[VladimirMangos]

Your report absent most important part: example tested command...

I am for example can't reproduce crash

You can include or skip own generic conclusions and etc but if you make report you must if possible provide _exactly_ way for repeat problem.

Because as always conclusions about _all_ something heppen (.learn command use crash always) proved as wrong just by random test.

So better provide exactly tested data instead conclusions.

[added]

Ok, i find way repeat, but as i say this not all cases, but specific. So all what i write about still good recommendation for reports.

More checked info and only optional conclusions as addition.

[darkstalker]

maybe "args" is null or outside array after ExtractLiteralArg call

[VladimirMangos]

yes, this is cleary see at proper test, but problem has been in absent this test

I will fix this case and look similar cases.

[VladimirMangos]

Must be fixed in [10340].

[MysteriousSouL]

thanks it is working perfect now

[ckegg]

In rev.10342 when doing the following command will crash the server also

send items username "title" "content" 22502 22503 22498 22501 22497 22496 22500 22499 23062

[Atømic]

Thank's for debug !

[VladimirMangos]

Thank you for reporting. Fixed in [10346].

[shinra]

Thank you yet again VladimirMangos

[ckegg]

-- nevermind VladimirMangos fixed problem on 10831