Unknown pets

[Auntie Mangos]

Now in right forum part

Mangos Version: 10500+

Custom Patches: many, but nothing with pets

SD2 Version:

How it SHOULD work:

If a player teleport into BG, Arena, instance or anywhere, your pet should have a name.

How it DOES work:

If a player teleport into BG, Arena, instance or anywhere, your pet has NO name. The pet is unknow. After a WoW restart the pet has a name.

A huge bug with this problem is, that the fightlog also will be buggy, because the pet has no name^^

In this forum part some thoughts.

http://getmangos.eu/community/viewtopic.php?id=14049

Thanks for your work to fix this bug

[Darky88]

src/game/PetHandler.cpp

{
    Creature* pet = _player->GetMap()->GetAnyTypeCreature(petguid);
    if(!pet || !pet->GetCharmInfo() || pet->GetCharmInfo()->GetPetNumber() != petnumber)
+    {
+        WorldPacket data(SMSG_PET_NAME_QUERY_RESPONSE, (4+1));
+        data << uint32(petnumber);
+        data << uint8(0);
+        _player->GetSession()->SendPacket(&data);
        return;
+    }

    std::string name = pet->GetName();

by nos4r2zod (extract of KAPATEJIb repo).

[breakwater]

At first, thank you for fast answer

Can someone explain this fix? I don't understand. Is this a hack? Why not in master?

[darkstalker]

At first sight seems to send some kind of "pet not found" response to client, so it tries to get correct one. Not sending this might break an asynchronous query/response chain client side, and as result you get an "unknown" pet.

[michalpolko]

Unknown also appears in situations where a unit (not only pet) is summoned with other phaseMask then player's and when that player changes it's phaseMask to the unit's phaseMask then it is unknown.

I hope You understand me

[Forusim]

Pets still gets unknown after getting killed respawned =/

Any idea?

[darkstalker]

it works for me

[Revils]

me too, and it totally solved the problem with combat log no more working

[SilverIce]

As i can see - fix works, even with incorrect structure of empty pet name query packet