Sticky morph effects :)

[Nevyn]

Hi

When you have Halloween morph effects (e.g. "Bat Costume") you can't remove the effect by right clicking on the icon... and for a lot of time you can't cast and doing some of other actions.

Wonderful "Trick or Treat"

Sever log says:

Aura::TriggerSpell: Spell 28114 have 0 in EffectTriggered[0], not handled custom case?

PSDB WotLK (r340) for 3.3.5a (Core r10629 / SD2 r1845)

Thx

[herrtrigger]

Getting hit by an enemy removes the effect though.

[Lascax]

Also some spells like Ice Block remove this aura.

[darkstalker]

is it displayed as debuff?

[Edder]

you can't cast and doing some of other actions.

Thats right:

Cannot cast spells while in bat form. Right-Click this icon to remove the effect.

But you should be able to remove it...

is it displayed as debuff?

It is.

[Schmoozerd]

perhaps add overwrite to IsFriendlySpell by Id?

[darkstalker]

thats the problem then, must be set as positive buff

[Revils]

spell 24732 second effect uses SPELL_AURA_MOD_SILENCE that is always considered negative in IsPositiveEffect() so no other way than add a ugly exception in that function.

[Edder]

than add a ugly exception in that function.

It isnt that ugly, cause there are already a few of them, anyway:

 src/game/SpellMgr.cpp |    7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index 5aa713f..401f020 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -747,6 +747,13 @@ bool IsPositiveEffect(uint32 spellId, SpellEffectIndex effIndex)
                    return false;
                case SPELL_AURA_MOD_ROOT:
                case SPELL_AURA_MOD_SILENCE:
+					switch(spellproto->Id)
+                    {
+                        case 24732:                         // Bat Costume
+                            return true;
+                        default: break;
+                    }
+                    return false;
                case SPELL_AURA_GHOST:
                case SPELL_AURA_PERIODIC_LEECH:
                case SPELL_AURA_MOD_STALKED:

[Revils]

than add a ugly exception in that function.

It isnt that ugly, cause there are already a few of them, anyway:

I know, I mean that to add an hardcode value rather than a "rule" is a bit ugly but for this case an execption as you posted it's the only way I can imagine to solve this and other similar problems with other spells

[Edder]

Or do a complete rewrite, where every spell thats casted on groupmembers (in this case it only works on grpmembers) is a positive effect even if its silencing...

But this isnt necessary I think, a few exceptions are ok when they're commented and its clear what they do.