[Patch][0.12] prevented that buffs and debuffs use levelcalculation

[Hundekuchen]

I found out that some spell of creature buffs and debuffs use the level calculation of players and because of that there basepoints are very very high.

Here my testing examples:

http://www.wowhead.com/spell=33967

http://www.wowhead.com/spell=36576

http://www.wowhead.com/spell=32918

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 5ca3033..b4c30f2 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -9375,6 +9418,11 @@ int32 Unit::CalculateSpellDamage(Unit const* target, SpellEntry const* spellProt
        }
    }

+    // buffs and debuffs not need a extra calculation
+    for(uint8 i = 0; i < MAX_EFFECT_INDEX; ++i)
+        if(spellProto->Effect[i] == SPELL_EFFECT_APPLY_AURA)
+            return value;
+
    if(spellProto->Attributes & SPELL_ATTR_LEVEL_DAMAGE_CALCULATION && spellProto->spellLevel &&
            spellProto->Effect[effect_index] != SPELL_EFFECT_WEAPON_PERCENT_DAMAGE &&
            spellProto->Effect[effect_index] != SPELL_EFFECT_KNOCK_BACK &&

i hope i have fix it on the right position^^

best regards

Hundekuchen

[DaC]

Well, nice to see those spells fixed!

Thanks!

[VladimirMangos]

I have small worry that some spells for creatures can be level dependent fro diff difficulty for example..

Not have any fact that this real in fact.

[Hundekuchen]

Yes have found some I change the code if I have Time

[Hundekuchen]

/updated

[Hundekuchen]

bump

[kbz]

i think i read somewhere in the log-in tips that creatures cannot crit with spells and abilities

[Hundekuchen]

I'm sure that raid bosses can't. normal creatures probably are the same

Yes that is right, but my patch is not about crit its about false calculation of the damage value from some debuffs and buffs.

[VladimirMangos]

spam about crits dropped.

[DaC]

Disables DamageCalculation for spells wich should have it.

e.g. Spell 29098 with Aura SPELL_AURA_PERIODIC_LEECH.