[patch] Delay item destroy at GO opening

[jolan]

What bug does the patch fix? What features does the patch add?

Fix non-lootable GOs by delaying cast item destroy

For which SubVersion revision was the patch created?

7b640b3a4a0dc6208365c3d01a54ecc85feb2973

Is there a thread in the bug report section? If yes, please add a link to the thread.

didn't find any

Note:

I don't know if this is an open door for cast item duplication hacks. item is destroyed at DoLootRelease(). if a player is able to bypass this function, then he can loot and keep the cast item.

- loot release is triggered by LogoutPlayer() , is it called when a player disconnect ?

- a player can't trade an item when looting, but perhaps he can manipulate client-server protocol to filter CMSG_LOOT_RELEASE and then trade the cast item before releasing.

patch : http://pastebin.ca/1246608

[Sephiroth1983]

So this will fix those GOs which sometimes don't open but eat up the reagent/key, like Darkspire Ore Chest?

Thanks.

[Tassader2]

So this will fix those GOs which sometimes don't open but eat up the reagent/key, like Darkspire Ore Chest?

Darkspine Ore Chest (and maybe all other chests containing only quest items) are lootable if player has turned autoloot on (or open chest with pressed Shift)

Is that bypassing DoLootRelease() function ?

[jolan]

this patch does resolve those problems. in fact the lootlist is sent to the client but as soon as the cast item is removed, the client sends CMSG_LOOT_RELEASE so you dont see it. autolooting works by triggering loot of every item as soon as the GO opens.

[AandD]

And how we we can know if go is looted?

[jolan]

the client sends CMSG_LOOT_RELEASE when he closes the loot window / he loots the last item

[The_Game_Master]

If this fixes the WPE Pro problems, i'll make you a statue.

[jolan]

well, this one will add a WPE Pro problem ...

cheaters would be able to duplicate the cast item I think

[The_Game_Master]

Then add a condition for the cast item.