[Freeze] Vmap with fishing bobber

[Janu]

Hey guys,

I have noticed in our logs that in some case server freezes with vmaps. This seems to happen if player is fishing and disconnects from the server.

Crash-/Freeze-Log:

http://pastebin.com/raw.php?i=igTxekHr

You can notice these lines:

2011-03-28 18:05:20 ERROR:Delete Gameobject (Entry: 35591 Guid: 2502431) with SpellId 7731 LinkedGO 0 that lost references to owner Player Xearo (Guid: 54725) GO list. Crash possible later.

2011-03-28 18:07:38 ERROR:World Thread hangs, kicking out server!

And in Char.log:

2011-03-28 18:05:20 Account: 32121 (IP: 217.88.161.167) Logout Character:[Xearo] (guid: 54725)

Yes I have custom patches, but nothing concerning this or especially fishing/vmaps.

Because of this I will post the targeting line in Crash-Log:

  7 Thread 0x7fffc2ca3910 (LWP 32197)  MaNGOS::NearUsedPosDo::add (v=..., 
   c=<value optimised out>)
   at /home/mangos/source/mangos/src/game/Object.cpp:1888

void WorldObject::GetNearPoint(WorldObject const* searcher, float &x, float &y, float &z, float searcher_bounding_radius, float distance2d, float absAngle) const
{
   GetNearPoint2D(x, y, distance2d+searcher_bounding_radius, absAngle);
   z = GetPositionZ();

   // if detection disabled, return first point
   if(!sWorld.getConfig(CONFIG_BOOL_DETECT_POS_COLLISION))
   {
       if (searcher)
           searcher->UpdateAllowedPositionZ(x,y,z);        // update to LOS height if available
       else
           UpdateGroundPositionZ(x,y,z);  <<<<<<<<<<<<<<< FREEZE
       return;
   }

   // or remember first point
   float first_x = x;
   float first_y = y;
   bool first_los_conflict = false;                        // first point LOS problems

PS: Hm.. In my case DetectPosCollision = 1.. So i do not really understand how server can crash here. Maybe this codeblock above does not show the correct line where the freeze occurs

I hope this helps

Thanks and Regards

Janu

[voidx]

+1 i have this crashes too

[Undergarun]

+1

[Janu]

Hopefully fixed in [11298] by Ambal, thank you for this

Unconfirmed © Ambal

[Ambal]

Janu, are you sure this freeze has gone away? I have no possibility to check, thats why I ask

[Janu]

I had no chance to test this yet, but I am sure to have some test-results at the evening

I will post feedback then

[Ambal]

Ok, then don't forget to write your feedback once you'll be able to test this commit. Cheers

[Janu]

Tried to reproduce freezes on our Test-Server, but everything seems fine If it occurs again on our Live-Server, I will contact you. But as I said it seems fine for now

[Ambal]

Any info regarding this freeze? Is it actually fixed?

[Janu]

Got only one freeze in the last days: http://pastebin.com/raw.php?i=whEJKiqU (just ignore above table errors, was a fail of mine )

But as you can see, there is no error with fishing bobbers in log. Besides server does not freeze if you exactly try to reproduze it.

So this freeze seems to be fixed

Maybe somebody else has feedback regardings this?

[herrtrigger]

You can notice these lines:

2011-03-28 18:05:20 ERROR:Delete Gameobject (Entry: 35591 Guid: 2502431) with SpellId 7731 LinkedGO 0 that lost references to owner Player Xearo (Guid: 54725) GO list. Crash possible later.

2011-03-28 18:07:38 ERROR:World Thread hangs, kicking out server!

That log entry has been there for a long time (iirc from rev 9xxx); but never made my server crash so far:

2011-04-04 20:41:16 ERROR:Delete Gameobject (Entry: 176497 Guid: 200010) with SpellId 11416 LinkedGO 0 that lost references to owner Player Mangus (Guid: 7) GO list. Crash possible later.
2011-04-04 20:48:09 GameEvent 57 "World's End Tavern - Perry Gatner Announce" started.
2011-04-04 20:50:02 GameEvent 41 "Leader of Jin'Alai, Kutube'sa" removed.
2011-04-04 20:50:02 GameEvent 42 "Leader of Jin'Alai, Gawanil" started.
etc...

Can reproduce easy as mage: create a portal to another city, use portal, after having arrived in other city, log out and check log after some time.

Also (not worth new thread i think, just mentioning):

Mages can also easy reproduce other long present msg:

2011-04-04 20:29:08 ERROR:Item::AddToUpdateQueueOf - Item (Guid: 786797) current owner (Player Sauron (Guid: 146)) not in world!

Just conjure mana-gem, log out with gem in bags, log back in, msg appears. Gem also not-moveable in bags iirc.

(Sorry for off-topic, would have linked old post at first, but that thread seems lost.)