BUG Honor Among Thieves

[RadikalCID]

Mangos Version: 11733

Dear Mangos

I found this fix https://github.com/przemratajczak/mangos/commit/a11afd95978c154b76fce572aa073978f8dc2d4b for the rogue talent "Honor Among Thieves" but there exist an inconvinient that some hots...

Renew : http://www.wowhead.com/spell=139/

Rejuvenation : http://www.wowhead.com/spell=774

Regrowth : http://www.wowhead.com/spell=8936

Lifebloom : http://www.wowhead.com/spell=33763

Wild Growth : http://www.wowhead.com/spell=48438

Riptide : http://www.wowhead.com/spell=61295

Earthliving : http://www.wowhead.com/spell=51730

Flash of Light (only with the sacred shield of holy paladin) : http://www.wowhead.com/spell=19750

...generate an aditional combo point that shouldn't happen.

please i ask if someone can fix this pach and block those spells so that it wont give a combo point.

[Kaowru]

Greetings,

I also play on the same server and tryed that pach, but as it has been mentioned above there is a problem with the timing on heals that generate one aditional combo point you can se clearly on this video

http://www.xfire.com/video/4aa7e1/

The spell riptide gave me 1 combo point and this happened with all Hot ... Please we are very grateful.

Subtely rogues need love

[lillecarl]

Eeh.... So this patch is bugged... Then it should be discussed as WIP i suppose? Because that is no official mangos commit..

- LilleCarl

[michalpolko]

You mean that HoT ticks that crit do proc HaT and add combo point and they shouldn't?

[RadikalCID]

...Exactly, because hot NO CRITIC doesn't give combo point...

[michalpolko]

Patch 3.2.0 (2009-08-04): Periodic critical strikes now grant combo points for rogues with this talent.

http://www.wowwiki.com/Honor_Among_Thieves

[Kaowru]

Patch 3.2.0 (2009-08-04): Periodic critical strikes now grant combo points for rogues with this talent.

http://www.wowwiki.com/Honor_Among_Thieves

But the problem is that in your patch all hot "no criticals" gave 1 combo point , you can fix? please you can watch in the video at 1:00 the spell riptide gave 1 combo point and wasn't critical .... sorry for my english.

PD: this happened with all Hot "no criticals" , Can you fix it?

[michalpolko]

In sql part of the patch there is proc_ex = 0x0040002 which is periodic_positive and criticals. So try some combinations with proc flags, maybe You will find the proper flags on Your own

[carlos16]

Try with this

DELETE FROM `spell_proc_event` WHERE `entry` IN (51698); INSERT INTO `spell_proc_event` VALUES
(51698, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0x0054110, 0x0000002, 0, 0, 1);

Tested and works fine .

[michalpolko]

Procs from periodic dmg and heal on crits and on normal heal or dmg crits?

[carlos16]

Procs only on spell and normal hits crits, in the tooltip says that.

[jluis859]

tested and works also with critical heal.

[michalpolko]

Tooltip is not always telling everything on spells mechanics, it is no argument. Patch notes said that periodic crits should proc, so they should proc.