[bug] Glancing Blow (3.3.5)

[angeleyes]

I previously posted this info incorrectly at the " ... under review [Patch] Glancing Blows [1.12]" post.

However my problem with glancing blow is not with 1.12 but with 3.3.5.

Mangos Version: 12792

Custom Patches: -

SD2 Version: 2279

Database Name and Version : udb 402

How it SHOULD work: Glancing Blows should only appear 25% of the time

How it DOES work: Glancing Blows appear 40% of the time

At 3.3.5 there should be 25% of glancing blows, but there is 40% of glancing blows (which is an older value, so for 1.12 this is correct, but not for 3.3.5)

The code as it is incorporated in Mangos (3.3.5) is as follows:

// Max 40% chance to score a glancing blow against mobs that are higher level (can do only players and pets and not with ranged weapon)

if ( attType != RANGED_ATTACK &&

(GetTypeId() == TYPEID_PLAYER || ((Creature*)this)->IsPet()) &&

pVictim->GetTypeId() != TYPEID_PLAYER && !((Creature*)pVictim)->IsPet() &&

getLevel() < pVictim->GetLevelForTarget(this) )

{

// cap possible value (with bonuses > max skill)

int32 skill = attackerWeaponSkill;

int32 maxskill = attackerMaxSkillValueForLevel;

skill = (skill > maxskill) ? maxskill : skill;

tmp = (10 + 2*(victimDefenseSkill - skill)) * 100;

tmp = tmp > 4000 ? 4000 : tmp;

if (roll < (sum += tmp))

{

DEBUG_FILTER_LOG(LOG_FILTER_COMBAT, "RollMeleeOutcomeAgainst: GLANCING <%d, %d)",

sum-4000, sum);

return MELEE_HIT_GLANCING;

}

}

So according to this code glancing can be 40% maximum.

However according to http://www.wowwiki.com/Glancing_blow#Gl … low_chance it should only be 24% as of patch 3.0

Now I've had some friends wacking on dummies both on bl!zz and on our own mangos server and the results are that the friend on Bl!zz never had more than 24% glancing blows while the friend on our own mangos server had 40% glancing blows. I assume the formula used should be changed to:

tmp = (10 + (victimDefenseSkill - skill)) * 100;

which is also what is mentioned by http://www.wowwiki.com/Glancing_blow#Gl … low_chance at the post 2.1 comment.

victimDefenseSkill for a raidboss is: 83*5 = 415

skill is: 400

So in the current formula you'll get:

tmp = (10 + 2*(415 - 400)) * 100 = 4000

Where it should be:

tmp = (10 + (415-400)) * 100 = 2500

Results from testing on our mangos 3.3.5 server:

15001 Melee hits: 100%

6011 Glancing blows: 40.1%

3842 Hits: 25.6%

3412 Crits: 22.7%

1736 Misses: 11.6%

And the results from Bl!zz

[dufernst]

Already resolved, appeared to be a problem related to our fork.

[michalpolko]

Our fork also seems to have this problem, so maybe You can share the solution?

[Schmoozerd]

Revert to master.

Though I just noticed that in master we still have the cap to 40%, not sure if this should not be decreased to 25%..

[angeleyes]

Revert to master.

Though I just noticed that in master we still have the cap to 40%, not sure if this should not be decreased to 25%..

I think it should

[sart13]

Six months ago, the master had this bug. and as I recall, nothing like not repaired.

in general, the master can be considered as intercalated sample "of a spherical horse in vacuum", but none to them (in their right mind, of course) will not be used for the game ...

[dufernst]

Our fork also seems to have this problem, so maybe You can share the solution?

What Schmoozerd said: http://paste2.org/p/1780732

Though I just noticed that in master we still have the cap to 40%, not sure if this should not be decreased to 25%..

Probably yes, current tests indicate a 24-27% glancing blow chance, still seems a bit to high.

[Schmoozerd]

hey, angeleyes - as you seem to have access to retail, can you check how many glancing blows you get if you use a weapon with skill << 400 (say 300-350 at most)?

Such information is required as proof of a generic cap at 25% or at 40%

[angeleyes]

I'll ask my friend @ retail, I don't play retail myself. Thanks for follow up.

Just asked and my friend told me that at Cata there is no weaponsskill anymore.

Or did I understand you wrong?

Please elaborate.

He tells me he can take a level 50 wpn, or test with a level 60 alt.

[faramir118]

http://www.wowwiki.com/Glancing_blow - not good enough?

[Schmoozerd]

It is not perfectly clear if the tested 25% are as a result of testing with skill-level 400 against bosses (would be exactly the 25% with formula), or if these 25% are a real cap, also obtained with lower skill.

[faramir118]

Hrm, I don't think you'll find anything perfectly clear.

Best I can find is Rawr, here is a link to the last pre-cata release I can find: http://rawr.codeplex.com/SourceControl/changeset/view/53851#294974

They have a comment saying that no stat modifies glancing blow. It is possible that it was based on player weapon skill vs mob defense in wrath, but since weapon skill was removed in cata we can't test it on retail anymore.

edit:

This EJ post indicates that 1) glancing chance in wrath was 24% and 2) it didn't change in cata.