Struggling with simple C++ string loop

[antz]

I'm trying to get the following code to work, but i'm falling foul on the line

   printf("Generated %s.sql\\n",filename);

Remove this line and it runs fine, with it crashes when its empty.

I've also tried wrapping this in:-

if(!filename.empty())

Here's the main segment of code:-

   // extract DBCs
   int count = 0;
   for (std::set<std::string>::iterator iter = dbcfiles.begin(); iter != dbcfiles.end(); iter++)
   {
       std::string filename = path;
       filename += (iter->c_str() + strlen("DBFilesClient\\\\"));

       if (ExtractFile(iter->c_str(), filename))
       {
           //Generate SQL files Here
           if (CONF_generate_sql_files)
           {
   printf("Generated %s.sql\\n",filename);
           }
       }
           ++count;
   }

[faramir118_]

Sorry, you are correct! I was on my honeymooon, brain wasn't supposed to be working.

[lillecarl]

Sorry, you are correct! I was on my honeymooon, brain wasn't supposed to be working.

Y U on mangos forum then!?!?!?

[faramir118_]

Was jet-lagged, couldn't sleep

[evilatwow]

Sorry, you are correct! I was on my honeymooon, brain wasn't supposed to be working.

Hehe, no need to say sorry at all. It's so easy to make 'typo' mistakes in programming when your attention slips for a split second...

p.s. Congrats there!

[evilatwow]

Your problem is the format specifier used in printf. The %s in it tells the function that the argument is expected to be a C string, ie something of type 'const char*'. But it is not, since you pass it a C++ string, and that causes havoc as you've noticed.

Fortunately, std::string has a conversion to a C string (but you know since you use it in other place). So just change the code like this and that part will work:

 printf("Generated %s.sql\\n",filename.c_str());

[antz]

Many thanks for this, i'm tackling C++ for the first time after many years avoiding it

compared to some, my dev language progression is badly wrong

BASIC > VB3 > VB6 > Java > ASP > VB.Net > ASP.Net > C# and now C++

[fr1nge]

compared to some, my dev language progression is badly wrong

BASIC > VB3 > VB6 > Java > ASP > VB.Net > ASP.Net > C# and now C++

Not really, from my point of view is from easiest to hardest so it's a good learning curve.

OFF: Speaking of printf, why did MaNGOS choose C style deprecated error-prone output and <cstdio> instead of C++'s clean, more error-safe cout and <iostream>?

[antz]

Can give me an example of how to do

printf("Generated %s.sql\\n",filename.c_str());

the C++ way ?

[faramir118_]

#import <iostream>

...

std::cout << "Generated " << filename << ".sql" << std::endl;

To me, format strings are easier to localize than C++ streams.

[evilatwow]

#import <iostream>

In C++, that's include my dear

#include <iostream>