[ZERO] Problems with many bugs

[Dainara]

Hi, i have compilled mangoszero on debian wheezy, the database i have updated with _dev 210 and the 5 Evildead666 files

than i installd the gmdb files

in the sql files all -- i changed to #

i have an Bug with Skinning, every creature who have loot, i can't loot them couse i should loot them. I looted the creature bevore! If the creature don't have loot, i can skinning it.

in the Database have every creature an Type, if i set the type to 8 (its the same how a cow) its fine, i can skinning every creature, but than i can kill every creature with 1 hit

so i think there is an bug with the type or something else

Paladin Bug after he casted an heal, need the heal 2 sec to heale someone

in the Log Files i have much more errors

i hope someone can help me

sorry for my bad english

bb

Dainara

[attachment deleted by admin]

[Hikari]

You can find a fix for the holy light delay here https://getmangos.eu/index.php?topic=20894.msg157472#msg157472.

[antz]

I also think they is an untested fix for the looting bug in the issues tracker in the repo

[Dainara]

ok i'm not sure if i do it right for the holy light delay fix

i create src/game/extras/ folder in sourcecode and copy that file SpellMod.cpp in this folder

than i compiled it. ok i will test the new binaries later

where i can found the untestet fix for the looting bug an how is this called?

[Hikari]

Not quite. The commit was linked to indicate what's causing the problem. The actual fix is at the end of the linked post and is a patch for the spell manager.

diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp
index 879795b..c946219 100644
--- a/src/game/SpellMgr.cpp
+++ b/src/game/SpellMgr.cpp
@@ -145,6 +145,11 @@ uint32 GetSpellCastTime(SpellEntry const* spellInfo, Spell const* spell)
  if (spellInfo->HasAttribute(SPELL_ATTR_RANGED) && (!spell || !spell->IsAutoRepeat()))
    { castTime += 500; }

+  // [workaround] holy light need script effect, but 19968 spell for it have 2.5 cast time sec
+  // it should be instant instead
+  if (spellInfo->Id == 19968)
+    castTime = 0;
+
  return (castTime > 0) ? uint32(castTime) : 0;
}

[Dainara]

ok, i don't know what i have to do with this script,

the command diff --git

i get the message

diff: unrecongnized option '--git'

[Hikari]

There are different ways to apply a patch to a repository. If you want to apply it with git, then you should first save the snippet to a text file.

Afterwards use

git apply --check your-text-file.patch

to determine if you can apply the patch without errors.

If no error occured you apply it with

git apply your-text-file.patch

Or you could, because it is a small patch, insert it manually.

Open your SpellMgr.cpp and go to line 147 within the function GetSpellCastTime and add

// [workaround] holy light need script effect, but 19968 spell for it have 2.5 cast time sec
// it should be instant instead
if (spellInfo->Id == 19968)
 castTime = 0;

Sidenote: In order to understand the structure of a patch the plus (+) character in front of a line indicates where something will be added and a minus (-) character where something will be removed after applying.

[Dainara]

Thank you very much for the great instructions, i testet both, by the 1. i had problems but i get it to work without errors

the Healbug from Paladin is now fixed

thx

now to the other bugs, a big problem is the lootbug in groups and skinning bug

if 2 or more players have an collect quest how an head from an NPC, only 1 player can loot them, so a group with 5 players have to kill the NPC 5 times.

i found some quests they have bug's too

should i post it here or elsewhere?