[FIX] Judgement of the wise

[hikikomori18]

any updates on this topic?

from a cursory gleaming of the thread, it looks like, they made a patch, but they didn't use aura implementation, and didn't set proc flags, so the patch spell procs 2 times. There's your update.

[Deake]

i actually meant what's still keeping it from being included in the git..

[hikikomori18]

i actually meant what's still keeping it from being included in the git..

and I told you why. Dev's don't like it when you don't use aura implementation, didn't use proc flags, and the patch in question, doesn't even work correctly.

after reading it the first time, and now reading what i've said, the 2nd time, do you still think it should be committed into master?

[Deake]

well... no, ty for explaining it a 2nd time without flaming

[jorooo]

fix spell_proc_event for spell chance and procflags

delete from `spell_proc_event` where entry in (31876,31877,31878);
insert into `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) values('31876','0','10','8388608','0','0','16','0','0','33','0');
insert into `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) values('31877','0','10','8388608','0','0','16','0','0','66','0');
insert into `spell_proc_event` (`entry`, `SchoolMask`, `SpellFamilyName`, `SpellFamilyMask0`, `SpellFamilyMask1`, `SpellFamilyMask2`, `procFlags`, `procEx`, `ppmRate`, `CustomChance`, `Cooldown`) values('31878','0','10','8388608','0','0','16','0','0','100','0');

diff is for revision 7477

diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp
index 839ebe2..f50b709 100644
--- a/src/game/Unit.cpp
+++ b/src/game/Unit.cpp
@@ -5344,6 +5344,16 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu
        }
        case SPELLFAMILY_PALADIN:
        {
+    //Judgements of the wise 
+    if ( dummySpell->SpellIconID==3017 )
+    {
+            target = this;
+            triggered_spell_id =31930;
+            basepoints0 = GetCreateMana() * 0.15;
+            CastSpell ( this,57669,true,NULL,GetDummyAura ( dummySpell->Id ),GetGUID() );
+        break;
+    }
+
            // Seal of Righteousness - melee proc dummy (addition ${$MWS*(0.022*$AP+0.044*$SPH)} damage)
            if (dummySpell->SpellFamilyFlags&0x000000008000000LL && effIndex==0)
            {

<10 letters>

[Graftal]

Just tried the fix, and it works perfectly! That's very nice! Awesome job kozelo Thanks

[supicek]

Any chance, to move this fix to accepted ?

[hikikomori18]

Any chance, to move this fix to accepted ?

maybe if they fix a few things, it might.

[Energizer]

>>>>up<<<<

[Punisherx]

So this fix still can't be implemented in live?

[jorooo]

It is forgotten/ignored QQ

[enigmabr]

Hi,

Have a git pull?

Thanks

[scarg]

any update?:confused:

[LordJZ]

This patch has already been added to mangos git repo.

[Xeon87]

This patch has already been added to mangos git repo.

mmm, i am not sure of this.

[jorooo]

It was never added. Obviously, it is not worthy of dev's attention any more...

[Homenixx]

Keep up the good work!

[jorooo]

This is now obsolete. Thanks ApoC!

[bulek]

works perfectly

add plz

[kaplon]

Already added.

Close:)

[Killan]

I think it works fine... any chance to be added?

[Ceris]

I think it works fine... any chance to be added?

it is already added in master branch

[apendix]

revision 8392

ytdb 504

sd latest

i think this talent does not working anymore, can anyone confirm this?

[kamillys]

This talent works, but should be 0.25 instead of 0.15 in basepoints0 = GetCreateMana() * 0.15; because in 3.1.0 or newer it regen 25% mana instead of 15%.

[apendix]

This talent works, but should be 0.25 instead of 0.15 in basepoints0 = GetCreateMana() * 0.15; because in 3.1.0 or newer it regen 25% mana instead of 15%.

yes i think this bug