stfx

What bug does the patch fix? What features does the patch add? Fix lava/slime liquid extraction from WMO data (indoors and in dungeons). Fixes environmental damage in Molten Core, Ragefire, Blackrock Mountain, Blackrock Spire, Blackrock Depths and Naxxramas. For which repository revision was the patch created? s0920 (mangos-one) Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. No. Who has been writing this patch? Please include either forum user names or email addresses. Me, stfx This problem is as old as mangos itself but due to the vmap3 backport we can adress the issue now. Though there a few differences from master because we cant get the liquid type in the same way. Also as far as I know there is no 100% correct way because their simply is not enough data provided in the .wmo. Now to describe the problem a little bit more in detail: issue #1: The data from liquid_type.dbc is totally useless and different from master issue #2: The liquid flags from the WMOs are only partially usable because for example the flag for the lava in ragefire is the same as on the lake in a cave in nagrand (and possible other places as well) Here is the logged data from the WMOs: http://pastebin.com/BzbsSFaT Now after my first approach which is less hacky, there is atleast one location being extracted with a wrong liquid type, which looked like that: http://code.google.com/p/oregoncore/source/detail?r=5a4f38973dbbf2d1aca519b617c64c02eccbc3f2 Here is the reason why (logged data in form of an Excel sheet - see line #99): https://spreadsheets.google.com/ccc?key=0AtP7KyCg177NdFFOQUhJb1BzbmJyLWNzR2diVzdvMXc&hl=en&authkey=CN3n5toM So finally here is the patch which allows us to remove one hack from player.cpp but adds a hack as it checks for wmo name in the vmap extractor: http://pastebin.com/UfP0y7ww After that vmaps finally work as they were intended to be and fixed bugs which have been in the core for a far too long time.

Based on some experience with outdoor areas on oregoncore the easiest and most straight-forward map is definetely Hellfire Peninsula. You only have 3 towers with repetitive code and as long as every tower is captured players in the area get a buff (+5 %dmg). Also if you kill someone in near a tower you receive a token. Alliance buff: 32071 Horde buff: 32049 Alliance kill reward: 32155 Horde kill reward: 32158

Alright today I looked into the issues with lava. Here is the thing I found out. Liquids extracted in the map files (from ADT data) are detected correctly. Those liquids only being outdoor and they are also not located within an instance. Effected areas for slime/lava liquids from ADT: Shadowmoon Valley, Un'Goro crater and outside of blackrock. Liquids extracted in the vmap files (from WMO data) are detected but being interpreted wrong. Water works but lava/slime will be also detected as water. Effected areas for slime/lava: Inside blackrock, Molten Core and Naxxramas Gonna look into this some more. Btw vmap indoor/outdoor fix ( http://code.google.com/p/oregoncore/source/detail?r=5ca3d7ee9558622c713ab541fbd592bee06c29c8 ) has been tested for a week by 300 players+ and no issues were reported so far.

Please do so and post any locations you find that are not correctly detected. I really tested a lot of them and could not find a single one PS: Commit could look like this http://code.google.com/p/oregoncore/source/detail?r=5ca3d7ee9558622c713ab541fbd592bee06c29c8 (also dont load atEntry and wmoEntry in Map::IsOutdoors) EDIT: Another thing I noted is that the first part (Player.cpp) of https://github.com/mangos/mangos/commit/c29e8a38fbea7ee06ac32fd584ba71f848bb941a is not yet backported to mangos-one making the second part (Spell.cpp) pretty useless

After many many tests I can verify that the correct mogp check flag is as follows return mogpFlags & 0x8000; It fixes all indoor/outdoor issues. They were actually even more issues than I had noticed at first (like the towers in AV). Also it seems like I was right about the indoor check at the entrance of the starting cave in AV

Alright there are client checks for ws flagroom but the server does not realize that its indoor (partly wrong mopgFlag check maybe?) mogpFlags (uint32) 1. WS Flagroom: 2569 (detected as outdoor) - INCORRECT 2. AV Cave Entrance: 2057 (detected as outdoor) - probably CORRECT (see edit) 3. In BG room in Orgrimmar, WS Hut with powerups, AV Cave): 10245 (detected as indoor) - CORRECT 4. WS underground tunnel: 10757 (detected as indoor) - CORRECT 5. Everywhere in Orgrimmar except in building: 47681 (detected as outdoor) - CORRECT Moderator: no WOW images on this forum! EDIT: The issue seen on the second pic is that players can mount before the game starts. I guess it could also work if we move the door a few yards back - I think thats even the blizzlike solution. Though 1. is definately an issue

Nice, but: 1. you can still mount up in flagarea in WS (tunnel works but flag area itself not) 2. you can mount up a few meters in front of the gate in AV (some more meters back into the cave does not work) 3. you dont get dismounted in the slime in Undercity. The bg indoor checks worked with old flag checks and the slime issue is probably related to environmental damage missing (lava, slime) due to .map update (not vmap). The only problem with the old checks was the fact that you got dismounted in cities like Orgrimmar or Undercity but everything else worked as far as I know.

Good job Btw did you check my partial backport of 6a6cde8d284370b160952582378190b92c5ac2d4 already? I think its pretty good one. It backports as much as possible without breaking 2.4.3 extraction. Patch can be found here: https://gist.github.com/802722

Yes, there are a few typos and I already commented them in github: https://github.com/faramir118/mangos/commit/62ec65c676b90acbb9675c3c5a76bc95cf5d617a#src/game/GridMap.cpp-P29 https://github.com/faramir118/mangos/commit/583066196273f49422b575cbf5263a8ae7bca769#src/game/DBCfmt.h-P6 https://github.com/faramir118/mangos/commit/9fa9121af59527bbb27c8ace3e11accc06c45abe#contrib/vmap_extractor_v2/vmapextract/vmapexport.cpp-P503 https://github.com/faramir118/mangos/commit/9fa9121af59527bbb27c8ace3e11accc06c45abe#contrib/vmap_extractor_v2/vmapextract/adtfile.cpp-P65 Well the indoor check seemed to work in my tests but they were rather quick. Btw I was the one who contacted you about the indoor check issue a few months earlier when I ported vmap3 to oregoncore (2.4.3)

Indoor/outdoor checks are working fine in town/bg/world which has always been an issue in my port The only big issue which existed on mangos-one for like forever is non working liquid damage (lava in molten core, searing gorge) but that could also be .map related. Would be awesome if you can look into that as well Tested with patch added in previous post and those small typo fixes I commented in github

Alright here is the partial backport for 6a6cde8d284370b160952582378190b92c5ac2d4: https://gist.github.com/802722 It does not change anything except renaming a few modelheader variables and removing the not used normals variable as well as the not used ModelTexUnit struct. Changes left out in the commit: - The removal of ModelVertex and ModelView structs as those are needed for 2.4.3 AFAIK - The ofsViews entry which has those views in it - BB_vertices, BB_indices and offsBB_vertices as they are not used - The removal of origVertices as we need them to get the modelviews Please tell me what you think EDIT: Readded nD, ofsD, nI and ofsI based on http://www.madx.dk/wowdev/wiki/index.php?title=M2. The format now perfectly matches with the one on that page

Awesome. One thing I noticed when looking at the code is that https://github.com/mangos/mangos/commit/6a6cde8d284370b160952582378190b92c5ac2d4 has not been backported to mangos-one yet. Is it for 3.x only? I think we can add atleast a few of those changes. For example the normals variable of model.h is no where really used. Also fwrite(&nIndices,sizeof(uint32), 1, output); should rather be fwrite(&nIndexes,sizeof(uint32), 1, output); in model.cpp:88

Well I fixed most of those already some time ago on trinitycore1 continuation, OregonCore. That code we had in the core was also from the original outdoor pvp patch made for mangos and had a few issues like: - requiring creatures to capture the tower points (remove "hack") - http://bitbucket.org/oregon/oregoncore/changeset/c4ffe56d3cfd - not having set the artkit initially (only on first update if someone arrives at the location) - http://bitbucket.org/oregon/oregoncore/changeset/15504f118ec4 - EP (eastern plaguelands) not working - http://bitbucket.org/oregon/oregoncore/changeset/3a53d3aba59e - Redundant EP code (code refactor) - http://bitbucket.org/oregon/oregoncore/changeset/60c526937550 - have no flag spawns on EP - http://bitbucket.org/oregon/oregoncore/changeset/15504f118ec4 - not displaying the correct shrine aura on EP - http://bitbucket.org/oregon/oregoncore/changeset/f2a6dfc86180 - not displaying the flightmasters horde aura if he was summoned for the horder and not being able to use him to fly somewhere I might help to fix a few in this patch but unfortunately I have no WotLK client nor server

Updated gist to [10720] with your requests included

Should be moved to [Patches] -> [under Review...] if possible

Yes but players should still see the whispers of other players (GMs were working) while being /dnd

What bug does the patch fix? What features does the patch add? Whispers should be displayed to the player even if he is /dnd /dnd is usually used so that people get an auto answer like "stfx does not wish to be disturbed: no I wont help you". But not something where the person wont even get incomming messages (thats why we have /ignore someone). This bug has been in the core like forever which simply is not like the retail behaviour. The only thing which might not be 100% retail after the patch is the changed mangos_string pattern. For which repository revision was the patch created? 10541 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. no Who has been writing this patch? Please include either forum user names or email addresses. me, stfx http://gist.github.com/597972

What bug does the patch fix? What features does the patch add? Fix the mana drain effect of item 32336 (Black Bow of the Betrayer). For which repository revision was the patch created? 11265 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. no Who has been writing this patch? Please include either forum user names or email addresses. me, stfx http://gist.github.com/597741

Alright I patched against master branch (instead of 0.12 branch) now

yeah I forgot to add a title and cant change it anymore now

What bug does the patch fix? What features does the patch add? Fix afk/dnd message not being overwritten if you are already afk/dnd flagged: 1. /dnd 123 2. /dnd 345 3. /w charname test ... you only get "123" displayed right now For which repository revision was the patch created? 10535 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. no idea Who has been writing this patch? Please include either forum user names or email addresses. me, stfx (please dont commit it as stfxpi) http://gist.github.com/597727

What bug does the patch fix? What features does the patch add? Fix the issue that you cant login after you entered a wrong password in auth server (correct account name but wrong password). Seems like the client disconnects from the auth server due to the answer type (0x05 instead of 0x04) For which repository revision was the patch created? [s0235] - mangos-0.12 branch Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. no idea Who has been writing this patch? Please include either forum user names or email addresses. me, stfx Tested it with 2.4.3 client and I am pretty sure it does not work on 1.12 as well (untested though). But I am not sure about WOTLK client therefore you might want to change the patch if the same problem exists for WOTLK clients as well. PS: It also needs to be applied on master diff --git a/src/realmd/AuthSocket.cpp b/src/realmd/AuthSocket.cpp @@ -680,15 +680,20 @@ } else { - if (_build > 6005) // > 1.12.2 + if (_build > 8606) // > 2.4.3 { - char data[4]= { CMD_AUTH_LOGON_PROOF, WOW_FAIL_INCORRECT_PASSWORD, 3, 0}; + char data[4] = { CMD_AUTH_LOGON_PROOF, WOW_FAIL_INCORRECT_PASSWORD, 3, 0}; + send(data, sizeof(data)); + } + else if (_build > 6005) // > 1.12.2 + { + char data[4] = { CMD_AUTH_LOGON_PROOF, WOW_FAIL_UNKNOWN_ACCOUNT, 3, 0}; send(data, sizeof(data)); } else { // 1.x not react incorrectly at 4-byte message use 3 as real error - char data[2]= { CMD_AUTH_LOGON_PROOF, WOW_FAIL_INCORRECT_PASSWORD}; + char data[2] = { CMD_AUTH_LOGON_PROOF, WOW_FAIL_UNKNOWN_ACCOUNT}; send(data, sizeof(data)); } BASIC_LOG("[AuthChallenge] account %s tried to login with wrong password!",_login.c_str ());

Dude, Lynx3d you are awesome... Took your code and backported it to OregonCore. This can be easily ported to mangos 0.12. The actual changes are in r428-434 but I also changed the vmap extractor and shared/vmaps before that to make backporting easier. Yeah I fixed the crash issue caused by the new model code when using the extractor / assembler as well. I only have one last problem with indoor/outdoor. It works perfectly except in all big cities (orgrimmar, undercity, stormwind, ...). They are all handled as indoor areas so people cant use mounts in those places anymore. Now wow4 wrote something like replacing WMOAreaTable.dbc with wotlk's but thats really dirty and I would really like to have a proper fix because everything else works just perfect. I hope anyone can help me so that all TBC based server cores (mangos 0.12/OC) can make use of this awesome vmap system. Lynx3d if you read this and dont mind please help me fix it Thanks