darkstalker

because it always must be quality > features, useless to have a core with dualspec/vehicles/wash your dishes patch if it crashes every 5 min

still always felt like shields absorbing too much dmg, specially in shadow priests. Maybe the absorb calculation needs to be done before armor/resilience/dmg taken auras

so damage its absorbed before it has a chance to become a critical hit? nice finding..

problem is that snakes are wild summons (aggresive to everyone)

its interrupt mechanic, not silence causes school lock when opponent is casting

ye, i remeber that "error" on ascent servers, happened when you used normal faerie fire v/s talented one that same criteria should be applied to different totem ranks (all stack now)

^that you should pick highest aura instead of overriding each other

doxygen can autogenerate UML charts afaik

it should use FillRaidOrPartyHealthPriorityTargets

not broken, it just has a different visual effect

always noticed that when using far sight it doesnt show player movement (its just like a "snapshot"), is this related?

a SOAP interface to character stats would be really nice, no need to query them all the time, for stuff like armories or forum signatures you could make an external cache with saved values

i saw once an ascent server that you could join any faction in the game (like Cenarion Expedition or even Stormwind as horde) and you gained faction specific spells when doing that. Server was tagged as RPPvP (duno if that matters, maybe enables some client side stuff). When you joined a faction it had "guild chat" with everyone there.

seems to be this

the for loop there might break unexpectedly depending on the order of the auras in the list, i think a more correct of doing this w/o having to duplicate the for loop would be: uint8 found_effects = 0; Unit::AuraList const& mDummy = GetAurasByType(SPELL_AURA_DUMMY); for(Unit::AuraList::const_iterator itr = mDummy.begin(); itr != mDummy.end(); ++itr) { if ((*itr)->GetSpellProto()->SpellIconID == 1563) { // Predatory Strikes (effect 0) if ((*itr)->GetEffIndex() == EFFECT_INDEX_0) { if (IsInFeralForm()) mLevelMult = getLevel() * (*itr)->GetModifier()->m_amount / 100.0f; found_effects |= 1; } // Predatory Strikes (effect 1) else if ((*itr)->GetEffIndex() == EFFECT_INDEX_1) { mBonusWeaponAtt = (*itr)->GetModifier()->m_amount * m_baseFeralAP / 100.0f; found_effects |= 2; } if (found_effects == (1+2)) break; }

awesome, was just thinking on looking into this but you solved it already edit: you can change (*itr).missCondition into itr->missCondition and looks better

thats the crash caused by the anti freeze thread

lots of spell in DBC have redundant costs, cast times or cooldown categories for triggered spells, maybe not implementing some attribute flag?

its constructor syntax for type casting, normal C style would be (uint32)( ... ) or a more explicit C++ style: static_cast<uint32>( ... ) it means: "convert whats inside to the type uint32", in this case means 32 bit unsigned integer

make it sure it works with wine under linux

base damage should be already there, that why you use '+=' (add to current value) the 0.310f makes explicit float constant (not double as default), is just to make Visual Studio happy (useless warning imho, doesnt exist in gcc) uint32( ... ) is a explicit type cast (result of the operation inside is float)

usually from a function parameter or member element, you dont need to know the "original source" in that case would be (in class Spell context) Unit *unitTarget = m_targets.getUnitTarget(); but that code is already there, you just use the provided pointers

Lua is ugly, i would prefer C++ anytime

the only difference between class and struct is that that class member are private by default, and struct members are public by default

there are other opposite cases (buy maybe related) that some spell do remove invisibility/stealth when they shouldn't, like Earthbind Totem and Mass Dispel