Unkle Nuke

Everybody has to start someplace and everyone assimilates and learns in their own way. I can understand your point, Darkruler, but traponinet's method is a good first step that avoids adding the additional complication of learning advanced Git commands. Patches, if studied, can help to reveal the method by which a fix or merge is done. However, Biali should take you up on your offer if he's wanting to go into more detail. It's just that sometimes people need to take small bites first before diving into the buffet table. Maybe we do need someone with your skills to host a "Git Bootcamp" so people can learn how to work with repos and merges.

Yes, you were, good sir.

Maybe he's not using UDB for his database or has an old version that does not include these fixes? I've seen server admins post here that were using cores and databases that were literally years old. Updates seem to be a foreign idea to them. lol

Sometimes, due to server crashes or when updating the database to newer server revisions, "trash" data can be left behind. This can include old spells, items, and pets that are no longer used or have changed IDs, instances that did not reset correctly, mail that was not properly deleted, and so forth. These "Character Cleaning" SQL scripts attempt to find and remove this old data. Having an accurate, up to date database is important to prevent crashes and "bugged" characters that may become unplayable due to faults in their data. Be careful which cleaning script you choose. Make sure it is for your server and database version, plus check that it uses proper procedures like creating backups in case an error is made and data needs to be restored as well as using IF EXISTS with DELETE and INSERT instead of simply using REPLACE INTO when modifying tables. To be safe, always make sure you run your own backup of any tables before modifying or cleaning them with any scripts or queries.

If merge conflicts are not to be discussed in this thread, despite said conflict involving code differences between Vehicles and Camera Fix, and they're not to be discussed in the other thread, then pray tell just exactly where one is supposed to request help with code compatibilities between patches? It is not as if we're discussing simple merge errors with MaNGOS itself. Who else would be better qualified to point out the necessary changes in code to make the two patches compatible than the developers of said patches? By your reasoning, Darkruler, one would be forced to solve the issue themselves or drop one patch in favor of another. Is it not the obligation of the various patch developers to at least attempt in assisting to resolve such conflicts or is it preferred to take an adversarial stance toward other core mods and leave the end user with no support and no choice? Aren't we all supposed to be in this together? That is what defines the word "community". traponinet, I salute you for stepping forth to help Biali. You are an example we all should follow in working together to help each other.

Yes. You just download it using Git or as a zip file right from Github, then do with it as you normally would any other add-on.

Actually, no. Those values are fixed in the core. There is no way to modify the XP gained from just low level quests and creatures using the mangosd.conf file. The settings in the config file do allow you to modify the reputation gain from low level kills and quests. I'm not sure where the values are stored, but the CPP and header files for World, Player, and Shared Defines would be where I'd look first.

Wow. Talk about digging up bones! Still there are many such interesting or useful patches that have been allowed to rot in the dustbin of time. Glad to see someone is trying to update at least one. Let's hope it becomes a trend. Maybe a useful new feature for this patch would be to bestow a title upon the kicked or banned player's characters, such as "The Scoundrel" or "The Booted Hind", which they must bear until such time it is judged they have proven themselves worthy of having the label lifted by a GM.

Although this thread is not for SilverIce's camera fix, Biali's trouble does involve compatibility issues with Vehicles and Camera Fix. That makes it a valid question and is indeed pertinent to the Vehicles thread. Try to bear that in mind next time a similar post comes up in this topic or elsewhere, Mcrizza. Biali, if you cannot find help here, also try SilverIce's thread but, not until it is clear no help is forthcoming from the Vehicles thread. This is suggested to prevent having others accusing you of spamming. So wait at least a day or two before asking elsewhere for help. This will also give time for those who may help here to render the assistance you need.

pasdVn still maintains and works upon his pet and petstats patches. He does not do a weekly merge or rebase to keep the patch easy to add for inexperienced people but, you can still use his patches if you are willing to do the extra work to add them to your source code repository. Some simple hand editing will allow you to use his code. I highly recommend his pet patches! Hunters and Warlocks are especially best when using pasdVn's work.

You're absolutely right, Patman. My brain's needle skips a groove sometimes. lol Sorry about that, Biali. I hope your own brain did not overheat too much trying to find that non-existent command. Previous post corrected.

Unless balrok makes another surprise appearance, I'd have to say the answer to your question would be a solid "No". I'm not real sure what's been keeping him off the grid, but it does seem life has been keeping him away from further work on Outdoor PvP for the near future. I suppose if someone wants to make some news, by lending balrok a hand to help complete this patch, he did say he'd be willing to give programming advice to such a volunteer.

No, he does not need to do this. The Pastebin link shows a file uploaded May 1, 2010. Same goes for Filebeam. These are the most current versions of his patch. Download and enjoy.

Try merging AHBot's last revision with the same revision of MaNGOS, then do a rebase to current MaNGOS revision. If that does not work then boot up your favorite editor and hand-merge.

Goodness knows the amount of effort and time you've already put into the various features we now enjoy. Anything you do beyond the basic bots is icing on the cake and you've already done considerably more than anyone ever dared to hope for with this core mod. Having it work with other player characters would be the birthday candles on top, but there's no hurry. It's bound to be a great deal of work and your focus on enabling more detail in features like get means we either wait or someone else steps up to help implement this feature. You're a super coder, but you're not Superman, after all! Honestly, blueboy, I'd love to help contribute to the development of playerbot. I've only just blown the dust off my old C++ college textbook and trying to muddle my way through chapter one of "Design And Problem Solving With C++". Expect my first patch sometime in 2011 at this rate. lol ... but I am inspired by you to at least try.

The .lookup item or .lookup object command with the name of the totem should return the GUID and model ID of the totem.

It really sounds like a database problem. Check the commands table to make sure the .start command is properly implemented for casting unstuck. Then check the other table entries for proper corpse spawns.

Thank you for your continued work on this patch, Siegels. I will be adding this to my new server update, soon.

It would seem really useful to have a bot to fill an empty role in a party or raid group, but I understand that the design philosophy of playerbot is for the use of an individual player. Is there some technical reason that prevents a playerbot from being coded to assist other players, such as casting heals and buffs, if the bot master chooses? I suspect it might require revising some large portions of code, so the client/server behaves as if the bot were a regular character. This assumes it can even be done, of course.

Ex-girlfriend been stalking you again, eh?

Thanks for clearing that up, guys. I had saved both patches, just in case. So perhaps what's needed is a generic check with some CASE modules to handle the various mounts in question?

I just don't understand why this patch hasn't already been moved to the "under review" section. Is there any valid reason preventing it? We still need better terrain handling and this patch, along with the work being done for vmaps and mmaps is a big step.

Lynx3d and faramir118, you two have made such a great team with the work on vmap v3 that I sincerely hope the two of you will consider continuing your work as a duo for the mmaps redux project! Thank you both for this important and well-done job, guys!

Like xeross said, unless your server has an old, outdated ahbot patch, you do not need to apply characters_auctionhousebot_update.sql. It is only intended to bring old ahbot database tables up to date for use with newer ahbot revisions. This means that most, if not all, server administrators do not need this sql file and could safely delete it.

No such accusation was being made, Darkruler. Consider it a good-natured jab. Although your idea for cherry-picking the commit is simple to those of us who have the experience, you have to bear in mind the greater part of the participants in these forums know just enough for the essential steps required to get a server up and running. Anything beyond the basic use of Git, like pull and automatic merge, and cranking the code through a compiler, just does not compute with the average user. I know MaNGOS is supposed to be a learning project, but there seems to be an inherent lack of interest among the majority in digging deeper and learning the more esoteric details. Experience has taught me that 99% of the requests for an updated patch actually means it is preferred to have a 100% compatible patch that can be applied in one easy step with no hand-editing, whitespace errors, or even using git mergetool to resolve conflicts. I'll readily admit I'm no genius with Git, but I do try to learn. Although I can forgive those whose requests are based on outdated or incompatible code. I'm equally as lost where it comes to C++ and hand-editing code to update a patch, but that's not the case with your PvP Token commit. Those who refuse to learn will continue to post here with "Updated patch, plz."