Jump to content

H0zen

Senior getMaNGOS Developer
  • Posts

    114
  • Joined

  • Last visited

  • Days Won

    11
  • Donations

    0.00 GBP 

Everything posted by H0zen

  1. [quote=Xenithar]I found the issues. You can't do safe updates without specifying an index. I removed all commenting, coding, everything except SQL from the update and ran it. It ran until it hit the following lines. [code] update dbdocsfields SET FieldComment = replace(FieldComment, 'table', 'table'); update dbdocsfields SET fieldNotes = replace(fieldNotes, 'table', 'table'); [/code] There is no index given so it was failing due to not being a safe operation. This was not being shown in the errors log, but it was causing the rollback flag to trip. All updates MUST specify an index! I now have to delete everything up to this line and figure out how to correct it so I can complete the update.[/quote] To make these lines safe add an "always true where clause", involving an index, like you did in a previous PR (21_1_16, if I remeber right). Like: update dbdocsfields SET FieldComment = replace(FieldComment, 'table', 'table') where `fieldId`> 0; update dbdocsfields SET fieldNotes = replace(fieldNotes, 'table', 'table') where `fieldId`> 0; This is a standard procedure to calm down the angry MySQL. PS: What is the meaning of those 2 updates? Maybe I`m blind, but I don't get it. It replaces all occurences of "table" with.. "table"? In the comments I see something about "fixing a typo"...
  2. Starting with April, 13th, 2014, the whole proc system in M2 was broken An unfortunate and dreadful typo made the whole proc system unusable in M2 project. All builds after April 13th, 2014 were affected. The [URL="https://github.com/mangostwo/server/pull/119"]fix for this issue has been identified[/URL] few minutes ago.
  3. The fix for this issue has been [URL="https://github.com/mangoszero/server/pull/60"]PR`ed[/URL]. The problem was the destruction of various static ACE_TSS objects. A great hint was quite the [URL="http://www.dre.vanderbilt.edu/Doxygen/5.7.9/html/ace/a00737.html#_details"]documentation[/URL] (the note)
  4. [quote=Xenithar]I will PR that if that is the ONLY entry being updated. Is that confirmed?[/quote] What do u mean by "if that is the only entry"? If it's about the records affected, the addition is an always-true, harmless expression involving a key, as to suppress the MySQL error.
  5. Until a PR will be made, edit the sql file and @line 53 add the following: AND `entry`>0 The line in cause shall read UPDATE `gameobject_template` SET `data2`=3 WHERE `type`=6 AND `data9`>0 AND `data2`=1 AND `entry`>0;.
  6. I just [URL="https://github.com/mangostwo/server/pull/117"]PR the fix[/URL] for this issue. Hope all goes well from now on.
  7. This has already been fixed with [URL="https://github.com/mangoszero/server/commit/3d7be378f4b75e9e83664b29916522891f08c54a"]this commit[/URL]
  8. I [URL="https://github.com/mangoszero/server/pull/50"]PR a possible fix[/URL] for Zero (as the issue is there too). Needs vigorous testing in-game
  9. Hi, I`ve just [URL="https://github.com/mangosone/server/pull/23"]PR a fix[/URL] for this. Hope all go well from now.
  10. In mangosd.conf you have a line reading MaxPingTime. Set this to a value lower than your MySQL`s wait_timeout and I bet all these problems will dissapear (the default value for MaxPingTime is 30min, which was ok for a wait_timeout of 28800).
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue. Privacy Policy Terms of Use