Cupcake

Anyone can give a hint where to look to fix this? Atm the hybrid classes like enhancement shamans are hitting like a truck due to way higher crit percentage.

Any ideas how to fix this? Afaik players should be teleported out of the instance 1min before the instances reset.

Is there anything you can do about the other bug that's letting players enter heroic instances without attunement? The bug is as following: player without attunement enter normal mode, logs off, leader changes to heroic and enters, and when the player w.o attunement logs back in he will be in the heroic mode of the instance. Don't know if this bug was submited before, but i just thought about giving a heads up, maybe you have the skills to fix this.

OK,thanks for clarifying this, i asked just because i got mixed inputs from different persons.

Since this got backported to One aswell, is there anyone who played TBC on retail who can confirm this? WoWWiki:

Got some breakthrough about one of the crashes. Server always crashes during the daily instance reset if there are players inside the instances.

Can confirm this.

WTB a pair of glasses. So the aura removal should be there.

Not sure about that, you mean the damage effect should proc at every tick until the player dies? WoWWiki and wowhead infos are unclear about that..

Confirming this, SSE needs to be disabled before building the project. Right-click every project in the solution, go to Properties -> Configuration Properties -> C/C++ -> Code Generation and set Enable Enhanced Instruction Set to Not Set, then rebuild the solution.

Alternative for latest revision (thanks denno for the idea): http://paste2.org/p/1881946

Is anyone able to reproduce these crashes or it's just me? And still wasn't able to get the server going for longer than 20min in debug mode and to get a crash log.

Mangos One: s1454 SD2: s2384 TBCDB 1.2.1 ACID 2.0.6a --No custom patches-- Currently the Melee Critical Strike bonus from gear also affects the Spell Critical Strike of the player, and it shouldn't. I guess is due to some bad backport from master since the critical strike system was changed in WotLK.

What do you mean by interrupting? You mean they overwrite themselfs, aka auras are not stacking?

Didn't look on the Zero sources, but have a look at this code from One and see what's different, maybe you'll get an idea how to fix it. http://paste2.org/p/1878338

2) You need to have .gm fly off in order to swim afaik.

Thanks, i'll test and see if that does the trick. EDIT: Thanks again , tested it and not sure if it's the best approach or if there are any side-effects but seems problem is solved. Patch here if anyone is interested, credits to tibbi : http://paste2.org/p/1876585

Mangos One: s1454 SD2: s2384 TBCDB 1.2.1 ACID 2.0.6a --No custom patches-- It's common knowledge that NPCs shouldnt be able to crit with their spells, but i noticed that Jan'alai's Flame Breath spell critted on me while testing it. Is it possible to prevent a spell from critting individually or this is a major bug that needs to be fixed somewhere else?

Well i tested and it worked, else i wouldnt have posted I was thinking of adding the code in the block you said, but wanted to check first outside it, and since it worked i left it as it is.

Mangos One: s1454 SD2: s2373 TBCDB 1.2.1 ACID 2.0.6a --No custom patches-- --------------------------------- As it is now, the Moonfire and Lacerate spells are removing each other from the target. Suggested fix: http://paste2.org/p/1875567

Thanks salja, works perfectly, someone should move this to under review. And as a side note, aren't these sort of informations about spells taken from DBC? Why aren't they behaving properly?

I know it's a slighly different problem, but didnt want to make a new topic about it since it's also about NPCs movement. So what i noticed is that atm if a player manages to climb on some object like 5-10yds above the ground level the NPCs won't attack him anymore with melee, and that opens the possibility for some exploits, like in Hyjal for example in the horde encampment, if a player climbs on the top of those spike looking fences then the bosses would stop melee him and casts only the ranged spells. I know in the past the NPCs would "fly" and chase the players until a certain height, is it possible to get that back, maybe as a configurable height treshold?

Afaik there was a similar problem on master not so long ago and it got fixed, can't remember what rev. tho.

Thanks for the feedback, will get back if i manage to get it working. EDIT: Managed to fix it, no side effects that i noticed so far, accepting suggestions. http://pastebin.com/nXn3tcKw

Mangos One: s1454 SD2: s2373 TBCDB 1.2.1 ACID 2.0.6a --No custom patches-- --------------------------------- The Arcane Power spell should give the mage a temporary buff to increase his dps output, and it's working fine except the fact that it's shown as a debuff instead of a buff, thus it can't be dispelled by enemies. Anyone knows how to correct this?