bulek

still buged for healing DMG for me:huh:

bump again, works fine

nice, thank you vladimir:)

hm any news or updates?

I created a .patch file for anybody that wants to use it and dosen't have the time to manually apply.

With this ocasion i managed to review the patch. It's a very good start, but i've seen that some work still needs to be added. I think it's about 60-70% complete.

8902 patch

nice

pls mangos devs review it:)

works fine tested^_^

works for me

bump,

patch from first post is awesome, WORKs fine

tested on 8900

hello any idea how to fix this achiev?

i haven't been working on this patch since longer time, and i haven't been keeping my repo up to date. so maybe you get a few merge errors, but it should (theoretically) work with the newest version(s) too. just try it, if you get merge error... merge it and post a diff

sorry, but as already stated in the udb forum, i'm out of time, so i can't update it.

-- DasBlub

ok thanks for the reply:) certainly try and I try to patch it

Patch is awesome )

works fine

well done guys

WARNING!

Talent "Threat of Thassarian" is supposed add off-hand's damage to these abilities: Death Strike, Obliterate, Plague Strike, Rune Strike, Blood Strike and Frost Strike(doesn't work with this one at all).

But, besides doing this, it also makes these abilities apply their special effect twice and that it shouldn't do. Well since other abilities have either none or each-application-overwrites-the-previous special effects, the only problem is Death Strike which now heals the DK twice.

DB PATCH SIDE been included in revisions please check whether it is there

this part in revision

insert into spell_chain values (65661,0,65661,1,0),
(66191,65661,65661,2,0),
(66192,66191,65661,3,0);

to check:

alter table `spell_proc_event` change `entry` `entry` mediumint(5) UNSIGNED default '0' NOT NULL;
DELETE FROM `spell_proc_event` WHERE `entry` IN (65661);
INSERT INTO `spell_proc_event` VALUES
(65661, 0, 15, 0x00400010, 0x20020004, 0x00000000, 0x00000010, 0x00000001, 0.000000, 100.000000, 0);

sry for bumping old thread

or

this is patch working with new rev?:huh:

bump...stop fast-owls!

bump

yeah! boomkin with dash= pwned :-)

Work in last rev or not ?

yeah

bump, iam test and patch works with latest revision;)

please devs review or add comments what have to be improved because it is blocking community work with related spells and 3rd party projects (SD2)

confirm

please dev review and add comment

any new updates ?

lava lash still buged with newest core:huh:

oh nice , patch works with newest core

any news or test able uptades?

bump:) this is horrible bug

Here is my fix.

SpellEffects.cpp, EffectWeaponDmg()

+        case SPELLFAMILY_HUNTER:
+        {
+            // Kill Shot
+            if( m_spellInfo->SpellFamilyFlags & UI64LIT(0x80000000000000) )
+            {
+                spellBonusNeedWeaponDamagePercentMod = true;
+                spell_bonus += m_spellInfo->EffectBasePoints[0];
+                spell_bonus += int32( 0.2f * m_caster->GetTotalAttackPowerValue(RANGED_ATTACK) );
+            }
+            break;
+        }
       case SPELLFAMILY_PALADIN:

very good idea but

m_spellInfo->SpellFamilyFlags & UI64LIT(0x80000000000000) )
+            {
+                spellBonusNeedWeaponDamagePercentMod = true;
+                spell_bonus += m_spellInfo->EffectBasePoints[0];
+                spell_bonus += int32( 0.2f * m_caster->GetTotalAttackPowerValue(RANGED_ATTACK) );
+            }

hack fix?:confused:

Netsky: could you please share your hard work to test it if it has not known major bugs which is under investigation by you? We would like to test it in our enviroment and help you and the community.

Thanks in advance!

regards,

wormyke

:)yes share you hard work, more testers , more more bugs detected:)

any news/updates?

test this?

this is no my code

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp
index 3a0862d..0d28cb8 100644
--- a/src/game/SpellAuras.cpp
+++ b/src/game/SpellAuras.cpp
@@ -2637,6 +2637,9 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
        case FORM_SHADOW:
        case FORM_STEALTH:
            break;
+        case FORM_SHADOWDANCE:
+            PowerType = POWER_ENERGY;
+            break;
        case FORM_TREE:
            modelid = 864;
            break;
@@ -2682,7 +2685,8 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
        if(m_target->m_ShapeShiftFormSpellId)
            m_target->RemoveAurasDueToSpell(m_target->m_ShapeShiftFormSpellId, this);

-        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, form);
+        // For Shadow Dance we must apply Stealth form (30) instead of current (13)
+        m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, (form == FORM_SHADOWDANCE) ? uint8(FORM_STEALTH) : form);

        if(modelid > 0)
            m_target->SetDisplayId(modelid);
@@ -2747,6 +2751,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                        m_target->SetPower(POWER_RAGE, Rage_val);
                    break;
                }
+                // Shadow Dance - apply stealth mode stand flag
+                case FORM_SHADOWDANCE:
+                    m_target->SetStandFlags(UNIT_STAND_FLAGS_CREEP);
+                    break;
                default:
                    break;
            }
@@ -2779,6 +2787,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real)
                if(Aura* dummy = m_target->GetDummyAura(37324) )
                    m_target->CastSpell(m_target, 37325, true, NULL, dummy);
                break;
+            // Shadow Dance - remove stealth mode stand flag
+            case FORM_SHADOWDANCE:
+                m_target->RemoveStandFlags(UNIT_STAND_FLAGS_CREEP);
+                break;
            default:
                break;
        }
diff --git a/src/game/Unit.h b/src/game/Unit.h
index faefbef..3f0e578 100644
--- a/src/game/Unit.h
+++ b/src/game/Unit.h
@@ -167,6 +167,7 @@ enum ShapeshiftForm
    FORM_GHOUL              = 0x07,
    FORM_DIREBEAR           = 0x08,
    FORM_CREATUREBEAR       = 0x0E,
+    FORM_SHADOWDANCE        = 0x0D,
    FORM_CREATURECAT        = 0x0F,
    FORM_GHOSTWOLF          = 0x10,
    FORM_BATTLESTANCE       = 0x11,

bump any updates or news? hex is horrible bug:(

bump again review this plz