Forusim

You should not use hardcoded values, are there no modifiers in the dbc files?

The whole targetsystem of channeling spells is fu*ked up. Sometimes you heal grounding totems instead of tank, or even your enemy... Same with Arcane Missiles, sometime they don´t even be castet, but the mage is channeling. Or it try to dmg your allies.

This patch is a working hack, but the real problem is behind not implemented Apply Aura: Shapeshift Ignored SpellClass

Confirm broken achievements for heroic instances. Check the table achievement_criteria_requierement, there should be all achievements entries. Heroic bosses show their parent id, if you use .npc info. You should check your table creature_template => difficulty_entry_1 for the real id.

There are missing entries in your database, which version are you using? On UDB 391 i havent faced that errors.

Just do rightclick on your source folder and hit "git bash here" In the command box type "git diff origin/master > NAME.patch" and this will make a diffpatch out of your changes and stores it in the source folder.

Still buggy at Rev 10065 and i have discovered a strange relation. If you skill Survival Instincts before Primal Fury, this bug will occur and grants you 1 additional talent point. If you first skill Primal Fury and after this Survival Instincts, everything is fine. Maybe it will help you to seek for the bug.

Mangos Version: 10065 Custom Patches: Broadcaster SD2 Version: 1714 Database Name and Version : UDB 391 How it SHOULD work: Each Arcane Blast will you give you a buff, which increase dmg of all your arcane spells. How it DOES work: The spell Arcane Barrage consume this buff stacks, but does not increase the dmg, as it should. I think somewhere the spelldmg coefficient is after the buff removal and will never profit from it. I have tryed to search in sourcecode, but could not find the line, where the coefficient is given to arcane spells. Hope you have an idea, how to solve it. Thanks!

Works as intended. Using UDB 391 even contains the sql part already. Thank you! One thing i am not sure about are these logs:

Read the tooltip and comments... http://www.wowhead.com/spell=64382

Not at level 70! But this is not the point, feral get 2 more talent points than other classes and this makes the whole system imbalanced.

Mangos Version: 10018 Custom Patches: Broadcaster SD2 Version: 1706 Database Name and Version : UDB 391 How it SHOULD work: If you invest a point in a talent, it should decrease your amount of avaible talent points. How it DOES work: If you try to skill Primal Fury Rank 1 it increase your amount of avaiable talent points by 1. This is a very serious bug, because of that you get 63 talentpoints on level 70 instead of 61. So players can skill Berserk and Omen of Clarity at the same time, which is imbalanced! If you use talenplanner(Addon or Blizzard) where you have put 2 points in Primal Fury and then learn the whole spec directly, the bug will not occur. Only when you skill rank 1 one by one. I have already checked the spell.dbc, but have not found any diffence between rank 1 and rank 2. So i have no idea, how to solve this problem, because it does not occur on Rev. 9605. Hope you can help me, thanks!

Oh snap Thanks guys!

Hey nice tool. Trying to open the project with visual c++ 2008, but it says it doesnt support my version, although i open SpellWork_VS2008.sln Any idea, how to solve this? Thanks!

Are there no values in the dbc files? Hardcoded is not good. Check similar patches, to get the chance % out of ranks.

More and more spells get broken and tons of hacks, because of inaccurate blizz .dbc data and custom content is difficult to realize. Maybe time for sql-based .dbc entries, which can overwrite blizz .dbc?

Mangos Version: 10018 Custom Patches: Broadcaster SD2 Version: 1706 Database Name and Version : UDB 391 How it SHOULD work: Quote from SoC Tooltip: Only one Corruption spell per Warlock can be active on any one target. How it DOES work: If 1 WL cast Corruption and another cast SoC, it will overwrite 1st WL Corruption and vice versa. The problem is caused here: /src/game/SpellMgr.cpp //Corruption & Seed of corruption if( spellInfo_1->SpellIconID == 313 && spellInfo_2->SpellIconID == 1932 || spellInfo_2->SpellIconID == 313 && spellInfo_1->SpellIconID == 1932 ) if(spellInfo_1->SpellVisual[0] != 0 && spellInfo_2->SpellVisual[0] != 0) return true; // can't be stacked It doesnt compare casters guid and then overwrite the debuffs. I think we need a extension in : /src/game/SpellMgr.h // Spell clasification enum SpellSpecific { SPELL_NORMAL = 0, SPELL_SEAL = 1, SPELL_BLESSING = 2, SPELL_AURA = 3, SPELL_STING = 4, SPELL_CURSE = 5, SPELL_ASPECT = 6, SPELL_TRACKER = 7, SPELL_WARLOCK_ARMOR = 8, SPELL_MAGE_ARMOR = 9, SPELL_ELEMENTAL_SHIELD = 10, SPELL_MAGE_POLYMORPH = 11, SPELL_POSITIVE_SHOUT = 12, SPELL_JUDGEMENT = 13, SPELL_BATTLE_ELIXIR = 14, SPELL_GUARDIAN_ELIXIR = 15, SPELL_FLASK_ELIXIR = 16, SPELL_PRESENCE = 17, SPELL_HAND = 18, SPELL_WELL_FED = 19, SPELL_FOOD = 20, SPELL_DRINK = 21, SPELL_FOOD_AND_DRINK = 22, }; Or do a more generic check for spells like Immolate and Unstable Afflication, which should overwrite each other after patch 3.1, when casted by same player: Regards

Devs pls review KAPATEJIb fix.

Any further research on SPELL_ATTR_EX6_UNK23?

Rupture does NOT crit atm... What are you talking about? Mangos or Blizzard?

Which Mangosrev do you have? Any patches?

Puuuuuuuuuuuuuuuuush

Still working?

My patch does not contain the SQL files, since everyone should already have them, if he used broadcaster before. Here the SQL: INSERT INTO `mangos_string` (`entry`, `content_default`, `content_loc1`, `content_loc2`, `content_loc3`, `content_loc4`, `content_loc5`, `content_loc6`, `content_loc7`, `content_loc8`) VALUES (11000, '|cffffcc00[server]: |cff00ff00%s|r', NULL, NULL, NULL, NULL, NULL, NULL, NULL, NULL); CREATE TABLE IF NOT EXISTS `broadcast_strings` ( `id` int(11) unsigned NOT NULL auto_increment, `text` text NOT NULL, `next` int(11) unsigned NOT NULL, PRIMARY KEY (`id`) ) ENGINE=MyISAM DEFAULT CHARSET=utf8;

I took it from your repo and solved merging conflicts.