KAPATEJIb

I'm not expert in paladins, but with my fix it works as said in spell tooltips. For example - Seal of blood procs for 29 damage - paladin gets 2 damage back.

Here a typo Should be (20467, 0.7695, 0, 0.16, "Paladin - Judgement of Command"), ADDED: I've already tested both of your patch for paladins. Bug: Seal of Blood inflict 100% of damage to paladin, not 10% as should be. Seal of Martyr works as should fix: change line if(m_spellInfo->Id == 31893) to if(m_spellInfo->Id == 31892)

where? patch and link isn't changed in first post

Only last rank of spell (5) works for me, other ranks return 1 mana. Tested on 7900 rev.

Patch contained in my compiled binaries for a long time. Patch tested on many servers and works as should.

As i said before... that talent is modified by blizz in 3.1 patch. On 3.0.9 he works as should.

Bug: Improved Fear procs from http://www.wowhead.com/?spell=17928 Fix: add spell icon id check That patch also helps me to create patch for Physhic Horror talent for 3.0.9 (on 3.1+ that talent is modified a bit) diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 2dd62f9..4969bb4 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -3302,6 +3302,23 @@ void Aura::HandleModFear(bool apply, bool Real) return; m_target->SetFeared(apply, GetCasterGUID(), GetId()); + + if(!apply && m_spellProto->SpellFamilyName == SPELLFAMILY_PRIEST) + { + Unit* caster = GetCaster(); + int32 spell_id = 0; + if(!caster || caster->GetTypeId() != TYPEID_PLAYER) + return; + else + { + if(caster->HasAura(47571, 0)) + spell_id = 59980; + else if(caster->HasAura(47572, 0)) + spell_id = 59981; + } + if(spell_id) + m_target->CastSpell(m_target, spell_id, false); + } } void Aura::HandleFeignDeath(bool apply, bool Real)

When i use a scroll, that created from vellum, and logout, i've get a errors in console GameEvent 34 "L70ETC Concert" removed. Player(GUID: 12 Name: Pristyag)::_SaveInventory - the bag(255) and slot(255) val ues for the item with guid 302 are incorrect, the player doesn't have an item at that position! Player::_SaveInventory - one or more errors occurred save aborted! and sometimes (if player equip item, enchanted from that scroll) server crashes Revision: * * 7859 68c9688307709667d5bcb94b2eb3021ce9f4b789 Date 21:5:2009. Time 0:2 //===================================================== *** Hardware *** Processor: Intel(R) Core(TM)2 Duo CPU E8400 @ 3.00GHz Number Of Processors: 2 Physical Memory: 4192460 KB (Available: 1795428 KB) Commit Charge Limit: 4194303 KB *** Operation System *** Microsoft Windows Server 2003 Professional Service Pack 2 (Version 5.2, Build 3790) //===================================================== Exception code: C0000005 ACCESS_VIOLATION Fault address: 004010B9 01:000000B9 C:\\EmulatorX\\wotlk\\mangosd.exe Registers: EAX:3CFF8200 EBX:1A9C0820 ECX:3CFF8200 EDX:00000000 ESI:00000000 EDI:00922A40 CS:EIP:0023:004010B9 SS:ESP:002B:06A7F3A4 EBP:06A7F3B8 DS:002B ES:002B FS:0053 GS:002B Flags:00010293 Call stack: Address Frame Function SourceFile 004010B9 00000000 Object::GetGUIDLow+19 0050484E 00000000 Player::_SaveInventory+2EE 00503C61 00000000 Player::SaveToDB+1081 00613500 00000000 WorldSession::LogoutPlayer+A10 008E4DF6 00000000 WorldSession::HandleLogoutRequestOpcode+286 0061283C 00000000 WorldSession::Update+18C 0063D86B 00000000 World::UpdateSessions+11B 0063992A 00000000 World::Update+36A 004385CE 00000000 WorldRunnable::run+8E 00922A57 00000000 ACE_Based::Thread::ThreadTask+17 100514D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61C828 00000000 ZwWaitForSingleObject+15 7D4D8BF1 00000000 WaitForSingleObject+12 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 00922C30 00000000 ACE_Based::Thread::Sleep+30 0092A8B0 00000000 SqlDelayThread::run+20 00922A57 00000000 ACE_Based::Thread::ThreadTask+17 100514D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 00922C30 00000000 ACE_Based::Thread::Sleep+30 0092A8B0 00000000 SqlDelayThread::run+20 00922A57 00000000 ACE_Based::Thread::ThreadTask+17 100514D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 00922C30 00000000 ACE_Based::Thread::Sleep+30 0092A8B0 00000000 SqlDelayThread::run+20 00922A57 00000000 ACE_Based::Thread::ThreadTask+17 100514D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61D6C6 00000000 ZwGetContextThread+12 06A7E3A8 00000000 0000:00000000 FF50D845 FFFFFFFF

Patch for last revisions diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index f84dd6a..7839408 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -4038,6 +4038,10 @@ void Aura::HandleModMechanicImmunity(bool apply, bool /*Real*/) target->RemoveAurasDueToSpell(26592); } } + + // Heroic Fury (remove Intercept cooldown) + if( apply && GetId() == 60970 && m_target->GetTypeId() == TYPEID_PLAYER ) + ((Player*)m_target)->RemoveSpellCooldown(20252,true); } //this method is called whenever we add / remove aura which gives m_target some imunity to some spell effect

I think that because a spells, that increases all damage in percent, are applyed on SoC twice: first - increases melee "white" damage in stats, second - increased final damage. As i know (from my offy players) - should increase only one. For example you can use buffs for attack power, that increases your damage in stats near 20% and attack other players/mob; after that you should remove that buffs, use Avenging Wrath, that increase all damage on 20% and attack that player/mob - you should see a big difference

0.12 Patch have a typo in makefile. + OutdoorPvPEP.cpp \\__ should be + OutdoorPvPEP.cpp \\ used __ because you can't see a "spaces" in codebox

7602 git pull git://github.com/charlie2025/mangos.git outdoor_0.12 remote: Counting objects: 513, done. remote: Compressing objects: 100% (140/140), done. Indexing 311 objects... remote: Total 311 (delta 260), reused 212 (delta 170) 100% (311/311) done Resolving 260 deltas... 100% (260/260) done 60 objects were added to complete this thin pack. Auto-merged src/game/Player.cpp Auto-merged src/game/Spell.cpp Auto-merged src/game/SpellAuras.cpp CONFLICT (content): Merge conflict in src/game/SpellAuras.cpp Auto-merged src/game/Unit.cpp Automatic merge failed; fix conflicts and then commit the result.

7594 9>OutdoorPvPSI.cpp 9>..\\..\\src\\game\\OutdoorPvPSI.cpp(133) : error C2039: 'ModifyFactionReputation' : is not a member of 'Player' 9> c:\\mangos-0.12\\src\\game\\Player.h(862) : see declaration of 'Player' 9>..\\..\\src\\game\\OutdoorPvPSI.cpp(158) : error C2039: 'ModifyFactionReputation' : is not a member of 'Player' 9> c:\\mangos-0.12\\src\\game\\Player.h(862) : see declaration of 'Player' 9>OutdoorPvPNA.cpp 9>OutdoorPvPMgr.cpp 9>c:\\mangos-0.12\\src\\game\\OutdoorPvPEP.h(6) : fatal error C1083: Cannot open include file: 'Database/DBCStructure.h': No such file or directory 9>OutdoorPvPHP.cpp 9>OutdoorPvPEP.cpp 9>c:\\mangos-0.12\\src\\game\\OutdoorPvPEP.h(6) : fatal error C1083: Cannot open include file: 'Database/DBCStructure.h': No such file or directory

On mangos two or more warriors can use different ranks of Battle Shout to get more AP bonus.

Feign Death should also drop flag, i have other patch that haves already fixed case with feign death. Sorry, but that patch is old, and i've forget a first author name http://paste2.org/p/168712 patch tested on many servers (because used in my compiled binaries ) and don't have any bugs related... That patch can be splitted on two parts: first - implementation of aura flag_lost_selection (drops flag) second - part, that don't allow to pick up the flag with immunity grant spells

some spells stack still bugged, you can have two buffs from different paladins, for example: Blessing of Kings and Greater Blessing of Kings, Blessing of Might and Greater Blessing of Might. These spells shouldn't stack.

seems patch not works for me. heroic fury still not drop cooldown for intercept

http://mangos.ru/showthread.php?t=17228

9>SpellAuras.cpp 9>..\\..\\src\\game\\SpellAuras.cpp(3267) : error C2679: binary '==' : no operator found which takes a right-hand operand of type 'AuraType' (or there is no acceptable conversion) 9> could be 'built-in C++ operator==(const uint32 [3], const uint32 [3])' 9> C:\\Program Files\\Microsoft SDKs\\Windows\\v6.0A\\include\\guiddef.h(192): or 'int operator ==(const GUID &,const GUID &)' 9> while trying to match the argument list '(const uint32 [3], AuraType)'

diff --git a/src/game/Player.cpp b/src/game/Player.cpp index e05d48a..c705c4b 100644 --- a/src/game/Player.cpp +++ b/src/game/Player.cpp @@ -18747,6 +18747,7 @@ uint32 Player::GetResurrectionSpellId() case 20764: spell_id = 20760; break; // rank 4 case 20765: spell_id = 20761; break; // rank 5 case 27239: spell_id = 27240; break; // rank 6 + case 47883: spell_id = 47882; break; // rank 7 default: sLog.outError("Unhandled spell %%u: S.Resurrection",(*itr)->GetId()); continue;

Merging problems with [7026]

Problem not in heroic instances. To crash server you can use .go object 11011 I hope developers read this and reproduce crash on their servers

Easy to reproduce on UDB 363. Use .go object 11011 and server crash Revision: 2008-11-19 16:18:05 6840 eca35bf3d6abc94ccb46f244c5e3ac289c3396ee Date 24:11:2008. Time 0:12 //===================================================== *** Hardware *** Processor: AMD Athlon(tm) 64 Processor 3700+ Number Of Processors: 1 Physical Memory: 3145200 KB (Available: 1842020 KB) Commit Charge Limit: 4194303 KB *** Operation System *** Microsoft Windows XP Professional Service Pack 2 (Version 5.1, Build 2600) //===================================================== Exception code: C0000005 ACCESS_VIOLATION Fault address: 0049E96B 01:0009D96B C:\\Documents and Settings\\admin\\Рабочий стол\\EmulatorX\\Server\\mangosd.exe Registers: EAX:00000000 EBX:01679E18 ECX:00000000 EDX:0AEF6F48 ESI:00001071 EDI:0012FA84 CS:EIP:001B:0049E96B SS:ESP:0023:0429FA60 EBP:0429FA74 DS:0023 ES:0023 FS:003B GS:0000 Flags:00010246 Call stack: Address Frame Function SourceFile 0049E96B 00000000 LinkedListHead::Iterator<MapReference>::operator+++1B 0049948D 00000000 Map::Update+5D 00623C5F 00000000 MapManager::Update+1AF 00605F71 00000000 World::Update+B11 004337C1 00000000 WorldRunnable::run+91 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 7C802542 00000000 WaitForSingleObject+12 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 7C802542 00000000 WaitForSingleObject+12 0088C64E 00000000 ZThread::Monitor::wait+9E 00888320 00000000 ZThread::ThreadImpl::sleep+60 0088749C 00000000 ZThread::Thread::sleep+C 0086F540 00000000 SqlDelayThread::run+20 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 7C802542 00000000 WaitForSingleObject+12 0088C64E 00000000 ZThread::Monitor::wait+9E 00888320 00000000 ZThread::ThreadImpl::sleep+60 0088749C 00000000 ZThread::Thread::sleep+C 0086F540 00000000 SqlDelayThread::run+20 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 7C802542 00000000 WaitForSingleObject+12 0088C64E 00000000 ZThread::Monitor::wait+9E 00888320 00000000 ZThread::ThreadImpl::sleep+60 0088749C 00000000 ZThread::Thread::sleep+C 0086F540 00000000 SqlDelayThread::run+20 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 0429EA98 00000000 0000:00000000 FF50D845 FFFFFFFF 0000:00000000 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 7C8715C1 00000000 GetConsoleInputWaitHandle+318 7C871708 00000000 ReadConsoleA+3B 7C8018B3 00000000 ReadFile+A5 78586A93 00000000 realloc+9F7 78586F17 00000000 _read+C0 7854EC7A 00000000 _filbuf+7D 7854E319 00000000 fgets+109 0040EEE8 00000000 CliRunnable::run+B8 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 7C802542 00000000 WaitForSingleObject+12 0088C64E 00000000 ZThread::Monitor::wait+9E 00888320 00000000 ZThread::ThreadImpl::sleep+60 0088749C 00000000 ZThread::Thread::sleep+C 0042F418 00000000 RARunnable::run+228 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 7C802542 00000000 WaitForSingleObject+12 0088C64E 00000000 ZThread::Monitor::wait+9E 00888320 00000000 ZThread::ThreadImpl::sleep+60 0088749C 00000000 ZThread::Thread::sleep+C 0042F03B 00000000 FreezeDetectorRunnable::run+7B 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 71A35FA7 00000000 0001:00004FA7 C:\\WINDOWS\\system32\\MSWSOCK.dll 71A92E67 00000000 select+A7 10015105 00000000 ?wait_for_multiple_events@?$ACE_Select_Reactor_T@V?$ACE_Reactor_Token_T@VACE_Token@@@@@@MAEHAAVACE_Select_Reactor_Handle_Set@@PAVACE_Time_Value@@@Z+115 FFFFFFFF FFFFFFFF 0000:00000000 Call stack: Address Frame Function SourceFile 7C90EB94 00000000 KiFastSystemCallRet+0 71A35FA7 00000000 0001:00004FA7 C:\\WINDOWS\\system32\\MSWSOCK.dll 71A92E67 00000000 select+A7 10015105 00000000 ?wait_for_multiple_events@?$ACE_Select_Reactor_T@V?$ACE_Reactor_Token_T@VACE_Token@@@@@@MAEHAAVACE_Select_Reactor_Handle_Set@@PAVACE_Time_Value@@@Z+115 FFFFFFFF FFFFFFFF 0000:00000000 ======================== Local Variables And Parameters Call stack: Address Frame Function SourceFile 0049E96B 00000000 LinkedListHead::Iterator<MapReference>::operator+++1B Local <user defined> 'this' 0049948D 00000000 Map::Update+5D Local <user defined> 'iter' Local <user defined> 'this' Local <user defined> 't_diff' Local <user defined> 'updater' Local <user defined> 'world_object_update' Local <user defined> 'grid_object_update' 00623C5F 00000000 MapManager::Update+1AF Local <user defined> 'iter' Local <user defined> 'this' punting on symbol diff 00605F71 00000000 World::Update+B11 punting on symbol i Local <user defined> 'this' punting on symbol diff Local unsigned int 'autobroadcaston' = 0 004337C1 00000000 WorldRunnable::run+91 punting on symbol diff Local <user defined> 'this' punting on symbol realCurrTime punting on symbol realPrevTime punting on symbol prevSleepTime 00888725 00000000 ZThread::ThreadImpl::Dispatch+1D5 Local <user defined> 'g' Local <user defined> 'i' Local <user defined> 'parent' Local <user defined> 'impl' Local <user defined> 'task' 00888B83 00000000 ZThread::`anonymous namespace'::Launcher::run+33 Local <user defined> 'this' 0088CC37 00000000 ZThread::ThreadOps::_dispatch+17 punting on symbol arg Local <user defined> 'task' 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7C80B50B 00000000 GetModuleFileNameA+1B4 ======================== Global Variables

For linux users: You also should change Option.assign to OptionText.assign in two files for compilation without errors on new revs

Confirmed, i have it too