KAPATEJIb

Updated for 8882. Also added seal of light fix maybe this should be handled by spell_proc_event table?

Happens when you delete first and last waypoint for npc (but npc have a middle waipoint), for example npc have 3 waypoints - you delete 3 and 1 = crash. I my case middle waypoint (2) also have a spell (drake mount) Revision: * * 8856 ae7346627847161d535ee92ab9fdc788ef6f9563 Date 22:11:2009. Time 22:54 //===================================================== *** Hardware *** Processor: Intel(R) Core(TM)2 Duo CPU E4500 @ 2.20GHz Number Of Processors: 2 Physical Memory: 2095396 KB (Available: 1237140 KB) Commit Charge Limit: 3943456 KB *** Operation System *** Microsoft Windows Server 2003 Enterprise Edition Service Pack 2 (Version 5.2, Build 3790) //===================================================== Exception code: C0000005 ACCESS_VIOLATION Fault address: 0061F82B 01:0021E82B C:\\WoW Server\\wow\\wotlk_server\\mangosd.exe Registers: EAX:00000000 EBX:F3D0B880 ECX:00000000 EDX:FFFFFFFE ESI:820125E4 EDI:F1300075 CS:EIP:0023:0061F82B SS:ESP:002B:09484D34 EBP:09485E74 DS:002B ES:002B FS:0053 GS:002B Flags:00010246 Call stack: Address Frame Function SourceFile 0061F82B 00000000 WaypointMovementGenerator<Creature>::LoadPath+1BB 0043D875 00000000 MovementGeneratorMedium<Creature,WaypointMovementGenerator<Creature> >::Initialize+25 00450B71 00000000 MotionMaster::Initialize+141 0078DA60 00000000 ChatHandler::HandleWpModifyCommand+EC0 005469F4 00000000 ChatHandler::ExecuteCommandInTable+284 0054687F 00000000 ChatHandler::ExecuteCommandInTable+10F 005471FB 00000000 ChatHandler::ParseCommands+18B 0083ABFF 00000000 WorldSession::HandleMessagechatOpcode+56F 005D5180 00000000 WorldSession::Update+120 005E6CF3 00000000 World::UpdateSessions+C3 005E5585 00000000 World::Update+365 004305DE 00000000 WorldRunnable::run+8E 00861049 00000000 ACE_Based::Thread::ThreadTask+19 00B414D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61C828 00000000 ZwWaitForSingleObject+15 7D4D8BF1 00000000 WaitForSingleObject+12 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 00861260 00000000 ACE_Based::Thread::Sleep+30 00867430 00000000 SqlDelayThread::run+20 00861049 00000000 ACE_Based::Thread::ThreadTask+19 00B414D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 00861260 00000000 ACE_Based::Thread::Sleep+30 00867430 00000000 SqlDelayThread::run+20 00861049 00000000 ACE_Based::Thread::ThreadTask+19 00B414D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 00861260 00000000 ACE_Based::Thread::Sleep+30 00867430 00000000 SqlDelayThread::run+20 00861049 00000000 ACE_Based::Thread::ThreadTask+19 00B414D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61D6C6 00000000 ZwGetContextThread+12 09483D58 00000000 0000:00000000 FF50D845 FFFFFFFF 0000:00000000 FF50D845 FFFFFFFF 0000:00000000 Call stack: Address Frame Function SourceFile 7D54F049 00000000 LZDone+EBE 7D4D08E6 00000000 ReadFile+A5 78586A93 00000000 realloc+9F7 78586F17 00000000 _read+C0 7854EC7A 00000000 _filbuf+7D 7854E319 00000000 fgets+109 00410278 00000000 CliRunnable::run+B8 00861049 00000000 ACE_Based::Thread::ThreadTask+19 00B414D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 00861260 00000000 ACE_Based::Thread::Sleep+30 0042C23B 00000000 RARunnable::run+22B 00861049 00000000 ACE_Based::Thread::ThreadTask+19 00B414D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61C828 00000000 ZwWaitForSingleObject+15 7DB4093C 00000000 0001:0000093C C:\\WINDOWS\\system32\\MSWSOCK.dll 71A9283C 00000000 select+A1 00B04AE5 00000000 ?wait_for_multiple_events@?$ACE_Select_Reactor_T@V?$ACE_Reactor_Token_T@VACE_Token@@@@@@MAEHAAVACE_Select_Reactor_Handle_Set@@PAVACE_Time_Value@@@Z+115 FFFFFFFF FFFFFFFF NlsMbOemCodePageTag+FFFFFFFF8295FF5F Call stack: Address Frame Function SourceFile 7D61C828 00000000 ZwWaitForSingleObject+15 7DB4093C 00000000 0001:0000093C C:\\WINDOWS\\system32\\MSWSOCK.dll 71A9283C 00000000 select+A1 00B04AE5 00000000 ?wait_for_multiple_events@?$ACE_Select_Reactor_T@V?$ACE_Reactor_Token_T@VACE_Token@@@@@@MAEHAAVACE_Select_Reactor_Handle_Set@@PAVACE_Time_Value@@@Z+115 FFFFFFFF FFFFFFFF NlsMbOemCodePageTag+FFFFFFFF8295FF5F ======================== Local Variables And Parameters Call stack: Address Frame Function SourceFile 0061F82B 00000000 WaypointMovementGenerator<Creature>::LoadPath+1BB punting on symbol i Local <user defined> 'this' Local <user defined> 'c' punting on symbol node_count 0043D875 00000000 MovementGeneratorMedium<Creature,WaypointMovementGenerator<Creature> >::Initialize+25 Local <user defined> 'this' Local <user defined> 'u' 00450B71 00000000 MotionMaster::Initialize+141 Local <user defined> 'this' 0078DA60 00000000 ChatHandler::HandleWpModifyCommand+EC0 Local <user defined> 'result2' Local <user defined> 'data' Local <user defined> 'wpCreature' Local <user defined> 'npcCreature' Local <user defined> 'this' Local <user defined> 'args' Local <user defined> 'data' punting on symbol lowguid Local <user defined> 'target' Local <user defined> 'show' Local <user defined> 'npcCreature' punting on symbol wpGuid punting on symbol show_str punting on symbol point punting on symbol arg_str 005469F4 00000000 ChatHandler::ExecuteCommandInTable+284 punting on symbol i Local <user defined> 'this' Local <user defined> 'table' Local <user defined> 'text' Local <user defined> 'fullcmd' Local <user defined> 'oldtext' Local <user defined> 'cmd' 0054687F 00000000 ChatHandler::ExecuteCommandInTable+10F punting on symbol i Local <user defined> 'this' Local <user defined> 'table' Local <user defined> 'text' Local <user defined> 'fullcmd' Local <user defined> 'oldtext' Local <user defined> 'cmd' 005471FB 00000000 ChatHandler::ParseCommands+18B Local <user defined> 'this' Local <user defined> 'text' Local <user defined> 'fullcmd' 0083ABFF 00000000 WorldSession::HandleMessagechatOpcode+56F Local <user defined> 'msg' Local <user defined> 'this' Local <user defined> 'recv_data' punting on symbol type punting on symbol lang Local <user defined> 'langDesc' 005D5180 00000000 WorldSession::Update+120 Local <user defined> 'opHandle' Local <user defined> 'this' punting on symbol __formal Local <user defined> 'packet' punting on symbol currTime 005E6CF3 00000000 World::UpdateSessions+C3 Local <user defined> 'next' Local <user defined> 'itr' Local <user defined> 'this' punting on symbol diff Local <user defined> 'sess' 005E5585 00000000 World::Update+365 punting on symbol i Local <user defined> 'this' punting on symbol diff 004305DE 00000000 WorldRunnable::run+8E punting on symbol diff Local <user defined> 'this' punting on symbol realCurrTime punting on symbol realPrevTime punting on symbol prevSleepTime 00861049 00000000 ACE_Based::Thread::ThreadTask+19 punting on symbol param Local <user defined> '_task' 00B414D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 ======================== Global Variables

Good idea, but you forgot - dispel should be considered as negative spell if target isn't friendly. So dispel and mass dispel can be resisted. With your patch it never be resisted (because they still positive). need something like case SPELL_EFFECT_DISPEL: { if (m_caster->IsFriendlyTo(pVictim)) return true; else return false; break; } in bool IsPositiveEffect (SpellMgr.cpp) But this doesn't work because m_caster and pVictim isn't declared in SpellMgr.cpp

Update for 8853+. Moved code for Judgement of Righteousness to more correct and safe place

Another update. No real changes, just updated for latest Mangos

Ok, updated now

I test your latest patch. Here is a bug with dancing rune weapon damage with death coil. For example when i cast Death Coil it inflicts 281 damage - dancing rune weapon casts Death Coil it inflicts 714 damage.

This doesn't works for me. Still bugged In combat log when i click on once at Divine Storm spell (3 targets): Divine Storm for 111 physical Seal of Command for 92 holy (crit) Divine Storm for 111 physical Seal of Command for 46 holy Divine Storm for 112 physical Seal of Command for 47 holy Should be: Divine Storm for 111 physical Seal of Command for 92 holy (crit) Divine Storm for 111 physical Divine Storm for 112 physical Patch updated. Added support for Holy Vengeance and Blood Corruption (Seal of Vengeance and Seal of Corruption DOT debuffs)

http://github.com/insider42/mangos/commit/f974e3b7ab19693b417905bfc5c38142e19763ed

You are wrong, spell should deal a critical hit if target under effect of Flame shock

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 3bf098f..9210653 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -5920,9 +5920,6 @@ void Aura::HandleAuraUntrackable(bool apply, bool /*Real*/) void Aura::HandleAuraModPacify(bool apply, bool /*Real*/) { - if(m_target->GetTypeId() != TYPEID_PLAYER) - return; - if(apply) m_target->SetFlag(UNIT_FIELD_FLAGS, UNIT_FLAG_PACIFIED); else

Core: 8809 on CentOS 5.2 Patches: my own branch with many patches DB: YTDB 519 SD2: 1498 #0 0x00e6b410 in __kernel_vsyscall () No symbol table info available. #1 0x00795d20 in raise () from /lib/libc.so.6 No symbol table info available. #2 0x00797631 in abort () from /lib/libc.so.6 No symbol table info available. #3 0x007cde6b in __libc_message () from /lib/libc.so.6 No symbol table info available. #4 0x007d5b16 in _int_free () from /lib/libc.so.6 No symbol table info available. #5 0x007d9070 in free () from /lib/libc.so.6 No symbol table info available. #6 0x00c45731 in operator delete () from /usr/lib/libstdc++.so.6 No symbol table info available. #7 0x08395e5f in std::_List_base<Aura*, std::allocator<Aura*> >::_M_clear ( this=0x8ad140) at /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/ext/new_allocator.h:94 __cur = (class std::_List_node<Aura*> *) 0x0 #8 0x083e5f51 in ~Unit (this=0x1cb77e68) at /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/bits/stl_list.h:339 No locals. #9 0x0817a3d7 in ~Creature (this=0x1cb77e68) at ../../../src/game/Creature.cpp:141 No locals. #10 0x08294510 in ObjectGridUnloader::Visit<Creature> (this=0xb2ee10b8, m=@0x1be8020c) at ../../../src/game/ObjectGridLoader.cpp:274 obj = (class Creature *) 0x1cb77e68 #11 0x082947f1 in VisitorHelper<ObjectGridUnloader, Creature, TypeList<DynamicObject, TypeList<Corpse, TypeNull> > > (v=@0xb2ee10b8, c=@0x1be8020c) at ../../../src/game/../framework/GameSystem/TypeContainerVisitor.h:70 No locals. #12 0x0824f804 in Map::UnloadGrid (this=0xb4688440, x=@0xb2ee127c, y=@0xb2ee1278, pForce=false) at ../../../src/game/../framework/GameSystem/GridLoader.h:72 unloader = {i_grid = @0x1be7ed78} grid = (NGridType *) 0x1be7ed78 gx = <value optimized out> gy = <value optimized out> __PRETTY_FUNCTION__ = "bool Map::UnloadGrid(const uint32&, const uint32&, bool)" #13 0x0847fa80 in RemovalState::Update (this=0xb46144b8, m=@0xb4688440, grid=@0x1be7ed78, info=@0x6, x=@0xb2ee127c, y=@0xb2ee1278, t_diff=@0xb2ee12b8) at ../../../src/game/GridStates.cpp:65 No locals. #14 0x08263458 in Map::Update (this=0xb4688440, t_diff=@0xb2ee12b8) at ../../../src/game/Map.cpp:714 grid = <value optimized out> updater = {i_timeDiff = 113} __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)" #15 0x082761c5 in MapManager::Update (this=0xdf66d28, diff=20) at ../../../src/game/MapManager.cpp:267 iter = {_M_cur = 0xb4687b90, _M_ht = 0xdf66d70} #16 0x08420077 in World::Update (this=0xa0a7130, diff=20) at ../../../src/game/World.cpp:1669 next = {_M_cur = 0x0, _M_ht = 0x0} autobroadcaston = 0 #17 0x0813236a in WorldRunnable::run (this=0xb4617708) at ../../../src/mangosd/WorldRunnable.cpp:60 diff = 20 realCurrTime = 4061021132 realPrevTime = <value optimized out> prevSleepTime = 5 #18 0x084ed46d in ACE_Based::Thread::ThreadTask (param=0xb4617708) at ../../../src/shared/Threading.cpp:183 No locals. #19 0x001fc297 in ACE_OS_Thread_Adapter::invoke () from /usr/local/mangos/lib/libACE-5.6.6.so

What version you are installed, Lynx3d's or Darkstalker's?

Patch updated. Removed more obsolete code

I know it doesn't make a sense. Anyway it shouldn't have be called TARGET_IN_FRONT_OF_CASTER_30 because it's use not only PUSH_IN_FRONT_30

It's very powerful bug for paladins. As i understand we can check for healing reduce auras on 53652 caster here (unit.cpp), but HOW? triggered_spell_id = 53652; // Beacon of Light // HERE basepoints0 = triggeredByAura->GetModifier()->m_amount*damage/100;

I think dispel part can be moved to Unit.cpp like Unstable Affliction. Because if caster not is in world and you dispels bomb - you doesn't get a explosion.

8778 http://paste2.org/p/505240

It would be nice if you showed these "small changes" to us. Or upload a full patch

That patch make shadow priest's spell "Dispersion" to be removed with chance when someone attacks you Fixed diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 23c0cac..5733001 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -749,9 +749,15 @@ uint32 Unit::DealDamage(Unit *pVictim, uint32 damage, CleanDamage const* cleanDa ((Creature*)pVictim)->AI()->AttackedBy(this); } - // polymorphed and other negative transformed cases - if(pVictim->getTransForm() && pVictim->hasUnitState(UNIT_STAT_CONFUSED)) - pVictim->RemoveAurasDueToSpell(pVictim->getTransForm()); + // polymorphed, hex and other negative transformed cases + uint32 morphspell = pVictim->getTransForm(); + if(morphspell && !IsPositiveSpell(morphspell)) + { + if (IsSpellHaveAura(sSpellStore.LookupEntry(morphspell), SPELL_AURA_MOD_CONFUSE)) + pVictim->RemoveAurasDueToSpell(morphspell); + else if (IsSpellHaveAura(sSpellStore.LookupEntry(morphspell), SPELL_AURA_MOD_PACIFY_SILENCE)) + pVictim->RemoveSpellbyDamageTaken(SPELL_AURA_MOD_PACIFY_SILENCE, damage); + } if(damagetype == DIRECT_DAMAGE || damagetype == SPELL_DIRECT_DAMAGE) {

Patch for Shattering throw doesn't work anymore. Spell 64380 can't remove immunity effects from target and spell 64382 does too small damage (i think second problem should be fixed by other way) tested on 8780 rev In file spelleffects.cpp First can be fixed by replacing unitTarget->RemoveAurasDueToMechanic(1<<MECHANIC_IMMUNE_SHIELD); to unitTarget->RemoveAurasDueToMechanic(1<<(MECHANIC_IMMUNE_SHIELD-1)); Second by add // Shattering Throw ${$m1+$AP*.50} else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0040000000000000)) damage+= uint32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.5f); under // Heroic Throw ${$m1+$AP*.50} else if (m_spellInfo->SpellFamilyFlags & UI64LIT(0x0000000100000000)) damage+= uint32(m_caster->GetTotalAttackPowerValue(BASE_ATTACK) * 0.5f); Working patch is here http://paste2.org/p/503679

Now rating gaining is bugged, if you beat a team that have more than 1500 rating - they will not lost a points - then earn it in big values!!

Another patch http://paste2.org/p/500651 author is Astellar

8767 crash #0 0x0044e410 in __kernel_vsyscall () No symbol table info available. #1 0x00795d20 in raise () from /lib/libc.so.6 No symbol table info available. #2 0x00797631 in abort () from /lib/libc.so.6 No symbol table info available. #3 0x0078f16b in __assert_fail () from /lib/libc.so.6 No symbol table info available. #4 0x083fabc4 in Unit::GetPet (this=0x763e3ea8) at ../../../src/game/Object.h:494 st = {static SYMBUFSIZ = 4096, buf_ = "/usr/local/mangos/bin/mangos-worldd(_ZN8AreaAura6UpdateEj+0x2d6a) [0x837979a]\\n/usr/local/mangos/bin/mangos-worldd(_ZN4Unit13_UpdateSpellsEj+0x86) [0x840a6b6]\\n/usr/local/mangos/bin/mangos-worldd(_ZN4Un"..., buflen_ = 934, static UNSUPPORTED = 0xcb8da0 "<stack traces unsupported platform>", static UNABLE_TO_GET_TRACE = 0xcb8dc4 "<unable to get trace>"} #5 0x0837979a in AreaAura::Update (this=0x9e89ca70, diff=162) at ../../../src/game/SpellAuras.cpp:700 pet = <value optimized out> #6 0x0840a6b6 in Unit::_UpdateSpells (this=0xa61e3b38, time=162) at ../../../src/game/SpellAuras.h:318 i_aura = (class Aura *) 0x9e89ca70 #7 0x0840a8b1 in Unit::Update (this=0xa61e3b38, p_time=162) ---Type <return> to continue, or q <return> to quit---return at ../../../src/game/Unit.cpp:196 No locals. #8 0x08343b4d in Player::Update (this=0xa61e3b38, p_time=162) at ../../../src/game/Player.cpp:1084 now = <value optimized out> pet = <value optimized out> #9 0x08266276 in Map::Update (this=0xaf627e20, t_diff=@0xa55a22b8) at ../../../src/game/Map.cpp:595 plr = (class Player *) 0x5675 updater = {i_timeDiff = 162} __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)" #10 0x082775c5 in MapManager::Update (this=0xafd3cea8, diff=162) at ../../../src/game/MapManager.cpp:267 iter = {_M_cur = 0xaf772038, _M_ht = 0xafd3cef0} #11 0x08422347 in World::Update (this=0xa358258, diff=162) at ../../../src/game/World.cpp:1666 next = {_M_cur = 0x0, _M_ht = 0x0} autobroadcaston = 0 #12 0x08131d1a in WorldRunnable::run (this=0xad654a0) at ../../../src/mangosd/WorldRunnable.cpp:64 diff = 162 realCurrTime = 3148839847 realPrevTime = <value optimized out> If you want to see what is placed in my Spellauras.cpp:700 if( pGroup) { uint8 subgroup = ((Player*)owner)->GetSubGroup(); for(GroupReference *itr = pGroup->GetFirstMember(); itr != NULL; itr = itr->next()) { Player* Target = itr->getSource(); if(Target && Target->isAlive() && Target->GetSubGroup()==subgroup && caster->IsFriendlyTo(Target)) { if(caster->IsWithinDistInMap(Target, m_radius)) targets.push_back(Target); Pet *pet = Target->GetPet(); // <----- here that line №700 if(pet && pet->isAlive() && caster->IsWithinDistInMap(pet, m_radius)) targets.push_back(pet); } } }

You can try that fix http://github.com/insider42/mangos/commit/e45eabd70b87a2badbc656485909b3efc86acb2c