KAPATEJIb

Mangos 9640 YTDB 540 mods: my own branch http://paste2.org/p/747779

drink is a spell if you doesn't know it my patch remove invisibility at spell cast. So it's works in my patch

patch from first post works fine with 9640 rev of master

I mean this can help with my crash problem from map/vmap file reading at runtime?

maybe related to DB, check your game_event table. You can change occurrence and see if crashes disappeared or no. It's only my opinion, it's difficult to say what's wrong if you didn't post your server logs, mysql logs or crash dumps here.

Mangos 9637 YTDB 540 mods: couple of patches from my branch http://paste2.org/p/745984 http://paste2.org/p/745979 VERY OFTEN!

does it fixes a crash http://paste2.org/p/745979 (happens without patch) when using pre-loaded maps? Because my server is often fails at map file reading. So if server load maps only once at server start this crash can disappear?

What bug does the patch fix? What features does the patch add? Typo fix For which repository revision was the patch created? 9637 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. --- Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/ReputationMgr.cpp b/src/game/ReputationMgr.cpp index 5cdcdd6..d0d7c2f 100644 --- a/src/game/ReputationMgr.cpp +++ b/src/game/ReputationMgr.cpp @@ -195,7 +195,7 @@ void ReputationMgr::SendVisible(FactionState const* faction) const m_player->SendDirectMessage(&data); } -void ReputationMgr::Initilize() +void ReputationMgr::Initialize() { m_factions.clear(); m_visibleFactionCount = 0; @@ -386,7 +386,7 @@ void ReputationMgr::SetInactive(FactionState* faction, bool inactive) void ReputationMgr::LoadFromDB(QueryResult *result) { // Set initial reputations (so everything is nifty before DB data load) - Initilize(); + Initialize(); //QueryResult *result = CharacterDatabase.PQuery("SELECT faction,standing,flags FROM character_reputation WHERE guid = '%u'",GetGUIDLow()); diff --git a/src/game/ReputationMgr.h b/src/game/ReputationMgr.h index f3c9705..37d4312 100644 --- a/src/game/ReputationMgr.h +++ b/src/game/ReputationMgr.h @@ -124,7 +124,7 @@ class ReputationMgr void SendStates() const; private: // internal helper functions - void Initilize(); + void Initialize(); uint32 GetDefaultStateFlags(const FactionEntry *factionEntry) const; bool SetReputation(FactionEntry const* factionEntry, int32 standing, bool incremental); bool SetOneFactionReputation(FactionEntry const* factionEntry, int32 standing, bool incremental); diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 0a9bcec..d32afa3 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -6544,7 +6544,7 @@ void Spell::DoSummonTotem(SpellEffectIndex eff_idx, uint8 slot_dbc) m_caster->_AddTotem(TotemSlot(slot),pTotem); pTotem->SetOwner(m_caster->GetGUID()); - pTotem->SetTypeBySummonSpell(m_spellInfo); // must be after Create call where m_spells initilized + pTotem->SetTypeBySummonSpell(m_spellInfo); // must be after Create call where m_spells initialized int32 duration=GetSpellDuration(m_spellInfo); if (Player* modOwner = m_caster->GetSpellModOwner()) diff --git a/src/game/World.cpp b/src/game/World.cpp index a09f1e6..5708d4b 100644 --- a/src/game/World.cpp +++ b/src/game/World.cpp @@ -1250,7 +1250,7 @@ void World::SetInitialWorldSettings() mail_timer_expires = uint32( (DAY * IN_MILISECONDS) / (m_timers[WUPDATE_AUCTIONS].GetInterval())); sLog.outDebug("Mail timer set to: %u, mail return is called every %u minutes", mail_timer, mail_timer_expires); - ///- Initilize static helper structures + ///- Initialize static helper structures AIRegistry::Initialize(); Player::InitVisibleBits();

i think it's incorrect, because SendInitialPacketsAfterAddToMap should be used ONLY at player enter to map, i think this is just unneeded sending of info to client. Maybe we can create additional function to place this code into. Maybe something like this in spellauras.cpp void Aura::CustomAuraUpdate(uint32 SpellID) { // Juggernaut & Warbringer both need special packet // for alowing charge in combat and Warbringer // for alowing charge in different stances, too if(m_target->HasAura(SpellID)) { WorldPacket aura_update(SMSG_AURA_UPDATE); aura_update << m_target->GetPackGUID(); aura_update << uint8(255); if(m_target->HasAura(SpellID)) aura_update << uint32(SpellID); aura_update << uint8(19); aura_update << uint8(getLevel()); aura_update << uint8(1); aura_update << uint8(0); m_target->GetSession()->SendPacket(&aura_update); } } and declare it in spellauras.h NTY

Player.cpp change aura_update.append(GetPackGUID()); to aura_update << GetPackGUID(); as already mentioned by Morphau

Mangos 9617 YTDB 540 http://paste2.org/p/734613 http://paste2.org/p/734711

patch updated. Fixed typo.

rewritten version, with flag using diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp index d44df94..9aced18 100644 --- a/src/game/Spell.cpp +++ b/src/game/Spell.cpp @@ -1038,7 +1038,8 @@ void Spell::DoSpellHitOnUnit(Unit *unit, const uint32 effectMask) // Recheck immune (only for delayed spells) if (m_spellInfo->speed && ( unit->IsImmunedToDamage(GetSpellSchoolMask(m_spellInfo)) || - unit->IsImmunedToSpell(m_spellInfo))) + unit->IsImmunedToSpell(m_spellInfo)) && + !(m_spellInfo->Attributes & SPELL_ATTR_UNAFFECTED_BY_INVULNERABILITY)) { if (realCaster) realCaster->SendSpellMiss(unit, m_spellInfo->Id, SPELL_MISS_IMMUNE); @@ -2556,6 +2557,10 @@ void Spell::cast(bool skipCheck) } } + if (m_spellInfo->Id == 32592) + if(const SpellEntry* spellInfo = sSpellStore.LookupEntry(m_spellInfo->Id)) + const_cast<SpellEntry*>(spellInfo)->Attributes |= SPELL_ATTR_UNAFFECTED_BY_INVULNERABILITY; + // different triggred (for caster) and precast (casted before apply effect to target) cases switch(m_spellInfo->SpellFamilyName) { @@ -2648,6 +2653,13 @@ void Spell::cast(bool skipCheck) AddTriggeredSpell(30708); // Totem of Wrath break; } + case SPELLFAMILY_WARRIOR: + { + // Shattering Throw + if (m_spellInfo->Id == 64382) + AddPrecastSpell(64380); // Shattering Throw + break; + } default: break; } diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 9c7d8f8..d347dcb 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -6115,6 +6115,27 @@ void Spell::EffectScriptEffect(SpellEffectIndex eff_idx) } break; } + case SPELLFAMILY_WARRIOR: + { + switch(m_spellInfo->Id) + { + case 64380: // Shattering Throw + { + if (!unitTarget || !unitTarget->isAlive()) + return; + + // remove immunity effects + unitTarget->RemoveAurasDueToSpell(642); // Divine Shield + unitTarget->RemoveAurasDueToSpell(1022); // Hand of Protection rank 1 + unitTarget->RemoveAurasDueToSpell(5599); // Hand of Protection rank 2 + unitTarget->RemoveAurasDueToSpell(10278); // Hand of Protection rank 3 + unitTarget->RemoveAurasDueToSpell(19753); // Divine Intervention + unitTarget->RemoveAurasDueToSpell(45438); // Ice Block + break; + } + } + break; + } } // normal DB scripted effect diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 5bfe192..e0743f3 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -2932,18 +2932,23 @@ SpellMissInfo Unit::SpellHitResult(Unit *pVictim, SpellEntry const *spell, bool if (pVictim->GetTypeId()==TYPEID_UNIT && ((Creature*)pVictim)->IsInEvadeMode()) return SPELL_MISS_EVADE; - // Check for immune - if (pVictim->IsImmunedToSpell(spell)) - return SPELL_MISS_IMMUNE; + if (!(spell->Attributes & SPELL_ATTR_UNAFFECTED_BY_INVULNERABILITY)) + { + // Check for immune + if (pVictim->IsImmunedToSpell(spell)) + return SPELL_MISS_IMMUNE; - // All positive spells can`t miss - // TODO: client not show miss log for this spells - so need find info for this in dbc and use it! - if (IsPositiveSpell(spell->Id)) - return SPELL_MISS_NONE; + // All positive spells can`t miss + // TODO: client not show miss log for this spells - so need find info for this in dbc and use it! + if (IsPositiveSpell(spell->Id) && IsFriendlyTo(pVictim)) + return SPELL_MISS_NONE; - // Check for immune - if (pVictim->IsImmunedToDamage(GetSpellSchoolMask(spell))) - return SPELL_MISS_IMMUNE; + // Check for immune + if (pVictim->IsImmunedToDamage(GetSpellSchoolMask(spell))) + return SPELL_MISS_IMMUNE; + } + else if (IsPositiveSpell(spell->Id) && IsFriendlyTo(pVictim)) + return SPELL_MISS_NONE; // Try victim reflect spell if (CanReflect) As said one of my offy testers, spell doesn't gets "Immune" at hit target under immunity effects, maybe PreCast method to fix this is wrong, it should cast one of spells 64380 or 64382, 64380 if target is immuned, 64382 if target without any immunity auras. another problem: i was added this flag (to ignore immunity's) for spell 32592 because spell divided on three parts, main part has this flag, then main spell triggers second spell (spell 32592 _doesn't_ have this flag and gets immune), second spell triggers last spell that should dispel immunity on target and have this flag too. So you can't dispel bubble from paladin because second spell fails from immune.

Core: 9564 http://paste2.org/p/716069 new http://paste2.org/p/716072 http://paste2.org/p/716075 new http://paste2.org/p/716076 http://paste2.org/p/716080 http://paste2.org/p/716081 http://paste2.org/p/716086 http://paste2.org/p/716090

new crash appear after this http://paste2.org/p/711987 What i can say... 3.3.2 isn't stable at all. Uptime ~1-5 hours with online ~200 ppl (with some stability increase patches)

core: 9564 db: YTDB 537 patches: my modified branch with patches... but this is a new crash related to latest changes in mangos #0 0x00517903 in malloc_consolidate () from /lib/libc.so.6 No symbol table info available. #1 0x00519ce3 in _int_malloc () from /lib/libc.so.6 No symbol table info available. #2 0x0051bd87 in malloc () from /lib/libc.so.6 No symbol table info available. #3 0x052f5ab7 in operator new () from /usr/lib/libstdc++.so.6 No symbol table info available. #4 0x0829052e in std::vector<__gnu_cxx::_Hashtable_node<std::Pair<Player* const, UpdateData> >*, std::allocator<__gnu_cxx::_Hashtable_node<std::Pair<Player* const, UpdateData> >*> >::reserve (this=0xafcfd0ec, __n=193) at /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/ext/new_allocator.h:88 __tmp = <value optimized out> #5 0x082761c4 in Map::SendObjectUpdates (this=0x172fcb48) at /usr/lib/gcc/i386-redhat-linux/4.1.2/../../../../include/c++/4.1.2/ext/hashtable.h:581 update_players = {_M_ht = { _M_node_allocator = {<__gnu_cxx::new_allocator<__gnu_cxx::_Hashtable_node<std::Pair<Player* const, UpdateData> > >> = {<No data fields>}, <No data fields>}, _M_hash = {<No data fields>}, _M_equals = {<std::binary_function<Player*,Player*,bool>> = {<No data fields>}, <No data fields>}, ---Type <return> to continue, or q <return> to quit---return _M_get_key = {<std::unary_function<std::Pair<Player* const, UpdateData>,Player* const>> = {<No data fields>}, <No data fields>}, _M_buckets = {<std::_Vector_base<__gnu_cxx::_Hashtable_node<std::Pair<Player* const, UpdateData> >*,std::allocator<__gnu_cxx::_Hashtable_node<std::Pair<Player* const, UpdateData> >*> >> = { _M_impl = {<std::allocator<__gnu_cxx::_Hashtable_node<std::Pair<Player* const, UpdateData> >*>> = {<__gnu_cxx::new_allocator<__gnu_cxx::_Hashtable_node<std::Pair<Player* const, UpdateData> >*>> = {<No data fields>}, <No data fields>}, _M_start = 0x0, _M_finish = 0x0, _M_end_of_storage = 0x0}}, <No data fields>}, _M_num_elements = 0}} packet = {<ByteBuffer> = {static DEFAULT_SIZE = 4096, _rpos = 2949632628, _wpos = 26, _storage = {<std::_Vector_base<unsigned char,std::allocator<unsigned char> >> = { _M_impl = {<std::allocator<unsigned char>> = {<__gnu_cxx::new_allocator<unsigned char>> = {<No data fields>}, <No data fields>}, _M_start = 0xafcfd0f8 "", _M_finish = 0x828d8aa "\\213C\\004\\213\\b\\205▒t\\r\\203▒\\004\\205▒\\211▒u▒\\215t&", _M_end_of_storage = 0x183a1ed8 "(\\021V\\b\\t"}}, <No data fields>}}, m_opcode = 149} #6 0x0828bd41 in Map::Update (this=0x172fcb48, t_diff=@0xafcfd2b8) at ../../../src/game/Map.cpp:698 updater = {i_timeDiff = 149} __PRETTY_FUNCTION__ = "virtual void Map::Update(const uint32&)" #7 0x0829a435 in MapManager::Update (this=0xcb79228, diff=50) at ../../../src/game/MapManager.cpp:265 iter = {_M_cur = 0x1714af80, _M_ht = 0xcb79270} #8 0x0844b4b9 in World::Update (this=0x9abd928, diff=50) at ../../../src/game/World.cpp:1411 autobroadcaston = 0 r#9 0x0813ce2a in WorldRunnable::run (this=0xeac2118) at ../../../src/mangosd/WorldRunnable.cpp:60 diff = 50 realCurrTime = 1328734445 realPrevTime = <value optimized out> prevSleepTime = 49 #10 0x08514abd in ACE_Based::Thread::ThreadTask (param=0xeac2118) at ../../../src/shared/Threading.cpp:187 No locals. #11 0x00a760d7 in ACE_OS_Thread_Adapter::invoke () from /usr/local/mangos/lib/libACE-5.6.6.so No symbol table info available. #12 0x00a22601 in ace_thread_adapter () from /usr/local/mangos/lib/libACE-5.6.6.so No symbol table info available. #13 0x0062c73b in start_thread () from /lib/libpthread.so.0 No symbol table info available. log file with log level 3!!! Just take a look for player with guid 47546 http://paste2.org/p/712102 This was crashed my server every 1-5 minutes until i disabled this spell (by custom spell disabling system)

Wowka's patch works for me.

new crash, appeared after 9560 http://paste2.org/p/711987

really ? if you found from what revision it started, then i can try to fix it :cool:

Core: 9564 http://paste2.org/p/711781 new http://paste2.org/p/711783 http://paste2.org/p/711784 many times http://paste2.org/p/711785 http://paste2.org/p/711786 http://paste2.org/p/711787 http://paste2.org/p/711789 http://paste2.org/p/711792 new http://paste2.org/p/711794 http://paste2.org/p/711796 new http://paste2.org/p/711797 http://paste2.org/p/711869 http://paste2.org/p/712022 http://paste2.org/p/712024 new http://paste2.org/p/712028 new http://paste2.org/p/712048 about 50 crashes for 24 hours :lol:

for 9564 http://paste2.org/p/710458 or http://github.com/insider42/mangos/commit/5eda5906a4fcdd1e88452b1843e3ebea7d25cf18

What bug does the patch fix? What features does the patch add? Fixes spell http://www.wowhead.com/?spell=56845 For which repository revision was the patch created? 9560 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. none Who has been writing this patch? Please include either forum user names or email addresses. me diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 8391745..a87f4d9 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -6578,6 +6578,19 @@ void Aura::HandleSpellSpecificBoosts(bool apply) spellId3 = 24397; spellId4 = 26592; } + // Freezing Trap Effect + else if (m_spellProto->SpellFamilyFlags & UI64LIT(0x0000000000000008)) + { + if(!apply) + { + // Glyph of Freezing Trap + if (Unit *caster = GetCaster()) + if (caster->HasAura(56845)) + m_target->CastSpell(m_target, 61394, true, NULL, this, GetCasterGUID()); + } + else + return; + } // Aspect of the Dragonhawk dodge else if (GetSpellProto()->SpellFamilyFlags2 & 0x00001000) { commit http://github.com/insider42/mangos/commit/31d65e26b6dc557ab6034ade35fc6fff7b2ab2e9 But there still presents a bug with wrong shown caster in combat logs, also doesn't work one talent in survival becasue of bug when trap _spells_ uses target guid, not original caster. For example you can simple check this bug on clean (without any patches) mangos: select any hostile target in 15 yards, write command .cast 3355 (this is freezing trap or 13797 - from immolation trap), target will be freezed, BUT check your combat logs - "TARGET will use spell at target", but should be "YOU uses spell at target" - it's a serious bug.

Confirmed, bug with cooldown still exists in 9556. But it doesn't crashes for me. Bug is easy to reproduce... we need to make a fix

Confirmed, resurrect button clickable, but doesn't make any effect, you still stay in ghost mode and can press resurrection button again and again

Server crashes like a hell. Uptime from 10 seconds to 5 minutes. Dump http://paste2.org/p/708597 . Introduced somewhere in 9550-9551