KAPATEJIb

yeah, good fix. and spell have incorrect spell proc info. This once i found in trinity core repository (author n0n4m3) UPDATE spell_proc_event SET SchoolMask = 4, spellFamilyMask1 = 200776, spellFamilyMask0 = 146800663 WHERE entry = 11129; Tested in game - works good.

temporary fix you can get here http://github.com/insider42/mangos/commit/636cc0b857d3b75e0f264533076c4c33791811fd

about [9082]: for example if your scripts doesn't support 25man version you anyway make 10man version of spells to cast in 25man but with other number of affected target - this is wrong. I think 9082 should be reverted because this commit is _useless_

So... maybe something like this? src/game/Unit.cpp | 10 +++++++--- 1 files changed, 7 insertions(+), 3 deletions(-) diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index cf6594a..4627bf5 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -7360,6 +7360,7 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB // Deep Wounds (replace triggered spells to directly apply DoT), dot spell have finilyflags if (auraSpellInfo->SpellFamilyFlags == UI64LIT(0x0) && auraSpellInfo->SpellIconID == 243) { + float damage; float weaponDamage; // DW should benefit of attack power, damage percent mods etc. // TODO: check if using offhand damage is correct and if it should be divided by 2 @@ -7370,14 +7371,17 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB switch (auraSpellInfo->Id) { - case 12834: basepoints[0] = int32(weaponDamage * 16 / 100); break; - case 12849: basepoints[0] = int32(weaponDamage * 32 / 100); break; - case 12867: basepoints[0] = int32(weaponDamage * 48 / 100); break; + case 12834: damage = int32(weaponDamage * 16 / 100); break; + case 12849: damage = int32(weaponDamage * 32 / 100); break; + case 12867: damage = int32(weaponDamage * 48 / 100); break; // Impossible case default: return false; } + // 1 tick/sec * 6 sec = 6 ticks + basepoints[0] = int32(damage / 6); + trigger_spell_id = 12721; break; } EDIT: ok, i see you already fix it in 9081. Thanks

What bug does the patch fix? What features does the patch add? added spell_chain entry for spell http://www.wowhead.com/?spell=50245 and http://www.wowhead.com/?spell=50519 For which repository revision was the patch created? any Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. can't find any Who has been writing this patch? Please include either forum user names or email addresses. Me /* Pin */ DELETE FROM spell_chain WHERE first_spell = 50519; INSERT INTO spell_chain VALUES (50519, 0, 50519, 1, 0), (53564, 50519, 50519, 2, 0), (53565, 53564, 50519, 3, 0), (53566, 53565, 50519, 4, 0), (53567, 53566, 50519, 5, 0), (53568, 53567, 50519, 6, 0); /* Sonic Blast */ DELETE FROM spell_chain WHERE first_spell = 50245; INSERT INTO spell_chain VALUES (50245, 0, 50245, 1, 0), (53544, 50245, 50245, 2, 0), (53545, 53544, 50245, 3, 0), (53546, 53545, 50245, 4, 0), (53547, 53546, 50245, 5, 0), (53548, 53547, 50245, 6, 0); this prevents a bug with using different ranks of spells without cooldown, because they doesn't share cooldown

try this diff --git a/src/game/Spell.cpp b/src/game/Spell.cpp index 3f24bbd..1aef452 100644 --- a/src/game/Spell.cpp +++ b/src/game/Spell.cpp @@ -1318,6 +1318,14 @@ void Spell::SetTargetMap(uint32 effIndex,uint32 targetMode,UnitList& TagUnitMap) break; } + switch(m_spellInfo->Id) + { + case 31298: // Sleep + unMaxTargets = 3; + default: + break; + } + Unit::AuraList const& mod = m_caster->GetAurasByType(SPELL_AURA_MOD_MAX_AFFECTED_TARGETS); for(Unit::AuraList::const_iterator m = mod.begin(); m != mod.end(); ++m) {

are you sure? spell casted one time by one caster (pet) on two targets because of Effect: (006) SPELL_EFFECT_APPLY_AURA Base point = 60 Target A (TARGET_SELF), Target B (No target) <-- THIS Aura (031) SPELL_AURA_MOD_INCREASE_SPEED, value = 60, misc = 0, miscB = 0, periodic = 0 Effect: (006) SPELL_EFFECT_APPLY_AURA Base point = 60 Target A (TARGET_MASTER), Target B (No target) <-- AND THIS Aura (031) SPELL_AURA_MOD_INCREASE_SPEED, value = 60, misc = 0, miscB = 0, periodic = 0

Now, having received information from offy i updated the patch. Ranged hits and spells should get DODGE if your target under effect of Deterrence. That how it works on Russian official servers I hope that all bugs fixed with this spell

patch updated. Removed "behind" check for parry with this spell and implemented aura 288 I have no idea how to avoid checks like that if (!pVictim->HasInArc(M_PI,this) && !pVictim->HasAura(19263)) but it works popovk, you are absolutely right about that. spell aura 287 should deflect only spells, but on clean mangos it deflects both - ranged hits and spells. For ranged hits we should use spell aura 288. I was fixed this.

ok, i found a problem with parry chance from spell, this because my character doesn't have a parry spell :lol: is it ok? how it works on offy? I need more info about spell... also spell should parry from behind, maybe we need add exception to parry handling

it's related to other patch as i understand, because can't reprocude bug with clean+patch, but additional check not interfere and prevent from spam with error "spell is not ready" on your screen. thanks

delete this post

Confirmed, very serious bug. We (mangos users) should disable this talent until it fixed

What bug does the patch fix? What features does the patch add? fixes insane damage from http://www.wowhead.com/?spell=62124 , spell should get bonus only from attack power, not from spell power For which repository revision was the patch created? any after 8910 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. no Who has been writing this patch? Please include either forum user names or email addresses. Me ALTER TABLE `spell_bonus_data` CHANGE `entry` `entry` mediumint(8) unsigned NOT NULL default '0'; delete from `spell_bonus_data` where `entry` = 67485; insert into `spell_bonus_data` values (67485,0,0,0,'Paladin - Hand of Reckoning');

no, my priest does insane damage without shadow form, without crit damage 8000+ with 2400 spell damage; 11000+ when crit. bug still exists in 9071

no no, this tested without any items and talents, only with weapon from game start so expertise isn't source of problem, this effect doesn't work at all

this one for Hunger for Blood, Rend and tear after 9069+ http://paste2.org/p/578513

but there is another bug still exists (on clean and with patch) - spell not gives 100% chance to parry melee attacks. I doesn't know how to fix it

maybe "accepted in [9071]"?

*EDITED* problem solved

What bug does the patch fix? What features does the patch add? fixed for talent http://www.wowhead.com/?spell=48516For which repository revision was the patch created? 9062 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. no Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 15cbf8c..616ca27 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -5841,6 +5841,8 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu // Wrath crit if (procSpell->SpellFamilyFlags & UI64LIT(0x0000000000000001)) { + if (this->HasAura(48517)) + return false; if (!roll_chance_i(60)) return false; triggered_spell_id = 48518; @@ -5850,6 +5852,8 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu // Starfire crit if (procSpell->SpellFamilyFlags & UI64LIT(0x0000000000000004)) { + if (this->HasAura(48518)) + return false; triggered_spell_id = 48517; target = this; break; Also i can't understand why if (!roll_chance_i(60)) return false; is used? This broke a chance to proc for 1 and 3 rank of talent, maybe we should add a switch (auraSpellInfo->Id) then make a case for every rank with their chances (20% for 1, 40% for 2, 60% for 3)?

What bug does the patch fix? What features does the patch add? fixes talent http://www.wowhead.com/?spell=18096 as it should work with 3.2.2 patch For which repository revision was the patch created? 9061 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. no Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 15cbf8c..0d6a233 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -7047,32 +7047,14 @@ bool Unit::HandleProcTriggerSpell(Unit *pVictim, uint32 damage, Aura* triggeredB // Pyroclasm if (auraSpellInfo->SpellIconID == 1137) { - if(!pVictim || !pVictim->isAlive() || pVictim == this || procSpell == NULL) - return false; - // Calculate spell tick count for spells - uint32 tick = 1; // Default tick = 1 - - // Hellfire have 15 tick - if (procSpell->SpellFamilyFlags & UI64LIT(0x0000000000000040)) - tick = 15; - // Rain of Fire have 4 tick - else if (procSpell->SpellFamilyFlags & UI64LIT(0x0000000000000020)) - tick = 4; - else - return false; - - // Calculate chance = baseChance / tick - float chance = 0; switch (auraSpellInfo->Id) { - case 18096: chance = 13.0f / tick; break; - case 18073: chance = 26.0f / tick; break; + case 18096: trigger_spell_id = 18093; break; // Rank 1 + case 18073: trigger_spell_id = 63243; break; // Rank 2 + case 63245: trigger_spell_id = 63244; break; // Rank 3 + default: + return false; } - // Roll chance - if (!roll_chance_f(chance)) - return false; - - trigger_spell_id = 18093; } // Drain Soul else if (auraSpellInfo->SpellFamilyFlags & UI64LIT(0x0000000000004000)) i hope i make a correct SQL file /* Pyroclasm */ DELETE FROM `spell_proc_event` WHERE entry IN(18073,18096,63245); INSERT INTO `spell_proc_event` VALUES (18073,0,5,256,8388608,0,0,2,0,0,0), (18096,0,5,256,8388608,0,0,2,0,0,0), (63245,0,5,256,8388608,0,0,2,0,0,0);

but what about SQL part? it's still useful?

here a crash with .lookup quest command http://paste2.org/p/577889 how to reproduce: need to have a russian client and dbc, then try to .lookup quest 213й побег for example, it can crash with different quest names, not only with this quest.

take a look at my comments in http://github.com/mangos/mangos/commit/81b4744c505dba04de87afd55686a733979aa7ac