KAPATEJIb

http://filebeam.com/995272805b9c15b4fc8280d824da614c

it's correct? case SPELL_EFFECT_ENCHANT_ITEM: { if(Item* targetItem = m_targets.getItemTarget()) { if(targetItem->GetProto()->Class != m_spellInfo->EquippedItemClass || ((1<<targetItem->GetProto()->SubClass) & m_spellInfo->EquippedItemSubClassMask)==0) return SPELL_FAILED_BAD_TARGETS; } if(m_spellInfo->EffectItemType[i] && m_targets.getItemTarget()) { if(m_targets.getItemTarget()->IsWeaponVellum() || m_targets.getItemTarget()->IsArmorVellum()) { ItemPosCountVec dest; uint8 msg = ((Player*)m_caster)->CanStoreNewItem( NULL_BAG, NULL_SLOT, dest, m_spellInfo->EffectItemType[i], 1 ); if(msg != EQUIP_ERR_OK) { ((Player*)m_caster)->SendEquipError( msg, NULL, NULL ); return SPELL_FAILED_DONT_REPORT; } } }

That patch have one exploit, you can cheat with item changing with ArtMoney program. For example if you want to enchant Mongoose to Helm you can change some values in memory with artmoney for using it on any item ID that you set as new value. I know my english is bad, if you can't understand me you can read original bugreport, it is here http://getmangos.ru/forum/showpost.php?p=275177&postcount=8 but you need 250 post to read it . Maybe author of patch should ask to Wowka321 with "how to reproduce"

What bug does the patch fix? What features does the patch add? It fixes dependence of ranks for spell http://www.wowhead.com/?spell=63668 (All ranks) For which repository revision was the patch created? Any Who has been writing this patch? Please include either forum user names or email addresses. Me insert into spell_chain values (3674,0,3674,1,0); insert into spell_chain values (63668,3674,3674,2,0); insert into spell_chain values (63669,63668,3674,3,0); insert into spell_chain values (63670,63669,3674,4,0); insert into spell_chain values (63671,63670,3674,5,0); insert into spell_chain values (63672,63671,3674,6,0);

http://getmangos.ru/forum/showthread.php?t=20533 it fixes Conflagrate and Glyph of Conflagrate

Here is another patch http://getmangos.ru/forum/showpost.php?p=275163&postcount=9

My version tested many times and works perfect.

Can you post a author in next time? I think original author of patch Arthorius, then it modified a bit by MaS0n (Tanatos)

already posted at http://getmangos.ru/forum/showthread.php?t=20604

What bug does the patch fix? What features does the patch add? It fixes a typo after 8082 . That typo cause Crippling Poison to be affected by diminishing For which repository revision was the patch created? 8108 Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. Can't find any Who has been writing this patch? Please include either forum user names or email addresses. zuudu diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp index 23b2762..e8e57b7 100644 --- a/src/game/SpellMgr.cpp +++ b/src/game/SpellMgr.cpp @@ -2787,7 +2787,7 @@ DiminishingGroup GetDiminishingReturnsGroupForSpell(SpellEntry const* spellproto if (mechanic & (1<<MECHANIC_FEAR)) return DIMINISHING_FEAR_BLIND; if (mechanic & (1<<MECHANIC_CHARM)) return DIMINISHING_CHARM; if (mechanic & (1<<MECHANIC_SILENCE)) return DIMINISHING_SILENCE; - if (mechanic & (1<<DIMINISHING_DISARM)) return DIMINISHING_DISARM; + if (mechanic & (1<<MECHANIC_DISARM)) return DIMINISHING_DISARM; if (mechanic & (1<<MECHANIC_FREEZE)) return DIMINISHING_FREEZE_SLEEP; if (mechanic & ((1<<MECHANIC_KNOCKOUT) | (1<<MECHANIC_SAPPED))) return DIMINISHING_POLYMORPH_GOUGE_SAP; if (mechanic & (1<<MECHANIC_BANISH)) return DIMINISHING_BANISH;

Good one, i will test it. Patch in first post works perfect.

i didn't test your patch, because i use own in my compiled binaries and server. Thank you for finding a correct check of complete absorb (m_removeMode == AURA_REMOVE_BY_DEFAULT && !m_modifier.m_amount) diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 5808127..951b4f8 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -5702,6 +5702,23 @@ void Aura::HandleSchoolAbsorb(bool apply, bool Real) m_modifier.m_amount += (int32)DoneActualBenefit; } + else + // Shattered Barrier + if (m_spellProto->SpellIconID == 32 && m_spellProto->SpellFamilyName == SPELLFAMILY_MAGE) + { + Unit* caster = GetCaster(); + if (!((m_removeMode == AURA_REMOVE_BY_DEFAULT && !m_modifier.m_amount) || m_removeMode == AURA_REMOVE_BY_DISPEL)) + return; + + if (caster->HasAura(44745) && roll_chance_i(50)) + { + caster->CastSpell(caster, 55080, true); + } + if (caster->HasAura(54787)) + { + caster->CastSpell(caster, 55080, true); + } + } if (!apply && caster && // Power Word: Shield

I think original creator is QAston from Trinity

When a priest with picked talent "Reflective Shield" uses "Power word: Shield" on self and attacks a mage with molten armor - server crashes Revision: * * 8059 ea6f3eca146f15280461a879037689473a1c4664 Date 21:6:2009. Time 21:53 //===================================================== *** Hardware *** Processor: Intel(R) Core(TM)2 Duo CPU E4500 @ 2.20GHz Number Of Processors: 2 Physical Memory: 2095396 KB (Available: 1031788 KB) Commit Charge Limit: 3943456 KB *** Operation System *** Microsoft Windows Server 2003 Enterprise Edition Service Pack 2 (Version 5.2, Build 3790) //===================================================== Exception code: C00000FD STACK_OVERFLOW Fault address: 00438757 01:00037757 C:\\WoW Server\\wow\\amani_wotlk_server\\mangosd.exe Registers: EAX:068D2000 EBX:1A697660 ECX:068CBEF8 EDX:07982FCC ESI:00000000 EDI:008F2B40 CS:EIP:0023:00438757 SS:ESP:002B:068DB270 EBP:068DB284 DS:002B ES:002B FS:0053 GS:002B Flags:00010206 Call stack: Address Frame Function SourceFile 00438757 00000000 _chkstk+27 00706F67 00000000 Spell::CheckCast+D67 007006EF 00000000 Spell::Prepare+1BF 0046213D 00000000 Unit::CastCustomSpell+16D 00461FC2 00000000 Unit::CastCustomSpell+82 00464FF4 00000000 Unit::CalcAbsorbResist+B64 004628DA 00000000 Unit::CalculateSpellDamage+39A 006FBDAE 00000000 Spell::DoAllEffectOnTarget+38E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 00461F05 00000000 Unit::CastSpell+1B5 00461D48 00000000 Unit::CastSpell+118 00474E5E 00000000 Unit::HandleProcTriggerSpell+1A1E 00483235 00000000 Unit::ProcDamageAndSpellFor+805 0046E633 00000000 Unit::ProcDamageAndSpell+73 006FBE3E 00000000 Spell::DoAllEffectOnTarget+41E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 0046213D 00000000 Unit::CastCustomSpell+16D 00461FC2 00000000 Unit::CastCustomSpell+82 00464FF4 00000000 Unit::CalcAbsorbResist+B64 004628DA 00000000 Unit::CalculateSpellDamage+39A 006FBDAE 00000000 Spell::DoAllEffectOnTarget+38E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 00461F05 00000000 Unit::CastSpell+1B5 00461D48 00000000 Unit::CastSpell+118 00474E5E 00000000 Unit::HandleProcTriggerSpell+1A1E 00483235 00000000 Unit::ProcDamageAndSpellFor+805 0046E633 00000000 Unit::ProcDamageAndSpell+73 006FBE3E 00000000 Spell::DoAllEffectOnTarget+41E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 0046213D 00000000 Unit::CastCustomSpell+16D 00461FC2 00000000 Unit::CastCustomSpell+82 00464FF4 00000000 Unit::CalcAbsorbResist+B64 004628DA 00000000 Unit::CalculateSpellDamage+39A 006FBDAE 00000000 Spell::DoAllEffectOnTarget+38E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 00461F05 00000000 Unit::CastSpell+1B5 00461D48 00000000 Unit::CastSpell+118 00474E5E 00000000 Unit::HandleProcTriggerSpell+1A1E 00483235 00000000 Unit::ProcDamageAndSpellFor+805 0046E633 00000000 Unit::ProcDamageAndSpell+73 006FBE3E 00000000 Spell::DoAllEffectOnTarget+41E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 0046213D 00000000 Unit::CastCustomSpell+16D 00461FC2 00000000 Unit::CastCustomSpell+82 00464FF4 00000000 Unit::CalcAbsorbResist+B64 004628DA 00000000 Unit::CalculateSpellDamage+39A 006FBDAE 00000000 Spell::DoAllEffectOnTarget+38E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 00461F05 00000000 Unit::CastSpell+1B5 00461D48 00000000 Unit::CastSpell+118 00474E5E 00000000 Unit::HandleProcTriggerSpell+1A1E 00483235 00000000 Unit::ProcDamageAndSpellFor+805 0046E633 00000000 Unit::ProcDamageAndSpell+73 006FBE3E 00000000 Spell::DoAllEffectOnTarget+41E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 0046213D 00000000 Unit::CastCustomSpell+16D 00461FC2 00000000 Unit::CastCustomSpell+82 00464FF4 00000000 Unit::CalcAbsorbResist+B64 004628DA 00000000 Unit::CalculateSpellDamage+39A 006FBDAE 00000000 Spell::DoAllEffectOnTarget+38E 00701502 00000000 Spell::handle_immediate+122 00701305 00000000 Spell::cast+6E5 007007F3 00000000 Spell::Prepare+2C3 00461F05 00000000 Unit::CastSpell+1B5 00461D48 00000000 Unit::CastSpell+118 00474E5E 00000000 Unit::HandleProcTriggerSpell+1A1E 00483235 00000000 Unit::ProcDamageAndSpellFor+805 0046E633 00000000 Unit::ProcDamageAndSpell+73 00465C83 00000000 Unit::AttackerStateUpdate+1A3 004CEFEA 00000000 Player::Update+5EA 004AABF9 00000000 Map::Update+D9 006660DA 00000000 MapManager::Update+17A 00641B22 00000000 World::Update+7E2 004385AE 00000000 WorldRunnable::run+8E 008F2B57 00000000 ACE_Based::Thread::ThreadTask+17 00BE14D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61C828 00000000 ZwWaitForSingleObject+15 7D4D8BF1 00000000 WaitForSingleObject+12 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 008F2D70 00000000 ACE_Based::Thread::Sleep+30 008F9921 00000000 SqlDelayThread::run+31 008F2B57 00000000 ACE_Based::Thread::ThreadTask+17 00BE14D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 008F2D70 00000000 ACE_Based::Thread::Sleep+30 008F9921 00000000 SqlDelayThread::run+31 008F2B57 00000000 ACE_Based::Thread::ThreadTask+17 00BE14D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61CCA8 00000000 ZwDelayExecution+15 7D4D14EF 00000000 Sleep+F 008F2D70 00000000 ACE_Based::Thread::Sleep+30 008F9921 00000000 SqlDelayThread::run+31 008F2B57 00000000 ACE_Based::Thread::ThreadTask+17 00BE14D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136 Call stack: Address Frame Function SourceFile 7D61D6C6 00000000 ZwGetContextThread+12 068DA294 00000000 0000:00000000 FF50D845 FFFFFFFF Crash fixed in 8068

As i see, that patch is already commited by Hunuza in 8062. Thanks

3408 uses other spell effect. Patch is correct and tested for a long time on many servers (because used in my compiled binaries )...

What bug does the patch fix? What features does the patch add? It fixes a wrong trigger spellId For which repository revision was the patch created? 8052 Who has been writing this patch? Please include either forum user names or email addresses. Alez diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index 4c1f8bd..5cf1e96 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -5386,7 +5386,7 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu // Deadly Brew if( dummySpell->SpellIconID == 2963 ) { - triggered_spell_id = 25809; + triggered_spell_id = 44289; break; } // Quick Recovery

patch works without side effects or other problems, thanks

What bug does the patch fix? What features does the patch add? It should fix a bug, with group members that teleported to leader's BG start point on BG ending. For which repository revision was the patch created? 8039 Who has been writing this patch? Please include either forum user names or email addresses. Me diff --git a/src/game/BattleGroundHandler.cpp b/src/game/BattleGroundHandler.cpp index 04965cd..3f903a9 100644 --- a/src/game/BattleGroundHandler.cpp +++ b/src/game/BattleGroundHandler.cpp @@ -162,7 +162,7 @@ void WorldSession::HandleBattlemasterJoinOpcode( WorldPacket & recv_data ) uint32 queueSlot = member->AddBattleGroundQueueId(bgQueueTypeId); // add to queue // store entry point coords (same as leader entry point) - member->SetBattleGroundEntryPoint(_player->GetMapId(),_player->GetPositionX(),_player->GetPositionY(),_player->GetPositionZ(),_player->GetOrientation()); + member->SetBattleGroundEntryPoint(member->GetMapId(),member->GetPositionX(),member->GetPositionY(),member->GetPositionZ(),member->GetOrientation()); WorldPacket data; // send status packet (in queue) Paste2.org

patch diff --git a/src/game/SkillDiscovery.cpp b/src/game/SkillDiscovery.cpp index dbbbc48..9a76347 100644 --- a/src/game/SkillDiscovery.cpp +++ b/src/game/SkillDiscovery.cpp @@ -54,7 +54,7 @@ void LoadSkillDiscoveryTable() // 0 1 2 3 QueryResult *result = WorldDatabase.Query("SELECT spellId, reqSpell, reqSkillValue, chance FROM skill_discovery_template"); - if (result) + if (!result) { sLog.outString(); sLog.outString( ">> Loaded 0 skill discovery definitions. DB table `skill_discovery_template` is empty." );

Really? I've already tested clean mangos 3.1.3 (8014 rev) and doesn't see that bug.. I think it is fixed when mangos was swithed to 3.1.2. Someone can confirm that?:confused:

Patch works as should, no side effects. Good work.

You are right. So INSERT INTO `spell_proc_event` VALUES (53736,1,0,0,0,0,0,0,20,0,0); update spell_proc_event set SchoolMask=1 where entry in (20375,31801); INSERT INTO `spell_proc_event` VALUES (53720,1,0,0,0,0,0,0,0,0,0); INSERT INTO `spell_proc_event` VALUES (31892,1,0,0,0,0,0,0,0,0,0); Should fix our problem.

patch needs in update for 3.1.3

Tested, works as should. Thanks