KAPATEJIb

Fixed in hackish form in my repo, but you need to use both patches (17 and this) or apply it manually http://github.com/insider42/mangos/commit/3851daef08ccf708ddc87f0e30c0ee55c15a35cc anyway spell won't remove immunities if you add precast spell. I just allowed spell 64382 to remove immunity effects and it works.

there is no working version of patch?

previous patch for clean mangos http://paste2.org/p/574708

taken from your last post diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 4f4b4b9..1929f1f 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -5668,6 +5668,9 @@ void Spell::EffectSanctuary(uint32 /*i*/) if(m_spellInfo->SpellFamilyName == SPELLFAMILY_ROGUE && (m_spellInfo->SpellFamilyFlags & SPELLFAMILYFLAG_ROGUE_VANISH)) { ((Player *)m_caster)->RemoveSpellsCausingAura(SPELL_AURA_MOD_ROOT); + // Overkill + if(((Player*)m_caster)->HasSpell(58426)) + m_caster->CastSpell(m_caster, 58427, true); } }

Woweur, you forgot to write your patch list in last post can you reproduce that crash on _clean_ core? Maybe related to Vellums patch.

this spell doesn't work on clean mangos

i can't reproduce your bug with this patch. Cooldown works correctly for me. And there is no absorb - talent works like cheat death spell with healing

As i understand you talk about a problem when SD and ToB buffs replace each other here a simple solution diff --git a/src/game/SpellMgr.cpp b/src/game/SpellMgr.cpp index bc98152..eebd0d9 100644 --- a/src/game/SpellMgr.cpp +++ b/src/game/SpellMgr.cpp @@ -1497,6 +1497,11 @@ bool SpellMgr::IsNoStackSpellDueToSpell(uint32 spellId_1, uint32 spellId_2) cons if( (spellInfo_1->SpellIconID == 456 && spellInfo_2->SpellIconID == 2006) || (spellInfo_2->SpellIconID == 456 && spellInfo_1->SpellIconID == 2006) ) return false; + + // Taste of Blood and Sudden Death + if( (spellInfo_1->Id == 52437 && spellInfo_2->Id == 60503) || + (spellInfo_2->Id == 52437 && spellInfo_1->Id == 60503) ) + return false; } // Hamstring -> Improved Hamstring (multi-family check) Does anyone know how to fix a bug that described in my previous post?

warrior still can use Charge in combat after talent reseting if Juggernaut was taken in previous talent build - it's a big exploit for dual spec patch users. This is normal ? 2>Spell.cpp 2>..\\..\\src\\game\\Spell.cpp(4149) : warning C4806: '&' : unsafe operation: no value of type 'bool' promoted to type 'unsigned __int64' can equal the given constant

can you post a crash dumps? It doesn't crash for me on 9010+patch

this one http://github.com/insider42/mangos/commit/daf89c0ee3f8b3d3a2d41d1b4ed8e0c0344894bc should work after 9008

diff --git a/src/game/SpellAuras.cpp b/src/game/SpellAuras.cpp index 993753e..93ba68b 100644 --- a/src/game/SpellAuras.cpp +++ b/src/game/SpellAuras.cpp @@ -2974,6 +2974,7 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) switch(form) { case FORM_CAT: + case FORM_SHADOW_DANCE: PowerType = POWER_ENERGY; break; case FORM_BEAR: @@ -3040,7 +3041,8 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) if(m_target->m_ShapeShiftFormSpellId) m_target->RemoveAurasDueToSpell(m_target->m_ShapeShiftFormSpellId, this); - m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, form); + // For Shadow Dance we must apply Stealth form (30) instead of current (13) + m_target->SetByteValue(UNIT_FIELD_BYTES_2, 3, (form == FORM_SHADOW_DANCE) ? uint8(FORM_STEALTH) : form); if(modelid > 0) m_target->SetDisplayId(modelid); @@ -3105,6 +3107,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) m_target->SetPower(POWER_RAGE, Rage_val); break; } + // Shadow Dance - apply stealth mode stand flag + case FORM_SHADOW_DANCE: + m_target->SetStandFlags(UNIT_STAND_FLAGS_CREEP); + break; default: break; } @@ -3137,6 +3143,10 @@ void Aura::HandleAuraModShapeshift(bool apply, bool Real) if(Aura* dummy = m_target->GetDummyAura(37324) ) m_target->CastSpell(m_target, 37325, true, NULL, dummy); break; + // Shadow Dance - remove stealth mode stand flag + case FORM_SHADOW_DANCE: + m_target->RemoveStandFlags(UNIT_STAND_FLAGS_CREEP); + break; default: break; }

i've trying to apply patch on clean mangos... http://paste2.org/p/565237 but it fails on compilation 2>..\\..\\src\\game\\SpellEffects.cpp(4782) : error C2065: 'AURA_STATE_BLEEDING' : undeclared identifier 2>..\\..\\src\\game\\Unit.cpp(9550) : error C2065: 'AURA_STATE_BLEEDING' : undeclared identifier

your patch is outdated. http://github.com/insider42/mangos/commit/e7a0f289d9dec14dfb2e3fdde5f1068293c5f28b

patch doesn't work now. Spell 64380 doesn't remove immunity

you should provide your server logs with log_file_level=3 as i already said

i didn't post a fix for you last libram... anyway you should update your server to 8961 or later

thanks, second version works without crash, but when soul leech proc - your pet gain full mana bar (for example your pet have 17/3933 mana, when it proc - pet gain so much amount of mana that makes his bar to be full 3933/3933)

It's Judgement of Light problem and related to patches also happens only at windows

in thread #3 It is normal? Can you post a code in _yours_ Unit.cpp line 12055 and 6853?

this patch created a crash on my test server. Equip http://www.wowhead.com/?spell=54696 , turn Seal of Command on, use a Judgement of Light on your target many times, when trinket proc and you maky another Judgement of Light - server crash. And very strange thing - server crash happens only at Windows O_o *** Operation System *** Microsoft Windows Server 2003 Enterprise Edition Service Pack 2 (Version 5.2, Build 3790) //===================================================== Exception code: C00000FD STACK_OVERFLOW Fault address: 004307D7 01:0002F7D7 C:\\WoW Server\\wow\\mangosd.exe Registers: EAX:093D2000 EBX:F3C8FBC8 ECX:093D1454 EDX:00000003 ESI:00000000 EDI:00886AD0 CS:EIP:0023:004307D7 SS:ESP:002B:093DC518 EBP:093DC520 DS:002B ES:002B FS:0053 GS:002B Flags:00010206 Call stack: Address Frame Function SourceFile 004307D7 00000000 _chkstk+27 006BE625 00000000 Spell::CheckItems+B5 006B9A41 00000000 Spell::CheckCast+E71 006B319F 00000000 Spell::Prepare+28F 00459FF5 00000000 Unit::CastSpell+1B5 00459E38 00000000 Unit::CastSpell+118 0046FBBA 00000000 Unit::HandleProcTriggerSpell+20FA 0047F696 00000000 Unit::ProcDamageAndSpellFor+666 00466D2F 00000000 Unit::ProcDamageAndSpell+2F 006AD4D3 00000000 Spell::DoAllEffectOnTarget+2C3 006B4206 00000000 Spell::handle_immediate+E6 006B403D 00000000 Spell::cast+9FD 006B32A3 00000000 Spell::Prepare+393 0045A22D 00000000 Unit::CastCustomSpell+16D 0045A0B2 00000000 Unit::CastCustomSpell+82 0046ABDF 00000000 Unit::HandleDummyAuraProc+329F 0047F874 00000000 Unit::ProcDamageAndSpellFor+844 00466D73 00000000 Unit::ProcDamageAndSpell+73 006AD645 00000000 Spell::DoAllEffectOnTarget+435 006B4206 00000000 Spell::handle_immediate+E6 006B403D 00000000 Spell::cast+9FD 006B32A3 00000000 Spell::Prepare+393 00459FF5 00000000 Unit::CastSpell+1B5 00823A58 00000000 Spell::EffectDummy+4868 006B88CF 00000000 Spell::HandleEffects+CF 006ADFEB 00000000 Spell::DoSpellHitOnUnit+67B 006AD3C5 00000000 Spell::DoAllEffectOnTarget+1B5 006B4206 00000000 Spell::handle_immediate+E6 006B403D 00000000 Spell::cast+9FD 006B32A3 00000000 Spell::Prepare+393 00459FF5 00000000 Unit::CastSpell+1B5 00459E38 00000000 Unit::CastSpell+118 00832908 00000000 Spell::EffectScriptEffect+22C8 006B88CF 00000000 Spell::HandleEffects+CF 006ADFEB 00000000 Spell::DoSpellHitOnUnit+67B 006AD3C5 00000000 Spell::DoAllEffectOnTarget+1B5 006B4206 00000000 Spell::handle_immediate+E6 006B403D 00000000 Spell::cast+9FD 006B4B00 00000000 Spell::update+290 006C0D6D 00000000 SpellEvent::Execute+2D 008DF3FC 00000000 EventProcessor::Update+EC 00456BFB 00000000 Unit::Update+3B 004CDACC 00000000 Player::Update+EC 004A0339 00000000 Map::Update+D9 0060F7C8 00000000 MapManager::Update+128 005F375B 00000000 World::Update+77B 004304CE 00000000 WorldRunnable::run+8E 00886AE9 00000000 ACE_Based::Thread::ThreadTask+19 00B714D4 00000000 ?invoke@ACE_OS_Thread_Adapter@@UAEKXZ+74 78543433 00000000 _endthreadex+44 785434C7 00000000 _endthreadex+D8 7D4DFE21 00000000 FlsSetValue+136

What bug does the patch fix? What features does the patch add? Fixes work of this talent For which repository revision was the patch created? 89** Is there a thread in the bug report section or at lighthouse? If yes, please add a link to the thread. --- Who has been writing this patch? Please include either forum user names or email addresses. Beaste (aka Laise) diff --git a/src/game/Unit.cpp b/src/game/Unit.cpp index b1c0786..103f4fb 100644 --- a/src/game/Unit.cpp +++ b/src/game/Unit.cpp @@ -6063,6 +6063,23 @@ bool Unit::HandleDummyAuraProc(Unit *pVictim, uint32 damage, Aura* triggeredByAu return false; break; } + // Frozen Power + if (dummySpell->SpellIconID == 3780) + { + Unit *caster = triggeredByAura->GetCaster(); + + if (!procSpell || !caster) + return false; + + float distance = caster->GetDistance(pVictim); + int32 chance = triggerAmount; + + if (distance < 15.0f || !roll_chance_i(chance)) + return false; + + triggered_spell_id = 63685; + break; + } break; } case SPELLFAMILY_DEATHKNIGHT: DELETE FROM `spell_proc_event` WHERE `entry` = 63373; INSERT INTO `spell_proc_event` VALUES (63373,0x00,11,0x80000000,0x00000000,0x00000000,0x00010000,0x00000000,0.000000,0.000000,0);

It's bad... i think you should try similar but still working patch diff --git a/src/game/SpellEffects.cpp b/src/game/SpellEffects.cpp index 906a197..d505322 100644 --- a/src/game/SpellEffects.cpp +++ b/src/game/SpellEffects.cpp @@ -1360,6 +1360,35 @@ void Spell::EffectDummy(uint32 i) m_damage+= uint32(damage * m_caster->GetTotalAttackPowerValue(BASE_ATTACK) / 100); return; } + // Overpower + if(m_spellInfo->SpellFamilyFlags & 0x4) + { + // Must be casting target + if (!unitTarget->IsNonMeleeSpellCasted(false)) + return; + // Find Unrelenting Assault + Unit::AuraList const& modifierAuras = m_caster->GetAurasByType(SPELL_AURA_ADD_FLAT_MODIFIER); + for(Unit::AuraList::const_iterator itr = modifierAuras.begin(); itr != modifierAuras.end(); ++itr) + { + if((*itr)->GetSpellProto()->SpellFamilyName==SPELLFAMILY_WARRIOR && (*itr)->GetSpellProto()->SpellIconID == 2775) + { + switch ((*itr)->GetSpellProto()->Id) + { + // Unrelenting Assault, rank 1 + case 46859: + m_caster->CastSpell(unitTarget,64849,true,0,(*itr)); + break; + // Unrelenting Assault, rank 2 + case 46860: + m_caster->CastSpell(unitTarget,64850,true,0,(*itr)); + break; + default: + break; + } + } + } + return; + } switch(m_spellInfo->Id) { // Warrior's Wrath

I'm (Insider42) not author of that patch, i've only changed it for work on latest revisions.

you can try to add Unit* caster = GetCaster(); somewhere before patch code